patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Anoob Joseph <anoobj@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'doc: replace code blocks with includes in security guide' has been queued to stable release 21.11.6
Date: Thu,  2 Nov 2023 13:11:34 +0000	[thread overview]
Message-ID: <20231102131254.315947-28-ktraynor@redhat.com> (raw)
In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/08/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/de8bdca2b3b761a8833de512c695913c54a76fc8

Thanks.

Kevin

---
From de8bdca2b3b761a8833de512c695913c54a76fc8 Mon Sep 17 00:00:00 2001
From: Anoob Joseph <anoobj@marvell.com>
Date: Fri, 18 Aug 2023 14:59:42 +0530
Subject: [PATCH] doc: replace code blocks with includes in security guide

[ upstream commit 03e3cfda1679998aa512464affb8dd293146364a ]

Add literal includes to copy code block while compiling. Having a copy
may lead to mismatch if code is updated without updating the doc.

Fixes: 40ff8c99ea99 ("doc: add details of security library")

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
 doc/guides/prog_guide/rte_security.rst | 65 +++++---------------------
 lib/security/rte_security.h            |  6 +++
 2 files changed, 18 insertions(+), 53 deletions(-)

diff --git a/doc/guides/prog_guide/rte_security.rst b/doc/guides/prog_guide/rte_security.rst
index 72ca0bd330..8619757e84 100644
--- a/doc/guides/prog_guide/rte_security.rst
+++ b/doc/guides/prog_guide/rte_security.rst
@@ -593,23 +593,8 @@ Security session configuration
 Security Session configuration structure is defined as ``rte_security_session_conf``
 
-.. code-block:: c
-
-    struct rte_security_session_conf {
-        enum rte_security_session_action_type action_type;
-        /**< Type of action to be performed on the session */
-        enum rte_security_session_protocol protocol;
-        /**< Security protocol to be configured */
-        union {
-                struct rte_security_ipsec_xform ipsec;
-                struct rte_security_macsec_xform macsec;
-                struct rte_security_pdcp_xform pdcp;
-                struct rte_security_docsis_xform docsis;
-        };
-        /**< Configuration parameters for security session */
-        struct rte_crypto_sym_xform *crypto_xform;
-        /**< Security Session Crypto Transformations */
-        void *userdata;
-        /**< Application specific userdata to be saved with session */
-    };
+.. literalinclude:: ../../../lib/security/rte_security.h
+   :language: c
+   :start-after: Structure rte_security_session_conf 8<
+   :end-before: >8 End of structure rte_security_session_conf.
 
 The configuration structure reuses the ``rte_crypto_sym_xform`` struct for crypto related
@@ -618,41 +603,15 @@ session is configured for Lookaside Protocol offload or Inline Crypto or Inline
 Offload.
 
-.. code-block:: c
-
-    enum rte_security_session_action_type {
-        RTE_SECURITY_ACTION_TYPE_NONE,
-        /**< No security actions */
-        RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
-        /**< Crypto processing for security protocol is processed inline
-         * during transmission
-         */
-        RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
-        /**< All security protocol processing is performed inline during
-         * transmission
-         */
-        RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL,
-        /**< All security protocol processing including crypto is performed
-         * on a lookaside accelerator
-         */
-        RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO
-        /**< Similar to ACTION_TYPE_NONE but crypto processing for security
-         * protocol is processed synchronously by a CPU.
-         */
-    };
+.. literalinclude:: ../../../lib/security/rte_security.h
+   :language: c
+   :start-after: Enumeration of rte_security_session_action_type 8<
+   :end-before: >8 End enumeration of rte_security_session_action_type.
 
 The ``rte_security_session_protocol`` is defined as
 
-.. code-block:: c
-
-    enum rte_security_session_protocol {
-        RTE_SECURITY_PROTOCOL_IPSEC = 1,
-        /**< IPsec Protocol */
-        RTE_SECURITY_PROTOCOL_MACSEC,
-        /**< MACSec Protocol */
-        RTE_SECURITY_PROTOCOL_PDCP,
-        /**< PDCP Protocol */
-        RTE_SECURITY_PROTOCOL_DOCSIS,
-        /**< DOCSIS Protocol */
-    };
+.. literalinclude:: ../../../lib/security/rte_security.h
+   :language: c
+   :start-after: Enumeration of rte_security_session_protocol 8<
+   :end-before: >8 End enumeration of rte_security_session_protocol.
 
 Currently the library defines configuration parameters for IPsec and PDCP only.
diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h
index 1a15e95267..71af1bf3e3 100644
--- a/lib/security/rte_security.h
+++ b/lib/security/rte_security.h
@@ -454,4 +454,5 @@ struct rte_security_docsis_xform {
  * Security session action type.
  */
+/* Enumeration of rte_security_session_action_type 8<*/
 enum rte_security_session_action_type {
 	RTE_SECURITY_ACTION_TYPE_NONE,
@@ -474,6 +475,8 @@ enum rte_security_session_action_type {
 	 */
 };
+/* >8 End enumeration of rte_security_session_action_type. */
 
 /** Security session protocol definition */
+/* Enumeration of rte_security_session_protocol 8<*/
 enum rte_security_session_protocol {
 	RTE_SECURITY_PROTOCOL_IPSEC = 1,
@@ -486,8 +489,10 @@ enum rte_security_session_protocol {
 	/**< DOCSIS Protocol */
 };
+/* >8 End enumeration of rte_security_session_protocol. */
 
 /**
  * Security session configuration
  */
+/* Structure rte_security_session_conf 8< */
 struct rte_security_session_conf {
 	enum rte_security_session_action_type action_type;
@@ -508,4 +513,5 @@ struct rte_security_session_conf {
 	/**< Application specific userdata to be saved with session */
 };
+/* >8 End of structure rte_security_session_conf. */
 
 struct rte_security_session {
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-02 13:09:41.561249512 +0000
+++ 0028-doc-replace-code-blocks-with-includes-in-security-gu.patch	2023-11-02 13:09:40.824163371 +0000
@@ -1 +1 @@
-From 03e3cfda1679998aa512464affb8dd293146364a Mon Sep 17 00:00:00 2001
+From de8bdca2b3b761a8833de512c695913c54a76fc8 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 03e3cfda1679998aa512464affb8dd293146364a ]
+
@@ -10 +11,0 @@
-Cc: stable@dpdk.org
@@ -20 +21 @@
-index 7418e35c1b..ae8b0aaef3 100644
+index 72ca0bd330..8619757e84 100644
@@ -23 +24 @@
-@@ -672,23 +672,8 @@ Security session configuration
+@@ -593,23 +593,8 @@ Security session configuration
@@ -51 +52 @@
-@@ -697,41 +682,15 @@ session is configured for Lookaside Protocol offload or Inline Crypto or Inline
+@@ -618,41 +603,15 @@ session is configured for Lookaside Protocol offload or Inline Crypto or Inline
@@ -102 +103 @@
-index 3f8abfef15..c6550f4d8d 100644
+index 1a15e95267..71af1bf3e3 100644
@@ -105 +106 @@
-@@ -623,4 +623,5 @@ struct rte_security_docsis_xform {
+@@ -454,4 +454,5 @@ struct rte_security_docsis_xform {
@@ -111 +112 @@
-@@ -643,6 +644,8 @@ enum rte_security_session_action_type {
+@@ -474,6 +475,8 @@ enum rte_security_session_action_type {
@@ -120 +121 @@
-@@ -655,8 +658,10 @@ enum rte_security_session_protocol {
+@@ -486,8 +489,10 @@ enum rte_security_session_protocol {
@@ -131 +132 @@
-@@ -676,4 +681,5 @@ struct rte_security_session_conf {
+@@ -508,4 +513,5 @@ struct rte_security_session_conf {
@@ -136 +137 @@
- /**
+ struct rte_security_session {


  parent reply	other threads:[~2023-11-02 13:13 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 13:11 patch 'mempool: fix default ops for an empty mempool' " Kevin Traynor
2023-11-02 13:11 ` patch 'eal/unix: fix firmware reading with external xz helper' " Kevin Traynor
2023-11-02 13:11 ` patch 'rawdev: fix device class in log message' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/bonding: fix header for C++' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/sfc: set max Rx packet length for representors' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/sfc: account for data offset on Tx' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/sfc: add missing error code indication to MAE init path' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/hns3: fix VF default MAC modified when set failed' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/hns3: fix error code for multicast resource' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/hns3: fix flushing multicast MAC address' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/hns3: fix order in NEON Rx' " Kevin Traynor
2023-11-02 13:11 ` patch 'random: initialize state for unregistered non-EAL threads' " Kevin Traynor
2023-11-02 13:11 ` patch 'bus/dpaa: fix build with asserts for GCC 13' " Kevin Traynor
2023-11-02 13:11 ` patch 'hash: align SSE lookup to scalar implementation' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/netvsc: increase VSP response timeout to 60 seconds' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/txgbe: add Tx queue maximum limit' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/txgbe: fix GRE tunnel packet checksum' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/ngbe: fix flow control' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/txgbe: reconfigure MAC Rx when link update' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/ngbe: " Kevin Traynor
2023-11-02 13:11 ` patch 'net/txgbe: keep link down after device close' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/ngbe: " Kevin Traynor
2023-11-02 13:11 ` patch 'net/txgbe: check process type in close operation' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/ngbe: " Kevin Traynor
2023-11-02 13:11 ` patch 'net/tap: use MAC address parse API instead of local parser' " Kevin Traynor
2023-11-02 13:11 ` patch 'app/testpmd: fix help string' " Kevin Traynor
2023-11-02 13:11 ` patch 'cryptodev: add missing doc for security context' " Kevin Traynor
2023-11-02 13:11 ` Kevin Traynor [this message]
2023-11-02 13:11 ` patch 'test/crypto: fix IV in some vectors' " Kevin Traynor
2023-11-02 13:11 ` patch 'test/crypto: skip some synchronous tests with CPU crypto' " Kevin Traynor
2023-11-02 13:11 ` patch 'test/crypto: fix typo in asym tests' " Kevin Traynor
2023-11-02 13:11 ` patch 'crypto/ipsec_mb: add dependency check for cross build' " Kevin Traynor
2023-11-02 13:11 ` patch 'eventdev: fix symbol export for port maintenance' " Kevin Traynor
2023-11-02 13:11 ` patch 'bus/pci: fix device ID log' " Kevin Traynor
2023-11-02 13:11 ` patch 'event/cnxk: fix getwork mode devargs parsing' " Kevin Traynor
2023-11-02 13:11 ` patch 'event/cnxk: fix return values for capability API' " Kevin Traynor
2023-11-02 13:11 ` patch 'test/event: fix crypto null device creation' " Kevin Traynor
2023-11-02 13:11 ` patch 'event/sw: remove obsolete comment' " Kevin Traynor
2023-11-02 13:11 ` patch 'eventdev/eth_rx: fix timestamp field register in mbuf' " Kevin Traynor
2023-11-02 13:11 ` patch 'event/sw: fix ordering corruption with op release' " Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: fix default flow action setting' " Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: fix xstats for different packet sizes' " Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: fix different size bit operations' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/cnxk: fix uninitialized variable' " Kevin Traynor
2023-11-02 13:11 ` Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: fix DPI memzone name' " Kevin Traynor
2023-11-02 13:11 ` patch 'dma/cnxk: fix device state' " Kevin Traynor
2023-11-02 13:11 ` patch 'mempool/cnxk: fix free from non-EAL threads' " Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: fix aura disable handling' " Kevin Traynor
2023-11-02 13:11 ` patch 'common/cnxk: remove dead Meson code' " Kevin Traynor
2023-11-02 13:11 ` patch 'baseband/acc: fix ACC100 HARQ input alignment' " Kevin Traynor
2023-11-02 13:11 ` patch 'app/bbdev: fix link with NXP LA12XX' " Kevin Traynor
2023-11-02 13:11 ` patch 'net/i40e: fix FDIR queue receives broadcast packets' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ice: write timestamp to first segment in scattered Rx' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix VLAN offload strip flag' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix checksum offloading' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/i40e: fix buffer leak on Rx reconfiguration' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ice: fix TM configuration clearing' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix port stats " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: unregister interrupt handler before FD close' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix ESN session update' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ice: fix initial link status' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix Tx debug' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: remove log from Tx prepare function' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/iavf: fix TSO with big segments' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ice: remove log from Tx prepare function' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ice: fix TSO with big segments' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/mlx5: fix leak in sysfs port name translation' " Kevin Traynor
2023-11-02 13:12 ` patch 'fib: fix adding default route overwriting entire table' " Kevin Traynor
2023-11-02 13:12 ` patch 'fib6: fix adding default route as first route' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/af_packet: fix Rx and Tx queue state' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/af_xdp: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/avp: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/bnx2x: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/bnxt: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/bonding: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/cxgbe: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/dpaa: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/dpaa2: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/e1000: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ena: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/enetc: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/enic: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/hinic: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ipn3ke: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/memif: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/mlx4: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/mvneta: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/mvpp2: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ngbe: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/null: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/octeon_ep: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/pfe: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/ring: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/sfc: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/softnic: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/txgbe: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/vhost: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/virtio: " Kevin Traynor
2023-11-02 13:12 ` patch 'net/vmxnet3: " Kevin Traynor
2023-11-02 13:12 ` patch 'app/testpmd: fix primary process not polling all queues' " Kevin Traynor
2023-11-02 13:12 ` patch 'net/bonding: fix link status callback stop' " Kevin Traynor
2023-11-02 13:12 ` patch 'app/procinfo: remove unnecessary rte_malloc' " Kevin Traynor
2023-11-02 13:12 ` patch 'malloc: remove return from void functions' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231102131254.315947-28-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=anoobj@marvell.com \
    --cc=gakhil@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).