From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A65A74326F for ; Thu, 2 Nov 2023 14:14:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC95642DEF; Thu, 2 Nov 2023 14:14:12 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0329F42DE1 for ; Thu, 2 Nov 2023 14:14:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/jxxqLl7sfB9e4upJbdzAVYqx4xLCJzsMT4qFfX+KAQ=; b=WglaLGRWpd9okb8aKB1sOBQ9j/yfN5Hh6/xieAp7ryFeeoqV6Ulq28pShSJFWztrn4DvTE 9MCrH4p8myT9lsLubzZz3M5/poTGaWiMDx3NLkw8BvnEOqgCmxKm5hv3RG95fppsh4l55G slkFDkOrpmbu55tn4xvmj8w9tYKdCLk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-Z55EX3iwMQ-UM3w3E8AZLQ-1; Thu, 02 Nov 2023 09:14:10 -0400 X-MC-Unique: Z55EX3iwMQ-UM3w3E8AZLQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00DF3811E82; Thu, 2 Nov 2023 13:14:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49B86492BFA; Thu, 2 Nov 2023 13:14:09 +0000 (UTC) From: Kevin Traynor To: Akhil Goyal Cc: dpdk stable Subject: patch 'net/cnxk: fix uninitialized variable' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:50 +0000 Message-ID: <20231102131254.315947-44-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/723ae321d20065b0c4c48b8788d071e578959ff4 Thanks. Kevin --- >From 723ae321d20065b0c4c48b8788d071e578959ff4 Mon Sep 17 00:00:00 2001 From: Akhil Goyal Date: Fri, 11 Aug 2023 14:28:00 +0530 Subject: [PATCH] net/cnxk: fix uninitialized variable [ upstream commit 06f089b8e80d102a899c97b8691b4e1b82f25d7e ] sa_base may be uninitialized in for cases. Initialize it. Fixes: 4382a7ccf781 ("net/cnxk: support Rx security offload on cn10k") Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_rx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index 42812d5bd3..9d71a9352e 100644 --- a/drivers/net/cnxk/cn10k_rx.h +++ b/drivers/net/cnxk/cn10k_rx.h @@ -425,5 +425,5 @@ cn10k_nix_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts, struct rte_mbuf *mbuf; uint64_t aura_handle; - uint64_t sa_base; + uint64_t sa_base = 0; uint16_t lmt_id; uint64_t laddr; @@ -549,7 +549,7 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, uint8x16_t f0, f1, f2, f3; uint16_t lmt_id, d_off; + uintptr_t sa_base = 0; uint16_t packets = 0; uint16_t pkts_left; - uintptr_t sa_base; uint32_t head; uintptr_t cq0; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:41.920717938 +0000 +++ 0044-net-cnxk-fix-uninitialized-variable.patch 2023-11-02 13:09:40.845163438 +0000 @@ -1 +1 @@ -From 06f089b8e80d102a899c97b8691b4e1b82f25d7e Mon Sep 17 00:00:00 2001 +From 723ae321d20065b0c4c48b8788d071e578959ff4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 06f089b8e80d102a899c97b8691b4e1b82f25d7e ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index a2ecb25211..cc224eb154 100644 +index 42812d5bd3..9d71a9352e 100644 @@ -20 +21 @@ -@@ -995,6 +995,6 @@ cn10k_nix_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts, +@@ -425,5 +425,5 @@ cn10k_nix_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t pkts, @@ -23,2 +23,0 @@ -+ uint64_t sa_base = 0; - uintptr_t cpth = 0; @@ -25,0 +25 @@ ++ uint64_t sa_base = 0; @@ -28 +28,2 @@ -@@ -1144,7 +1144,7 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, +@@ -549,7 +549,7 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf **mbufs, uint16_t pkts, + uint8x16_t f0, f1, f2, f3; @@ -30 +30,0 @@ - uint64_t lbase, laddr;