From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E153C4326F for ; Thu, 2 Nov 2023 14:14:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CEF742DEF; Thu, 2 Nov 2023 14:14:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4FE8242DE6 for ; Thu, 2 Nov 2023 14:14:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JaTeS/JydnASsE6tMdcf1Y+nD0hlhZCTp3rAYsw2rew=; b=fi3L2/piNSxWX4WQslTs8MR3XXDp4mVmwXqiIS2apLCe8j0g0cD+o7g96uecyAmxI+jLRF grio45f43+K6ABGkbqqvbBBB0on9QjCjuYfu0ft93uIkCKYFdnhY6G2OBg/W82t5fL01+/ GprYuk9hduJBv7PFZtTPfMbs4vVM6iE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-Mimx8eqqPSWgRe2yVQbXTw-1; Thu, 02 Nov 2023 09:14:11 -0400 X-MC-Unique: Mimx8eqqPSWgRe2yVQbXTw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F22861C04320; Thu, 2 Nov 2023 13:14:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BC92492BFA; Thu, 2 Nov 2023 13:14:10 +0000 (UTC) From: Kevin Traynor To: Akhil Goyal Cc: dpdk stable Subject: patch 'net/cnxk: fix uninitialized variable' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:51 +0000 Message-ID: <20231102131254.315947-45-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a2e1ba51cd186af8ada2bdfcd20b1f0397f56ad6 Thanks. Kevin --- >From a2e1ba51cd186af8ada2bdfcd20b1f0397f56ad6 Mon Sep 17 00:00:00 2001 From: Akhil Goyal Date: Fri, 11 Aug 2023 14:28:02 +0530 Subject: [PATCH] net/cnxk: fix uninitialized variable [ upstream commit 7feaf39ce6047ca346dbf141670515b4be4c2fbf ] Shift may be uninitialized in certain case, initialize it. Fixes: 55bfac717c72 ("net/cnxk: support Tx security offload on cn10k") Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_tx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h index 692d7978fc..bd9eba08e9 100644 --- a/drivers/net/cnxk/cn10k_tx.h +++ b/drivers/net/cnxk/cn10k_tx.h @@ -1497,4 +1497,5 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, struct cn10k_eth_txq *txq = tx_queue; rte_iova_t io_addr = txq->io_addr; + uint8_t lnum, shift = 0, loff; uintptr_t laddr = txq->lmt_base; uint8_t c_lnum, c_shft, c_loff; @@ -1503,5 +1504,4 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, uint64x2_t xmask01, xmask23; uintptr_t c_laddr = laddr; - uint8_t lnum, shift, loff; rte_iova_t c_io_addr; uint64_t sa_base; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:41.942117657 +0000 +++ 0045-net-cnxk-fix-uninitialized-variable.patch 2023-11-02 13:09:40.846163442 +0000 @@ -1 +1 @@ -From 7feaf39ce6047ca346dbf141670515b4be4c2fbf Mon Sep 17 00:00:00 2001 +From a2e1ba51cd186af8ada2bdfcd20b1f0397f56ad6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7feaf39ce6047ca346dbf141670515b4be4c2fbf ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index 59a318a597..cb9751b81f 100644 +index 692d7978fc..bd9eba08e9 100644 @@ -20,2 +21,2 @@ -@@ -2000,4 +2000,5 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, - uint64x2_t xmask01_w1, xmask23_w1; +@@ -1497,4 +1497,5 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, + struct cn10k_eth_txq *txq = tx_queue; @@ -23 +24 @@ -+ uint8_t lnum, shift = 0, loff = 0; ++ uint8_t lnum, shift = 0, loff; @@ -26 +27 @@ -@@ -2007,5 +2008,4 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, +@@ -1503,5 +1504,4 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, struct rte_mbuf **tx_pkts, @@ -29 +30 @@ -- uint8_t lnum, shift, loff = 0; +- uint8_t lnum, shift, loff;