From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 698874326F for ; Thu, 2 Nov 2023 14:14:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 640E642DED; Thu, 2 Nov 2023 14:14:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5B9E742DFF for ; Thu, 2 Nov 2023 14:14:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hi5m7QgE3nxKpWIKX5jX9qeqNXqCXNirwWYaNq3CuSk=; b=gmxNOuqrWkAvSK0VuC37nolIb5/u4h8Zoy6iDHjrcaYG1IwYmmVghZrNvnYjYMKnPTw9p9 BFWxGeAtpeAA5yIFHXTVz0a/icrfEqMZCeYl9pdoXT5fayQ0FmwV5rnMQ9QCvlAIgbD+ZB 88Q6Llv5dt4UCRF+HgCAsT4cyD9dB+4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-d_mdQwPqPcmIkkoXMtyZAw-1; Thu, 02 Nov 2023 09:14:17 -0400 X-MC-Unique: d_mdQwPqPcmIkkoXMtyZAw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FC361019C83; Thu, 2 Nov 2023 13:14:17 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8849C492BFC; Thu, 2 Nov 2023 13:14:16 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix ACC100 HARQ input alignment' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:11:57 +0000 Message-ID: <20231102131254.315947-51-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e166b7fd155b3fa656385f429dc0b8aa53135bea Thanks. Kevin --- >From e166b7fd155b3fa656385f429dc0b8aa53135bea Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Tue, 19 Sep 2023 11:24:17 -0700 Subject: [PATCH] baseband/acc: fix ACC100 HARQ input alignment [ upstream commit 7d048916644d7777872f957901222f2654b234dd ] Some constraints are imposed onto the ACC100 HARQ input size, but that value is incorrectly aligned down when getting close to max (Ncb-F) which is not required. The wireless performance impact is negligeable but still causes a few LLRs no to be combined at the very end of the circular buffer. Fixes: 5802f36dd492 ("baseband/acc100: enforce additional check on FCW") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 5ac2f96a84..d84a8839e0 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -1376,5 +1376,5 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, /* Alignment on next 64B - Already enforced from HC output */ - harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC100_HARQ_ALIGN_64B); + harq_in_length = RTE_ALIGN_CEIL(harq_in_length, ACC100_HARQ_ALIGN_64B); /* Stronger alignment requirement when in decompression mode */ -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:42.070780222 +0000 +++ 0051-baseband-acc-fix-ACC100-HARQ-input-alignment.patch 2023-11-02 13:09:40.852163461 +0000 @@ -1 +1 @@ -From 7d048916644d7777872f957901222f2654b234dd Mon Sep 17 00:00:00 2001 +From e166b7fd155b3fa656385f429dc0b8aa53135bea Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7d048916644d7777872f957901222f2654b234dd ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ - drivers/baseband/acc/rte_acc100_pmd.c | 2 +- + drivers/baseband/acc100/rte_acc100_pmd.c | 2 +- @@ -21,5 +22,5 @@ -diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c -index 5362d39c30..c736f3e420 100644 ---- a/drivers/baseband/acc/rte_acc100_pmd.c -+++ b/drivers/baseband/acc/rte_acc100_pmd.c -@@ -1219,5 +1219,5 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, +diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c +index 5ac2f96a84..d84a8839e0 100644 +--- a/drivers/baseband/acc100/rte_acc100_pmd.c ++++ b/drivers/baseband/acc100/rte_acc100_pmd.c +@@ -1376,5 +1376,5 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, @@ -28,2 +29,2 @@ -- harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC_HARQ_ALIGN_64B); -+ harq_in_length = RTE_ALIGN_CEIL(harq_in_length, ACC_HARQ_ALIGN_64B); +- harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC100_HARQ_ALIGN_64B); ++ harq_in_length = RTE_ALIGN_CEIL(harq_in_length, ACC100_HARQ_ALIGN_64B);