From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BCC44326F for ; Thu, 2 Nov 2023 14:14:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1686E42E22; Thu, 2 Nov 2023 14:14:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A627442DE6 for ; Thu, 2 Nov 2023 14:14:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tq7if6K+2fGNM7W2dde0NcrbwqFvbVLgAGZOelpr4dc=; b=DF377XOEgZi+KmFF/g8AkUlHnf/BR9yknHf9wjeMKD4w/ABRXeqpv8A+QUub2apxkmW45n VsTPUKWX8z2fhcgHUCk0klH3vGjhTKyaE9c01HiMqADGm1P7ZttE0k4Q9Gecdk2bhXZlon CHC13Jvkb49/LSDFMPzLV4sLMQiY7pw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-7VZhmvM_Mt-rrI11NBoEQA-1; Thu, 02 Nov 2023 09:14:36 -0400 X-MC-Unique: 7VZhmvM_Mt-rrI11NBoEQA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C3C7A82BA85; Thu, 2 Nov 2023 13:14:35 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02A9D474FA1; Thu, 2 Nov 2023 13:14:34 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Qi Zhang , dpdk stable Subject: patch 'net/ice: remove log from Tx prepare function' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:12:12 +0000 Message-ID: <20231102131254.315947-66-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d4041c9e0561e7ddcd3ad1fa3ef28287120c26f2 Thanks. Kevin --- >From d4041c9e0561e7ddcd3ad1fa3ef28287120c26f2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 27 Sep 2023 11:41:47 +0200 Subject: [PATCH] net/ice: remove log from Tx prepare function [ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] ice_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message in those branches is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") Fixes: 688cb2f2c61e ("net/ice: fix scalar Tx path segment") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index a6921e1c18..6e91cc226b 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3514,5 +3514,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; } @@ -3533,5 +3532,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (ice_check_empty_mbuf(m) != 0) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: last mbuf data_len=[0]"); return i; } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:42.426064994 +0000 +++ 0066-net-ice-remove-log-from-Tx-prepare-function.patch 2023-11-02 13:09:40.879163547 +0000 @@ -1 +1 @@ -From 9aa546d868b60027a6723f1a772d287d44f17ef8 Mon Sep 17 00:00:00 2001 +From d4041c9e0561e7ddcd3ad1fa3ef28287120c26f2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index e07c6d1f15..d5513e9e93 100644 +index a6921e1c18..6e91cc226b 100644 @@ -25 +26 @@ -@@ -3709,5 +3709,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3514,5 +3514,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, @@ -31 +32 @@ -@@ -3728,5 +3727,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3533,5 +3532,4 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,