From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD8CB4326F for ; Thu, 2 Nov 2023 14:14:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3CEB42E2F; Thu, 2 Nov 2023 14:14:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D39EF42DE6 for ; Thu, 2 Nov 2023 14:14:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tcf0+lgxu8vozEs/6L1hXI0OoOa29kcRDN5wYKw0WE=; b=gFnauKnUq571Fr8qO9Lq1BPocsgTDWgeS/1C/ZXyXdea8HdlW4I9OGg1PWxszhxR6VpX7H AV4ah9SIRrJ1KotPEiqPANjb2Rv9wQD2RbKyyQkTdwNIz+x33R9Xbvy8bgn9WD2hQgegci KttSPqWLw8vJEfOpZQjdrJaGgy70rmQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-104wAlcqMAWZbkwvlXEqpw-1; Thu, 02 Nov 2023 09:14:42 -0400 X-MC-Unique: 104wAlcqMAWZbkwvlXEqpw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3471782BA86; Thu, 2 Nov 2023 13:14:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C142474FA0; Thu, 2 Nov 2023 13:14:41 +0000 (UTC) From: Kevin Traynor To: Jie Hai Cc: Ferruh Yigit , dpdk stable Subject: patch 'net/af_xdp: fix Rx and Tx queue state' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:12:18 +0000 Message-ID: <20231102131254.315947-72-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/36cbe7901c26227fae6ac606bf7c1115cd659996 Thanks. Kevin --- >From 36cbe7901c26227fae6ac606bf7c1115cd659996 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Fri, 8 Sep 2023 19:28:28 +0800 Subject: [PATCH] net/af_xdp: fix Rx and Tx queue state [ upstream commit 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 ] The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the driver needs to modify the queue state in time according to the actual situation. Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information") Signed-off-by: Jie Hai Acked-by: Ferruh Yigit --- drivers/net/af_xdp/rte_eth_af_xdp.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 68bae5610e..9918d3c5fd 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -654,5 +654,11 @@ static int eth_dev_start(struct rte_eth_dev *dev) { + uint16_t i; + dev->data->dev_link.link_status = RTE_ETH_LINK_UP; + for (i = 0; i < dev->data->nb_rx_queues; i++) { + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + } return 0; @@ -663,5 +669,12 @@ static int eth_dev_stop(struct rte_eth_dev *dev) { + uint16_t i; + dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN; + for (i = 0; i < dev->data->nb_rx_queues; i++) { + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + } + return 0; } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:42.559703575 +0000 +++ 0072-net-af_xdp-fix-Rx-and-Tx-queue-state.patch 2023-11-02 13:09:40.884163563 +0000 @@ -1 +1 @@ -From 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 Mon Sep 17 00:00:00 2001 +From 36cbe7901c26227fae6ac606bf7c1115cd659996 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index c7786cc53a..0cc51223ba 100644 +index 68bae5610e..9918d3c5fd 100644 @@ -26 +27 @@ -@@ -695,5 +695,11 @@ static int +@@ -654,5 +654,11 @@ static int @@ -38 +39 @@ -@@ -704,5 +710,12 @@ static int +@@ -663,5 +669,12 @@ static int