From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 033D74326F for ; Thu, 2 Nov 2023 14:15:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDD0642E40; Thu, 2 Nov 2023 14:15:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 235DC4113D for ; Thu, 2 Nov 2023 14:15:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698930899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9vpIdOuky/QcpCXO7lu0AzrKYCG7LMfWRL1/C6eFMz4=; b=bP0b8BjRTdszcKo159W2oM83L6Z1SjHRK82hIO4EvUrkz8MtFOXezYLCFvM0t50oO1B+Dq mAicxVPjjURKW8Fi3GG5GPBaTKuICwB5KzwBkMU3V/SyBUADvMafoKUtjKbxYJKxy4MFb4 tFOMnq8OreX+hJeeCA9BmP0KMBIDnko= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-wfru6rscN9eaQSQ8p2oN2w-1; Thu, 02 Nov 2023 09:14:56 -0400 X-MC-Unique: wfru6rscN9eaQSQ8p2oN2w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6465D85A58C; Thu, 2 Nov 2023 13:14:56 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F7FF492BFA; Thu, 2 Nov 2023 13:14:55 +0000 (UTC) From: Kevin Traynor To: Jie Hai Cc: Rosen Xu , dpdk stable Subject: patch 'net/ipn3ke: fix Rx and Tx queue state' has been queued to stable release 21.11.6 Date: Thu, 2 Nov 2023 13:12:31 +0000 Message-ID: <20231102131254.315947-85-ktraynor@redhat.com> In-Reply-To: <20231102131254.315947-1-ktraynor@redhat.com> References: <20231102131254.315947-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/08/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5c8a28346909a14e05257e6ea4e5752a34e8a378 Thanks. Kevin --- >From 5c8a28346909a14e05257e6ea4e5752a34e8a378 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Fri, 8 Sep 2023 19:28:41 +0800 Subject: [PATCH] net/ipn3ke: fix Rx and Tx queue state [ upstream commit c05fa97fbe14cb58acc4ca7fffbde3a21b78fd18 ] The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the driver needs to modify the queue state in time according to the actual situation. Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information") Signed-off-by: Jie Hai Reviewed-by: Rosen Xu --- drivers/net/ipn3ke/ipn3ke_representor.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c index 9059e4ce0a..b0ead3197b 100644 --- a/drivers/net/ipn3ke/ipn3ke_representor.c +++ b/drivers/net/ipn3ke/ipn3ke_representor.c @@ -121,4 +121,5 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev) uint32_t val; char attr_name[IPN3KE_RAWDEV_ATTR_LEN_MAX]; + uint16_t i; rawdev = hw->rawdev; @@ -191,4 +192,9 @@ ipn3ke_rpst_dev_start(struct rte_eth_dev *dev) ipn3ke_rpst_link_update(dev, 0); + for (i = 0; i < dev->data->nb_rx_queues; i++) + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + for (i = 0; i < dev->data->nb_tx_queues; i++) + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + return 0; } @@ -199,4 +205,5 @@ ipn3ke_rpst_dev_stop(struct rte_eth_dev *dev) struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); struct ipn3ke_rpst *rpst = IPN3KE_DEV_PRIVATE_TO_RPST(dev); + uint16_t i; if (hw->retimer.mac_type == IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) { @@ -208,4 +215,9 @@ ipn3ke_rpst_dev_stop(struct rte_eth_dev *dev) } + for (i = 0; i < dev->data->nb_rx_queues; i++) + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + for (i = 0; i < dev->data->nb_tx_queues; i++) + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + return 0; } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-02 13:09:42.855692836 +0000 +++ 0085-net-ipn3ke-fix-Rx-and-Tx-queue-state.patch 2023-11-02 13:09:40.905163631 +0000 @@ -1 +1 @@ -From c05fa97fbe14cb58acc4ca7fffbde3a21b78fd18 Mon Sep 17 00:00:00 2001 +From 5c8a28346909a14e05257e6ea4e5752a34e8a378 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c05fa97fbe14cb58acc4ca7fffbde3a21b78fd18 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 57ec7a19bc..8145f1bb2a 100644 +index 9059e4ce0a..b0ead3197b 100644