From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E7AA432DA for ; Wed, 8 Nov 2023 20:26:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 485C9406A2; Wed, 8 Nov 2023 20:26:15 +0100 (CET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 1DB2340395 for ; Wed, 8 Nov 2023 20:26:14 +0100 (CET) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-32db188e254so25860f8f.0 for ; Wed, 08 Nov 2023 11:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471574; x=1700076374; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I2BfGvt3II8B3CtIakn9WtnpKZFWyOPc5iqj+QazwsY=; b=EUOG5RrwtpnXbF62fLksjd8z2Z42EPYMvnMr28iMCGh4htmcgSPGDhrVyAP7u55SFb TEM43gGsz3OiGfNAfLehwrLtXteccZQmY3cT9d2NujvTSI3RC0YTXaXBVRxJvzCKS1CK iLjlIT5bsYbgVOpMfEVViXIuOmK0BoQxr0KWXeuTK6g7DnsmhYqKpImzKH0p/Yb7wDqQ RXxXvl1jPOl5szl1qmthJPWs85zPnH5cGT0jusrRue0/8AevKmO8fhPO35Rlkl+fnv+/ zywpVJg30ZT+hPbaX2/BF6HEgFibGYgVfoDCnI4niIzX0f2yja1Uw0TidwVXdsh2leiI uOIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471574; x=1700076374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I2BfGvt3II8B3CtIakn9WtnpKZFWyOPc5iqj+QazwsY=; b=xI6pk1H14txGFpOdlTbR8dlMk8NEl59387jkMPO8xxVhfCYviA9TTkmZxkIreKsZD2 mxgj43t2HhQf1jmBjQ7CHpaKbm4395qnI0ZT2mO+inG3ygRpkjn2aFBOz8neqZ3TWkE+ or8UUSYsVMmOURUTlAfJGCx3FSxpaifWhMzEbjeAEWp79tlDmBpSkvCDJwxoJMKZNsml GFqnXiaC9vcBmqCeVPq43AJ/ByEcMNZpkwR9PuOEuTBV+efHUaHkN/N0TziUIjuW/gED QaAxess6EjS0X2qPlXeQfJL1vQalis0skH3SrXXZaAqU/bi5ukfSrTZ9Lez2tJi27Vvh JsXQ== X-Gm-Message-State: AOJu0Yxm92wCdEfnBmiSO2rU09/npm6hR0cmBA4p5WlJZ3IgJpQoI6B/ SqijauBloDBnTQJdPczn0nU= X-Google-Smtp-Source: AGHT+IEYjlCh4YA+DNiMS86A35P7GBUoFLcMBU/NNAJCEzyupLxqfYtMJof3YQUAdKjLax9YC6YzCA== X-Received: by 2002:adf:f212:0:b0:32f:93b0:66f8 with SMTP id p18-20020adff212000000b0032f93b066f8mr2038552wro.26.1699471573737; Wed, 08 Nov 2023 11:26:13 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id ba15-20020a0560001c0f00b0032326908972sm5665185wrb.17.2023.11.08.11.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:26:13 -0800 (PST) From: luca.boccassi@gmail.com To: Long Wu Cc: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: remove unreachable statement' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:12 +0000 Message-Id: <20231108192535.922238-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9b198fcbaf36cfa08918e233767fa5850088c66f Thanks. Luca Boccassi --- >From 9b198fcbaf36cfa08918e233767fa5850088c66f Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:02 +0800 Subject: [PATCH] test/bonding: remove unreachable statement [ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] CI found that execution cannot reach the expression "else" inside this statement. Coverity issue: 403097 Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding_mode4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 2c835fa7ad..b73f52e19f 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -644,8 +644,7 @@ bond_handshake(void) /* If response didn't send - report failure */ TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); - /* If flags doesn't match - report failure */ - return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; + return TEST_SUCCESS; } #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports) -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:52.732341834 +0000 +++ 0014-test-bonding-remove-unreachable-statement.patch 2023-11-08 19:23:51.769396209 +0000 @@ -1 +1 @@ -From 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 Mon Sep 17 00:00:00 2001 +From 9b198fcbaf36cfa08918e233767fa5850088c66f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 645fc1e0d4..ff13dbed93 100644 +index 2c835fa7ad..b73f52e19f 100644 @@ -25 +26 @@ -@@ -641,8 +641,7 @@ bond_handshake(void) +@@ -644,8 +644,7 @@ bond_handshake(void) @@ -27 +28 @@ - TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n"); + TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); @@ -30 +31 @@ -- return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED; +- return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; @@ -34 +35 @@ - #define TEST_LACP_MEMBER_COUT RTE_DIM(test_params.member_ports) + #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)