From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 762EA432DA for ; Wed, 8 Nov 2023 20:26:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7067442DF3; Wed, 8 Nov 2023 20:26:16 +0100 (CET) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 4E04B42DFD for ; Wed, 8 Nov 2023 20:26:15 +0100 (CET) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-407da05f05aso50622745e9.3 for ; Wed, 08 Nov 2023 11:26:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471575; x=1700076375; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vnb+KGQGvZgtVwYxKtbOpj85wLlHHUp/nP4BTXNeOEA=; b=LMFfUWOxpB5RzwQq8YBSn3dqaHCyCYPrPm42dYU0HvZrTU7uqjgPm3Iq+PjqnUr4ck RucxCDTiGCmBuGUHfwwlqiMRkUpSePh0ySFA6ynTUCnf4BOfaCQmSG3K+tkMpXoD4tyV ceBgOuftvA6iIK4pU7s4FZQBwgg/N5hq8T5fnvsfJQGNHjpCpNoT6rItXLqKkRvWCwxg HJCB4rX+bCR/USjFIxTNuudcAo10tEEaFaAUg6Cf4Pn0E24LTVfIWMfFiMCO7vW5TtIR RXfVb2mG6finVoL+f9nVe5HMQAq338d6Z3k8ToVX9tv5i36QWbjvijS7qsGd9unnjfAZ f11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471575; x=1700076375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vnb+KGQGvZgtVwYxKtbOpj85wLlHHUp/nP4BTXNeOEA=; b=OXHi5mY2ncTjgiB10ZGotqxOd3rXjhP8hOY88C7o+hWPyIRHYDR/sNTi92SjoTUQeX UhN1Nw7+dITNE6hgfZ3c7Xpub2TxKCcKkSbD0SB8r+I13fVX37bIWeEBmFemmrHkrua/ TzyMCzYgXfmzRurI3n0BCMv6qd+MbIB8bdCVge4mNlmYYbjN2vvk5ru6Ixl4fW9nbPvu piRuaX4z0fr/COKcpUaF7k+1zx7uWFejGXhWu9Rd/eHRE4G+ZWAU1NkHsPOdJzjfgfIu c+Y6yo93Jmz5/LFuXPoxcM2RbXP7VGWauckBUZfZ1khWX/cy4g+Fg6t45m9SNNyIBaUK xkdg== X-Gm-Message-State: AOJu0YzBezXDY8YXd9aqdEFY7D2p50yY8D5nkjvtE1jqZjxGKAZscQF7 IoMtS4XjO+CAOaAk3EHLr7x9B1oBT1rQSw== X-Google-Smtp-Source: AGHT+IGrBAkoDvvxFsNoZ4QW0oEzbdiuKoZT4L2PwdCB/SkiOFLszkMQmodmDI7uvOeNNXCwhE9dGg== X-Received: by 2002:a7b:cbd8:0:b0:409:5d7d:b265 with SMTP id n24-20020a7bcbd8000000b004095d7db265mr2628123wmi.38.1699471574832; Wed, 08 Nov 2023 11:26:14 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id a10-20020a5d53ca000000b00326dd5486dcsm5562898wrw.107.2023.11.08.11.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:26:14 -0800 (PST) From: luca.boccassi@gmail.com To: Long Wu Cc: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: add missing check' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:13 +0000 Message-Id: <20231108192535.922238-15-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8 Thanks. Luca Boccassi --- >From 894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8 Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:04 +0800 Subject: [PATCH] test/bonding: add missing check [ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] CI found the function without checking return value in this place. Coverity issue: 403101 Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 4f810efb0a..886fe1680e 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -445,7 +445,8 @@ test_add_already_bonded_slave_to_bonded_device(void) uint16_t slaves[RTE_MAX_ETHPORTS]; char pmd_name[RTE_ETH_NAME_MAX_LEN]; - test_add_slave_to_bonded_device(); + TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), + "Failed to add member to bonding device"); current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id, slaves, RTE_MAX_ETHPORTS); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:52.784869629 +0000 +++ 0015-test-bonding-add-missing-check.patch 2023-11-08 19:23:51.777396376 +0000 @@ -1 +1 @@ -From 0ecafc2e44268e4d0626dcf0c811590466291f20 Mon Sep 17 00:00:00 2001 +From 894b6863a30800d67b9d19c7ffdbbbcfdefb6ef8 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4d715c4465..4d54706c21 100644 +index 4f810efb0a..886fe1680e 100644 @@ -24,2 +25,2 @@ -@@ -449,7 +449,8 @@ test_add_already_bonding_member_to_bonding_device(void) - uint16_t members[RTE_MAX_ETHPORTS]; +@@ -445,7 +445,8 @@ test_add_already_bonded_slave_to_bonded_device(void) + uint16_t slaves[RTE_MAX_ETHPORTS]; @@ -28,2 +29,2 @@ -- test_add_member_to_bonding_device(); -+ TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(), +- test_add_slave_to_bonded_device(); ++ TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), @@ -32,2 +33,2 @@ - current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id, - members, RTE_MAX_ETHPORTS); + current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id, + slaves, RTE_MAX_ETHPORTS);