From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5ECC432DA for ; Wed, 8 Nov 2023 20:26:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B166E42E30; Wed, 8 Nov 2023 20:26:45 +0100 (CET) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mails.dpdk.org (Postfix) with ESMTP id 2F7B840395 for ; Wed, 8 Nov 2023 20:26:45 +0100 (CET) Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2c518a1d83fso96456211fa.3 for ; Wed, 08 Nov 2023 11:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471604; x=1700076404; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VqUDIq6qmb4z0ukegPwE86yQsV6CalYAE0Zm5Udon4Q=; b=EpGy+/bUGChyCN3Rgmzp/xAczwiny3wk3BXUNf9sWaUY2iQeN+cdcn2Rl/gTCV2OCN aT1quU1Tabl7hBqFd8ZzOmSzdH0TmZBHPGY2nF1IevHaBzalX0MgJ5B/wrFblYE/LlL2 ecDM84A7s7ObFL8Is8jpOvjeHYIrfUkEZES/HKQXlMTu2UpOEx5BNShlNpCOOe/DJW1+ 4aOx5uHGVURUAaCu3DX0C+nxyhMf9qUdF3sfwfJSGX8zNKpGafqu/867NwL3L3Gsms9P EWxerdfd9ywTTJYhk81nJTuHoOVPoN9i5rYwP7EqELfIfDsQs655KHaACDukhjVfgcDL /8KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471604; x=1700076404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqUDIq6qmb4z0ukegPwE86yQsV6CalYAE0Zm5Udon4Q=; b=a0VO1Mpt7/YV6Vk3R75ozTQgKP112Z3INh5RE9g5rPjR0GFY5Eg0q1agPTPF7TPtBk ft6fwURkKlQBdSUqbKAGvkMgeti7RhBzLWSWsqlQLT1gRzhs/N3Sulr+H/ERfi73ljut 3+pWvKNfZ/wAWpIyyLkCNAK5C7CW2ooIB+BdZ5w59J08KHxhPVJ/SSV4r/icPYPTD70A 90sljz0I30QCM/d0KnOg81ksNBMcCrHmjvUxMHrlghD7HFouI27yTZkD7aDdrbCLhMzb IjCc+K18QtyEsiMqb5rh6MaNY78lABq2Xmpg+PB7JWxOB/Wko4UictaMWNRcNkpe6+hg bqFw== X-Gm-Message-State: AOJu0YzTcOri6jPulbie8B5oszLXYgOFWVEXrFZTze780LgaE2E++G+8 PzORTKr+ftJ1btQ3tQIP7SUm0eUdDjGrnA== X-Google-Smtp-Source: AGHT+IEJ5zgmiz13/WaDMPbZt57THM7HtEsAEUXfaptVqV88ZmTAbz5m998uK7WDtB/SOpwdWVON9A== X-Received: by 2002:a2e:b812:0:b0:2bf:7905:12c3 with SMTP id u18-20020a2eb812000000b002bf790512c3mr2202909ljo.40.1699471604422; Wed, 08 Nov 2023 11:26:44 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c021100b004053e9276easm19678955wmi.32.2023.11.08.11.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:26:44 -0800 (PST) From: luca.boccassi@gmail.com To: Jie Hai Cc: dpdk stable Subject: patch 'net/hns3: keep set/get algo key functions local' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:21 +0000 Message-Id: <20231108192535.922238-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0b6d1e010952f4a4c9ef24559b6ad7f19700becd Thanks. Luca Boccassi --- >From 0b6d1e010952f4a4c9ef24559b6ad7f19700becd Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Tue, 31 Oct 2023 20:23:58 +0800 Subject: [PATCH] net/hns3: keep set/get algo key functions local [ upstream commit 4d996f3b2a1dcce2fff59a0a9490c04480e4c805 ] The functions "hns3_rss_set_algo_key()" and "hns3_rss_get_algo_key()" are the inner interfaces to set hardware. Driver already had an API, "hns3_update_rss_algo_key()", to export and to update RSS algo or key. So above two innter interface don't export. Fixes: 7da415d27d88 ("net/hns3: use hardware config to report hash key") Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 4 ++-- drivers/net/hns3/hns3_rss.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index cb4a2bbede..cb1339d4da 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -283,7 +283,7 @@ static const struct { * rss_generic_config command function, opcode:0x0D01. * Used to set algorithm and hash key of RSS. */ -int +static int hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, const uint8_t *key, uint8_t key_len) { @@ -324,7 +324,7 @@ hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, return 0; } -int +static int hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo, uint8_t *key, uint8_t key_len) { diff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h index 151880f65a..20bf984d44 100644 --- a/drivers/net/hns3/hns3_rss.h +++ b/drivers/net/hns3/hns3_rss.h @@ -194,11 +194,7 @@ bool hns3_check_rss_types_valid(struct hns3_hw *hw, uint64_t types); int hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf); int hns3_set_rss_tuple_field(struct hns3_hw *hw, uint64_t tuple_fields); int hns3_get_rss_tuple_field(struct hns3_hw *hw, uint64_t *tuple_fields); -int hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, - const uint8_t *key, uint8_t key_len); int hns3_restore_filter(struct hns3_adapter *hns); -int hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo, - uint8_t *key, uint8_t key_len); uint64_t hns3_rss_calc_tuple_filed(uint64_t rss_hf); int hns3_update_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, uint8_t *key, uint8_t key_len); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:53.123264532 +0000 +++ 0023-net-hns3-keep-set-get-algo-key-functions-local.patch 2023-11-08 19:23:51.805396955 +0000 @@ -1 +1 @@ -From 4d996f3b2a1dcce2fff59a0a9490c04480e4c805 Mon Sep 17 00:00:00 2001 +From 0b6d1e010952f4a4c9ef24559b6ad7f19700becd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4d996f3b2a1dcce2fff59a0a9490c04480e4c805 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 6126512bd7..9bb8426256 100644 +index cb4a2bbede..cb1339d4da 100644 @@ -30 +31 @@ - hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, + hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, @@ -33 +34 @@ -@@ -324,7 +324,7 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, +@@ -324,7 +324,7 @@ hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, @@ -43 +44 @@ -index 415430a399..9d182a8025 100644 +index 151880f65a..20bf984d44 100644 @@ -46 +47 @@ -@@ -190,10 +190,6 @@ bool hns3_check_rss_types_valid(struct hns3_hw *hw, uint64_t types); +@@ -194,11 +194,7 @@ bool hns3_check_rss_types_valid(struct hns3_hw *hw, uint64_t types); @@ -50 +51 @@ --int hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, +-int hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, @@ -51,0 +53 @@ + int hns3_restore_filter(struct hns3_adapter *hns);