From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBB53432DA for ; Wed, 8 Nov 2023 20:26:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6322406A2; Wed, 8 Nov 2023 20:26:46 +0100 (CET) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mails.dpdk.org (Postfix) with ESMTP id 3F46540395 for ; Wed, 8 Nov 2023 20:26:46 +0100 (CET) Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c59a4dd14cso97733381fa.2 for ; Wed, 08 Nov 2023 11:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471606; x=1700076406; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JayhnIxui3NUTA64ZXtcGxFNoMycPnNe/Q/kDl2Dkn8=; b=LTCNkqg8EMMCUheyB2I6v8XJ8svXX+DEf1MaVP0FZ9RYsbfNTC25EWt4osBHcgeyDa SGnDWRMZH2o6cuFSyks6VCtc/XmNwIx6KFCJeaxlA5qHyYt47pKb0WQLbNImNmtG1sRk TvHzh3qonhEcIWyQH7UvG7KcBKAafmCOlH9b9VnNOpzse8d8KnosCUrCXS8hlFTntMhI N6EcznT+0rDYBU7ocgX+vePzGfV0dqlzDPfMm6Z1j+gr8yXVrv8ZA9SG9mW25RotlyKH 8rteNd6/R3CszCblxzN4XKN/2Hd+01jOZmP5xTC1h2ksAda56hue0hck+hr4l81anLB7 wJHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471606; x=1700076406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JayhnIxui3NUTA64ZXtcGxFNoMycPnNe/Q/kDl2Dkn8=; b=CU3OPy/uMafg+LcQYLND1E7jtVJCZeR3DVs0UMPeGrkb+e0388wNfYwHA9nDaZ39Xz y6ZJkpzgAHGOgt0cm6l0Im2tNbrLsXuOYRPAR3tvkHWaG5xB+mFOsaAcePpEujAYuzji CiRISuYdBHNREtu3nXY2ECJYbn6EH++1LkFV2kjR2Bf4+e3JmstzP9pDtsgNxZVt6Qpz Ojz5EYOIZe7eb7YXp5YwXHlHOoIfbv43XeNnVPZ8ntg5YIJDqHIAm0hi4SXRe/ofk3sb GIoDUisv7U9+hLPEUvFEzXSdL/X+710GJnoZs5jE6AZIlH07i7Umgg/tmYSX2yFHMDis 8pdg== X-Gm-Message-State: AOJu0Yz9M0HIVXpo2C/a1vy6NKEbe1qOLIW8Wm3ZzbYKooZbuofh/U4K fHep0SgF2lyfobEGYBTP4xs9T6NwE0KKDw== X-Google-Smtp-Source: AGHT+IFhCP694dUQ9ZSvksnRK5QeBZgrTtcx8kQLbjR8jbU7Ifudtx5t4fl0hUekzcxPJZfDkFqnwA== X-Received: by 2002:a05:651c:221b:b0:2bf:f365:c7b9 with SMTP id y27-20020a05651c221b00b002bff365c7b9mr3243597ljq.18.1699471605648; Wed, 08 Nov 2023 11:26:45 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id iv12-20020a05600c548c00b0040641a9d49bsm20368523wmb.17.2023.11.08.11.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:26:45 -0800 (PST) From: luca.boccassi@gmail.com To: Jie Hai Cc: dpdk stable Subject: patch 'net/hns3: fix uninitialized hash algo value' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:22 +0000 Message-Id: <20231108192535.922238-24-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/ca5911f4323102100937c0d513556483972a0cbe Thanks. Luca Boccassi --- >From ca5911f4323102100937c0d513556483972a0cbe Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Tue, 31 Oct 2023 20:23:59 +0800 Subject: [PATCH] net/hns3: fix uninitialized hash algo value [ upstream commit 177cf5c93f9ac86d8a2b817115ef1e979023414c ] This patch initializes "hash_algo" as zero to avoid using it uninitialized. Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index cb1339d4da..42b20c4c01 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -771,7 +771,7 @@ hns3_dev_rss_hash_conf_get(struct rte_eth_dev *dev, { struct hns3_adapter *hns = dev->data->dev_private; struct hns3_hw *hw = &hns->hw; - uint8_t hash_algo; + uint8_t hash_algo = 0; int ret; rte_spinlock_lock(&hw->lock); @@ -993,7 +993,7 @@ hns3_update_rss_algo_key(struct hns3_hw *hw, uint8_t hash_func, { uint8_t rss_key[HNS3_RSS_KEY_SIZE_MAX] = {0}; bool modify_key, modify_algo; - uint8_t hash_algo; + uint8_t hash_algo = 0; int ret; modify_key = (key != NULL && key_len > 0); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:53.164098109 +0000 +++ 0024-net-hns3-fix-uninitialized-hash-algo-value.patch 2023-11-08 19:23:51.805396955 +0000 @@ -1 +1 @@ -From 177cf5c93f9ac86d8a2b817115ef1e979023414c Mon Sep 17 00:00:00 2001 +From ca5911f4323102100937c0d513556483972a0cbe Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 177cf5c93f9ac86d8a2b817115ef1e979023414c ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 9bb8426256..eeeca71a5c 100644 +index cb1339d4da..42b20c4c01 100644