From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78499432DA for ; Wed, 8 Nov 2023 20:27:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71222406A2; Wed, 8 Nov 2023 20:27:02 +0100 (CET) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by mails.dpdk.org (Postfix) with ESMTP id 3940540395 for ; Wed, 8 Nov 2023 20:27:01 +0100 (CET) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2c5028e5b88so100028731fa.3 for ; Wed, 08 Nov 2023 11:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471621; x=1700076421; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQU1kwjrFCJNuMhPK6nFAxGkqpW50ar0k/INd16yd3c=; b=NWKoJuef9H8en5zSxrIvdLSx6JhF3Pd4zWnnHYDPZSL8wQXKcHrStw1Fl5Ezk/1kiY xczNS5uVhxhdWTvuSin05Jd9cq2yOCSbaoelMAzPECgqa6nE92BpNHqq8uZJtiQrSs89 3MlkrZiMjCV50qEoJJmELe4JM0e+/MQ9f5wMjdu6qMMArlO84r3Se1RiHY9el43N4Jdo D+1p3bIXRLZylFKxfQAX6Pap99abaZa9dfZhP0AZsp1wmYA95E+5AiNVQE28gh2HlKf6 dIvfw61JqYPbFAe1sYourkkm0XrTU9yUjue6rr28tjZeKuVI/U9Oiuji/ZPhRl4N5OGy WHxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471621; x=1700076421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQU1kwjrFCJNuMhPK6nFAxGkqpW50ar0k/INd16yd3c=; b=lS5Bq9LB/+3SbB7617ngVJ75u3HziNt7HwUQY7dfnNdgJ4hZvGZ5SqQERv+tjJpodT METWi+XffHHqmUAMByXog6FkpeTTu2dLWcvo0PlOEqnivUY0vtTLsIIkb5PXzYVRPeGd 1+/yQ8MFm4T4y99DmaZCWxpdEe2J2mruq/WLa9iGklQwYyfHgrNxh1PL1FUD+frqFY+0 g15v1ocdaGzWQz+6pooPoSLPymAkymBdqAjbXaTyH+RaamuvPeLUstmvdj71UArabxV7 5RiC/hrbAj7YChBclDY1BEh9vya0nyxZ36g+iyuJuXWpnnuzGKoYMIPf6RiCvYAM6CzO bUGQ== X-Gm-Message-State: AOJu0Yyq+u5GHf2K2Mc958VJgG5ZZt/5uuN2sER8C36oxc42RmmXsQYM opMA8O8es57P4juPbtShNYNHv0KVbXdLqw== X-Google-Smtp-Source: AGHT+IHDWpEMbKOFdFyntmrIQv4f+4U27MZ07lO/hofwwUckdhSEkEEerldM7G3J8qcBZyuptPUvfw== X-Received: by 2002:a05:6512:3194:b0:4fb:7c40:9f97 with SMTP id i20-20020a056512319400b004fb7c409f97mr2480439lfe.27.1699471620673; Wed, 08 Nov 2023 11:27:00 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id i11-20020a0560001acb00b0032dde679398sm5720041wry.8.2023.11.08.11.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:27:00 -0800 (PST) From: luca.boccassi@gmail.com To: Jie Hai Cc: Dongdong Liu , Reshma Pattan , Chengwen Feng , dpdk stable Subject: patch 'app/procinfo: adjust format of RSS info' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:26 +0000 Message-Id: <20231108192535.922238-28-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8056f3bea1ed30167c901c5f9de1594a5f7c54f6 Thanks. Luca Boccassi --- >From 8056f3bea1ed30167c901c5f9de1594a5f7c54f6 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Thu, 2 Nov 2023 16:20:17 +0800 Subject: [PATCH] app/procinfo: adjust format of RSS info [ upstream commit 66d4bacc39fb765051594669c33aab4f5d0f9d6c ] This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ 25 3d 43 a3 8f b0 d0 ca 2b cb ae 7b 30 b4 77 cb 2d \ a3 80 30 f2 c 6a 42 b7 3b be ac 1 fa -- hf 0x0 and after: - RSS info -- key len : 40 -- key (hex) : 6d5a56da255b0ec24167253d43a38fb0d0c \ a2bcbae7b30b477cb2da38030f20c6a42b73bbeac01fa -- hash function : 0x0 Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan Acked-by: Chengwen Feng --- app/proc-info/main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 247d8b256c..b50ee6501f 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -853,12 +853,13 @@ show_port(void) rss_conf.rss_key_len = dev_info.hash_key_size; ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf); if (ret == 0) { - printf(" - RSS\n"); - printf("\t -- RSS len %u key (hex):", + printf(" - RSS info\n"); + printf("\t -- key len : %u\n", rss_conf.rss_key_len); + printf("\t -- key (hex) : "); for (k = 0; k < rss_conf.rss_key_len; k++) - printf(" %x", rss_conf.rss_key[k]); - printf("\t -- hf 0x%"PRIx64"\n", + printf("%02x", rss_conf.rss_key[k]); + printf("\n\t -- hash function : 0x%"PRIx64"\n", rss_conf.rss_hf); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:53.329709588 +0000 +++ 0028-app-procinfo-adjust-format-of-RSS-info.patch 2023-11-08 19:23:51.813397120 +0000 @@ -1 +1 @@ -From 66d4bacc39fb765051594669c33aab4f5d0f9d6c Mon Sep 17 00:00:00 2001 +From 8056f3bea1ed30167c901c5f9de1594a5f7c54f6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 66d4bacc39fb765051594669c33aab4f5d0f9d6c ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 3a441ba075..4c577fa417 100644 +index 247d8b256c..b50ee6501f 100644 @@ -37 +38 @@ -@@ -1176,12 +1176,13 @@ show_port(void) +@@ -853,12 +853,13 @@ show_port(void)