From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CFD5432DA for ; Wed, 8 Nov 2023 20:27:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5723B42E3A; Wed, 8 Nov 2023 20:27:18 +0100 (CET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mails.dpdk.org (Postfix) with ESMTP id 5608C42E41 for ; Wed, 8 Nov 2023 20:27:17 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-408382da7f0so26045e9.0 for ; Wed, 08 Nov 2023 11:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699471637; x=1700076437; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NkVpGLUbX00HKeyNreKTDAYCXqJYOtryBgljzNu1feg=; b=MCA27QVObbGJyt+2GaqbFWWukDEIX3D5tZE4QVTb4ytLGmYmqW62zSVrDwRWk+kgDK OOVE5zo0SAIYtc6AFmyQ2wEWGZyYZ2v0WMcZQQfIKYsqpaik+PcaRNK10x1w4QjskYpc ub6YRf1lEEVrkLYw/flUcbhePKYikmKrsKa5d+MnLJuQLQPysPyRYGfY08mh7aOz1V0i ckKtEhTDoe0XpF8OndMKv5B1k5HiUd8hYRFM1LqvZioC2N81CZRhZtfYWxIbyfosr5Sw aSnX881grGYhrY+w7qorhXOX7EJsGhAnEiWCy0fO6TANZ4yhLziAMJlJNICOI4EXUUnC 5XNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471637; x=1700076437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NkVpGLUbX00HKeyNreKTDAYCXqJYOtryBgljzNu1feg=; b=E60V9uftpfOLX0jxI2K66HwJys48fo0c1rTWkjkInCy/zjtbkE5UHoL/VH1yhwHYys pre4XY/AhYPbbTEDz0yApx7XMdg/Tg8NchcVYR69febJ6PgrNPeBhOeAj3vrLGpPJ/HQ 7at64HGXAPP/3wEy4qdCz7PYfXskB0BjOYvFPO4n6J8dXCukrMMR+hLtVmCe00IPvAEO MSDLJLh3XnlQobewhNDsSk2hI216g5ojNypoohzq/aKkR3D3Cw0PpkU+fY5QAreXt8RC ZglimAR6I7cSFmJ/bM9sOJxLVZqkPJbF1RPILxHK9APcCafvi3z8QpsDx0Gn5cuXT5zc XLQQ== X-Gm-Message-State: AOJu0YxlxenBzt4bLQqcDWbO4rOCdn1RgmRK5bzMftIzSLP/K/dFGbMB Hovg11+l56RJwNWHHcVHV2Birfz4U8VhSQ== X-Google-Smtp-Source: AGHT+IHizUAHI+sregPQ/tx1O3c/dudqLZyncc6WYiiKi3RbMFeMy7PhtS6cy9Ym7YTPHtTLD/fzpQ== X-Received: by 2002:a05:600c:46ca:b0:408:2f50:f228 with SMTP id q10-20020a05600c46ca00b004082f50f228mr2579649wmo.41.1699471636832; Wed, 08 Nov 2023 11:27:16 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id az34-20020a05600c602200b004076f522058sm20618562wmb.0.2023.11.08.11.27.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:27:16 -0800 (PST) From: luca.boccassi@gmail.com To: Timothy Miskell Cc: Jonathan Tsai , Qi Zhang , dpdk stable Subject: patch 'net/ice: fix L1 check interval' has been queued to stable release 20.11.10 Date: Wed, 8 Nov 2023 19:25:31 +0000 Message-Id: <20231108192535.922238-33-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231108192535.922238-1-luca.boccassi@gmail.com> References: <20231018235930.3144-41-luca.boccassi@gmail.com> <20231108192535.922238-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/10/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/e0f81abc3c873ff7c9d442f7a9a8a0889973c92e Thanks. Luca Boccassi --- >From e0f81abc3c873ff7c9d442f7a9a8a0889973c92e Mon Sep 17 00:00:00 2001 From: Timothy Miskell Date: Thu, 19 Oct 2023 17:26:10 +0000 Subject: [PATCH] net/ice: fix L1 check interval [ upstream commit ff628a22c51f9cc5f69c715005a42456a2aec4f6 ] For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event may be longer than 1 second. Fixes: cf911d90e366 ("net/ice: support link update") Signed-off-by: Timothy Miskell Tested-by: Jonathan Tsai Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 7af6548afc..017059fc87 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3783,8 +3783,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, static int ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) { -#define CHECK_INTERVAL 100 /* 100ms */ -#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ +#define CHECK_INTERVAL 50 /* 50ms */ +#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */ struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private); struct ice_link_status link_status; struct rte_eth_link link, old; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-08 19:23:53.539469801 +0000 +++ 0033-net-ice-fix-L1-check-interval.patch 2023-11-08 19:23:51.825397369 +0000 @@ -1 +1 @@ -From ff628a22c51f9cc5f69c715005a42456a2aec4f6 Mon Sep 17 00:00:00 2001 +From e0f81abc3c873ff7c9d442f7a9a8a0889973c92e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff628a22c51f9cc5f69c715005a42456a2aec4f6 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -19 +19,0 @@ - .mailmap | 2 ++ @@ -21 +21 @@ - 2 files changed, 4 insertions(+), 2 deletions(-) + 1 file changed, 2 insertions(+), 2 deletions(-) @@ -23,20 +22,0 @@ -diff --git a/.mailmap b/.mailmap -index c0ab6d090b..d91775daf1 100644 ---- a/.mailmap -+++ b/.mailmap -@@ -676,6 +676,7 @@ John Romein - John W. Linville - Jonas Pfefferle - Jonathan Erb -+Jonathan Tsai - Jon DeVree - Jon Loeliger - Joongi Kim -@@ -1417,6 +1418,7 @@ Tianli Lai - Tianyu Li - Timmons C. Player - Timothy McDaniel -+Timothy Miskell - Timothy Redaelli - Tim Shearer - Ting Xu @@ -44 +24 @@ -index 305077e74e..6ef06b9926 100644 +index 7af6548afc..017059fc87 100644 @@ -47 +27 @@ -@@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev, +@@ -3783,8 +3783,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,