From: Chaoyong He <chaoyong.he@corigine.com>
To: stable@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH 20.11] net/nfp: fix reconfigure logic in PF initialization
Date: Thu, 9 Nov 2023 10:33:45 +0800 [thread overview]
Message-ID: <20231109023345.3771714-1-chaoyong.he@corigine.com> (raw)
[ upstream commit 1e80c07472aeed5669c79c0430b8aeece5129a20 ]
There exists exit point between the reconfigure logic and the store
logic of the PF initialization, this may lead one situation that value
in the config bar is not same with the value stored in the data
structure.
Fix this by move up the store statement.
Fixes: b812daadad0d ("nfp: add Rx and Tx")
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 4b890e3375..102d8f2938 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -746,6 +746,8 @@ nfp_net_start(struct rte_eth_dev *dev)
if (nfp_net_reconfig(hw, new_ctrl, update) < 0)
return -EIO;
+ hw->ctrl = new_ctrl;
+
/*
* Allocating rte mbufs for configured rx queues.
* This requires queues being enabled before
@@ -764,8 +766,6 @@ nfp_net_start(struct rte_eth_dev *dev)
hw->pf_port_idx, 1);
}
- hw->ctrl = new_ctrl;
-
return 0;
error:
--
2.39.1
next reply other threads:[~2023-11-09 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 2:33 Chaoyong He [this message]
2023-11-09 11:34 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109023345.3771714-1-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).