From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC39D432DD for ; Thu, 9 Nov 2023 03:34:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4B184021F; Thu, 9 Nov 2023 03:34:11 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 97EC84013F for ; Thu, 9 Nov 2023 03:34:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h+Fnfwara7qw4z6zVYpzbURa01MR2qWDXDqMVvkJKyIoqWQ5dDb82FgSEimk1Gd2mIo7oNQyoQ3timTpDZdpi3+ngecRLAeux3yPRgII1GzKlkvvkQXT/kIwDL5TvHHlAJQG0BHcJcpvSe4msIq0dtsTtfHL4WhxxbX8CBF3hQ8pdLt9Zs8f6yyfcdxOVus49YdRfJWrgFibls34RKbrna3huly4HgFb7m2lzbBvncZptXqQVTHPzzED6okJRsiKybYKiONE2EKRkV/c0qvFy+OLIkLxJf8hLxbT4Y/vLOB5iKN0OPgImkyGwZT1IJZtUfMW1BGMxQN4Qk38aUMSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=msMB/74SwSNdtEDcTs8azB+esk4mftfzdTVSHawqsxk=; b=cqwhTX1CHUYbeHIaiu9S0/b0K7FpPlekzWRs+kB3ZgPqmwWVxWvMHpaDyOOD09W7jpF3SFzfs437M86Pl8njWx5lOZy8wdxS+cuwyY7j2ry5DywQaAZalTnqdM+hrTpsL2ZqvxbJPBA6OYHp7ub83xbb5qu6tO7jkjoZj91FOdlO8EWd4iXBm9pCtLCNa53zlw7GvgBBTtvydl+LRPxWyPzql7irs183dV8x4Now69IJQ6gG5QDpHzYkhlueH9QTnAyrtvbeIpd9wFRuItHGRShKGQKazCJznrRikyekadIbUxiEsXxeox09Q93fKt0g7s4BmHxCRpcmumF3xKDCOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msMB/74SwSNdtEDcTs8azB+esk4mftfzdTVSHawqsxk=; b=LJOEalyZvSeOya5stD8xdmp1tleoqoLk7QuhpwihyfwD+Zs7wb/6AbV/sSNFHt6WVCRLlPkyXD3A+t06V9BIvFnLxYH8J7+5RygQJMFPbr9q5yPPB39LIU6kb2Q8QoQYhCjz0mwE09km4HTIf8ZeUd9qUlBQgCIXTRVBJHm2fU4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5791.namprd13.prod.outlook.com (2603:10b6:806:21a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Thu, 9 Nov 2023 02:34:08 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6954.025; Thu, 9 Nov 2023 02:34:08 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He Subject: [PATCH 20.11] net/nfp: fix reconfigure logic in PF initialization Date: Thu, 9 Nov 2023 10:33:45 +0800 Message-Id: <20231109023345.3771714-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0078.namprd05.prod.outlook.com (2603:10b6:a03:332::23) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5791:EE_ X-MS-Office365-Filtering-Correlation-Id: 38392a26-1fb7-44d3-3837-08dbe0cc596b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B606Sneq/nJJc0E6MElRmsKeNj4hIFDKY7cgKvTJjHXgZo2cwMxCrfdL/vL/cCBs0xXGlvnOhEMJ7MXvi1vqt0FjTQiYo1Tb98K4ld0XnTUvmEsnpY7/qk7GWy26LQR8hTByIGfceBhg7hXY2pEU3T+NOEo1WkIxejNW8t4N0EnBdyw5zEhD6FjvJm6BwuSkHZZ6H80GEiQ+JmMi75tQF26NsnXnB8OGCzBIzpzNS310LPpZhqZw0+wevR3/7+2xZ7HtHJsDdjlYCtOhWRZWASKMn6Gw/zCXZLMiYyAiwfKXD40iNh6CI3abXFBcmjRDmsTBLB9Z8X3HmknBjchnIfpFnXomnoNI2K9AhXGCUmrOyWp8m2bUhljEUgKfGKi/hLHwlC/PEjM1Co3LNH8zV683rD66drQxrtDl9X0CGvDwhrjHhZHJloq/5rqAyu2YxJ9YWOaFf0CW12DolHAZUhd99rXitVOvdw1jrZE85IbBI9W0uq/45fKPytxkQe1Ll4eJauf7BHGIQlnWzCKNe/ESJWB7VXsy/2MoCwW3/JrlEMCCvVkTSLNpqS/javqwcpVAAzsGQ32/kT2t7Dl9SbOQLeInHv7cA+NeQbadkZLVMlH2j8uNfc7PCm+eKf9uBesTmVvAsVOEcVwPvgV7IzB58Z8WjJscRHAQgFmK2p8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39840400004)(376002)(136003)(366004)(396003)(346002)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(478600001)(52116002)(5660300002)(4326008)(44832011)(2616005)(6486002)(6506007)(6666004)(8936002)(2906002)(83380400001)(8676002)(107886003)(1076003)(66476007)(26005)(66946007)(66556008)(6916009)(316002)(86362001)(41300700001)(38100700002)(6512007)(38350700005)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WGafgGWjuvKSwYNJLkocgiC7WnGvCeMI2thgG2XuaIJ+Ddr1usRzdcg3PBOH?= =?us-ascii?Q?7LRV6uMkNGRpK8giLvfY54D/vhHDTTVe/UkBv/KRv76UTHuuKxqFJKazRxJA?= =?us-ascii?Q?fituR3A7C2h5B1V5w6oTM7ZOjBtheLoGd8AhQt/EcOfqPUpPh5rfSBdmu0i3?= =?us-ascii?Q?hiTeFS/2LxcU5Ka4zC7pOMPzMfdhm87g5fgrzNGirfMXOKq/rnH0EekaiORM?= =?us-ascii?Q?4D6M11D1YZ11nNZslzSrDnZ9krU+zuD1o9JrPFx3MiWCinrDuoTGdpAyPbGF?= =?us-ascii?Q?f2HjsIIUnR6wQdPywYHDIAjTJcmvYdHIfYXkrqayzKr9UgkSVvNiFi65Wa9u?= =?us-ascii?Q?HpOo7lu5gEdky0yVJYxiYOhCJKNj7mSBF3tTkqr6DoLxHoYDAFsLC3Pd5Pvp?= =?us-ascii?Q?/SMgdCefTtfd0U/mhzLnlF3AD/vh+FqB34oDOVoYjgCEpWK9yEhIh/kWvqv+?= =?us-ascii?Q?cAPY16deViJluOErOrtOlLtnHQD33/QK4FdnrNW6oaV7RosWy5ntpgXFXnpV?= =?us-ascii?Q?m8W4w21eYNiyj4S0ym8Xno7KuiFcmHyaivLJe2ANGVP8DRqvBTca4Yn/41wm?= =?us-ascii?Q?2okbc0HPQYgTIvC9UMFaO9avnBQn3/AGtDj/G5TSBjY13PctrJfm8tPwPKdV?= =?us-ascii?Q?ewugUj+hyDod60PJmoh/fz0RwVkaRaV8EsIf5hNg9jtIMfoZzAt4VDcX/AwK?= =?us-ascii?Q?0TLpTFqCPXjHPLlVL8LvFxm6Vb+c/4UO+loC98SRH403gQbXXkC1m89HTnPa?= =?us-ascii?Q?7lRjy4bM+OBFTNjgT8xL/vdVwQnrX/mhcGCsoDvDmYuc7COA8kJ6QYF5rp1P?= =?us-ascii?Q?4zt2yF1ozDlomVHJJOakT4eTHacmRritghZANJWWEXFbWqPjlU2X1UsVozrZ?= =?us-ascii?Q?WZFD7Lz+TtCryO+Xoyc2adEiCioGKrzbZwKjbFEf9uPEOj5b6VnxqAMQFfn0?= =?us-ascii?Q?LUQMdzbC+fd3n/hBMDqTpbOoO0CAH9lbC3J8+la+A89BbzYA8no9iQ8Z+bog?= =?us-ascii?Q?0zDV/hI2RJTruG7xSyPOlhUd/qeK2U8OURgGmOluJeASxSMI+6ePC7bsZSeO?= =?us-ascii?Q?26MkVe8O/vvb6yB5MxjfuA4XGPUI1htVQFxtjgrtYONU3imdAKPwp+WscLNi?= =?us-ascii?Q?K5p95xHTIc2AV4QmaxkX7H+Z3GYAhuoGnP7ZKFGs8h53u8rIcvpfHlup+8yo?= =?us-ascii?Q?zlv/67ZHQ52f6vs1cOYtJqICx1G+KwGC+TXfCJm1AoDlrfjoa+oFGh/K/D30?= =?us-ascii?Q?bjpmU7+MkjOXtsna6vO6iJi6EXI8s+o8z/sUYmXzf2x5mwFAoh+H7eTlfGv1?= =?us-ascii?Q?cL7JQ+EGn7ZfKlr/DYpF3eWgBsVl1HnzAfCBaMjUYfYTcJ/nEvdWh0m4ufWF?= =?us-ascii?Q?Ji9uA8Nf1g+etfi0C1TakWhG1L8bhvlhwqOpw2ldbhUL4TKYu5zUkmSYfxOf?= =?us-ascii?Q?ZNlUhO7PXp5SCYW2jTn/pMHGN+n8Jr9ceTQiXfexvrp5yZHZeuHcPIFd+Fsm?= =?us-ascii?Q?KZDoCgmdx4KZlW6v15P8tdAoqeo1IHddm1rT8+nTf4SjUQlNAq7Dv/c7+c0j?= =?us-ascii?Q?WYT3yYOEOzhISJa93UhNQYWxcuMDMJEUTPtf+8d4FZaw+MddyHjZrj9adp2U?= =?us-ascii?Q?YQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38392a26-1fb7-44d3-3837-08dbe0cc596b X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2023 02:34:08.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 94ZJXrrH7hzmFMo6F7L4pQLsmQz28eYwuozGkU0l15am9dHJAYhKauojoaJSIGf8nXl+ZrAgKuIERIAji+4IqzwVeV//k9myS3sQzApJtrA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5791 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 1e80c07472aeed5669c79c0430b8aeece5129a20 ] There exists exit point between the reconfigure logic and the store logic of the PF initialization, this may lead one situation that value in the config bar is not same with the value stored in the data structure. Fix this by move up the store statement. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 4b890e3375..102d8f2938 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -746,6 +746,8 @@ nfp_net_start(struct rte_eth_dev *dev) if (nfp_net_reconfig(hw, new_ctrl, update) < 0) return -EIO; + hw->ctrl = new_ctrl; + /* * Allocating rte mbufs for configured rx queues. * This requires queues being enabled before @@ -764,8 +766,6 @@ nfp_net_start(struct rte_eth_dev *dev) hw->pf_port_idx, 1); } - hw->ctrl = new_ctrl; - return 0; error: -- 2.39.1