From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DA0B4332F for ; Tue, 14 Nov 2023 20:19:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75998402EE; Tue, 14 Nov 2023 20:19:15 +0100 (CET) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mails.dpdk.org (Postfix) with ESMTP id 376C9402B3; Tue, 14 Nov 2023 20:19:13 +0100 (CET) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2c5056059e0so86403931fa.3; Tue, 14 Nov 2023 11:19:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699989552; x=1700594352; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HaIxsLbEJVboWDlPE/3YKM7k3xTsN9m8CqTU0oMVtTM=; b=OxiH+GQcK2VKe3EnIaHxin9gkFAdyrnfFl5giz7Pl3dA4yNLzNR16Ysb0l85PH51Fk yo65veF/qtOFgaswdn2Fd1bcHvtkr+Kt0pHLFwVPjLXdYyDnkt8YfQRf6Oj7Qj8eRQOm 0+YBhd8T0QFjidYoPq0F29iG3RSrfAIQLQjYTHVhEFkC9PNoWyrQQAyROdgCfuBuBldA HBgYW+tkfj6b/+OLEu4xiAYMLKXdpSwljmPrrqcMVFDqKpTbb30WZcQdFOnURniWJ9yi X9tbj8w06iP6SAU2qnyNHUSoGaOkWIIbs/TXtmFbQh6obvrRphvLPm6Myzu71NagrpIT SLfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699989552; x=1700594352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HaIxsLbEJVboWDlPE/3YKM7k3xTsN9m8CqTU0oMVtTM=; b=HmN7FxjDxo6LPUzcsYZEh9O6ZmlcU4nAr054vMtZJrgBmQ8YL8UKzSiyxqB4Nl60hJ nq2UL2K11BQVH91KDy6D22WADI9t/VAm6/F36ttwnxrVGN/1exoQlXqDMEWW3yvpg0xA oSgtIBkHg2/QHwpGxrPsVhHR/g18/+bxs21IW728wOJUiVkadiVuD9q9J1amf3qPiiO5 ogB/mgvYxHsrkbqQbnfWm9f4aG8umjtCytQ3UaR6UyceqkCTL9b7mQf88ekgCTrt6dOz RgCwPKiPJtipWTxxLMEuItr1tVtT7Is+HxEFi1egp+6X3rWhQrcsFC0eX0HJpDeSTpMj /pOQ== X-Gm-Message-State: AOJu0YxnlQXVZr6o/NtHTX5BKfSURGaNdJSTy/Uc3d8haqetjMdC5dTC 8+BsjkjG3P/cuPLiw3oUL9I= X-Google-Smtp-Source: AGHT+IGQ7xYZRN5f6z5WC0zdF+Qd+NOwg/c/DtdM/AnGnGmcPinmuqrzcSBMNCdCxUEeQmsBdH8G6A== X-Received: by 2002:a05:651c:2106:b0:2c8:3285:54d1 with SMTP id a6-20020a05651c210600b002c8328554d1mr3098446ljq.19.1699989551847; Tue, 14 Nov 2023 11:19:11 -0800 (PST) Received: from sovereign (broadband-109-173-110-33.ip.moscow.rt.ru. [109.173.110.33]) by smtp.gmail.com with ESMTPSA id k28-20020a05651c10bc00b002c023d3dadesm1454434ljn.113.2023.11.14.11.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 11:19:11 -0800 (PST) Date: Tue, 14 Nov 2023 22:19:09 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: "Etelson, Gregory" , dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix memory management macros usage Message-ID: <20231114221909.623a18d6@sovereign> In-Reply-To: <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20231114170529.176665-1-getelson@nvidia.com> <20231114174637.GC23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 2023-11-14 10:22 (UTC-0800), Tyler Retzlaff: > On Tue, Nov 14, 2023 at 08:16:22PM +0200, Etelson, Gregory wrote: > > Hello Tyler, > > > > > > > >since we are duplicating something that comes from something else that > > >has been duplicated out of windows WDK here it might be a reasonable > > >safety check to verify that our duplicated values match our > > >expectations? > > > > MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, > > MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER > > are defined in Win32 API. > > > > DPDK has no expectations about these values. DPDK needs them as > > parameters to the VirtualX function calls. > > It looks like the macros were added to EAL because they were missing > > in mingw. > > > > Once compiler environment was fixed, the proper order was restored. > > yes, there is a lag between when names appear in the actual WDK and when > mingw takes a the snapshot of the headers. so long as the copy they take > is only from released WDK versions that align with an OS we shouldn't > expect the values to change but if the duplicated names in dpdk were > based upon an insider (preview version of SDK) value that later got changed > there could be a misalignment. unlikely but possible. I think we should trust the toolchain unless there is an known bug, i.e. the patch is good as-is.