From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE5E443337 for ; Wed, 15 Nov 2023 12:45:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7A6440294; Wed, 15 Nov 2023 12:45:39 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id C6E9040285 for ; Wed, 15 Nov 2023 12:45:37 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-32f78dcf036so453794f8f.0 for ; Wed, 15 Nov 2023 03:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700048737; x=1700653537; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uxmgGhjdMk3UrUlCusfgBlYE0VfYVCDoNmmpkaxaeGY=; b=mcqhNNl46wXQtNtOOPEZeqRbRxDeaEgl9H2+1xG3GQK6lqH8ZPOxJkKj5IXHfILwhy Ve2sq4mYE6Gss6t5HpsjuHThX+AQtJQEyL1MPfZLduUwc3+f3F0FlU22JL2geI0afqJQ cf9j17frQbfMBNZw0BRTYFH/3vS0N7qgUqj6w7JZDahWY09S2I5Mg2CmUU4lePP2WPWR 5XvhozJ2AkCt6n9r8lcGE93odxFq0aLQylvxsTfpIexn9nWQzkzmC09Eby8ux9FIvIiZ y2S54FYIxG50QsikrBGmTX0MB1wGZBq6cxTuQHsk8PqaFcV/8GJcy+3fipXgc6WX/7IM 7LCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700048737; x=1700653537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uxmgGhjdMk3UrUlCusfgBlYE0VfYVCDoNmmpkaxaeGY=; b=lN378ENEUOf5+hWxvTRwfaLkZ5pIChr6jG102WdfS5j/KznnSBqhV3HLCi7FskCp5S HsDv69O/UVHurJ903pV5jsIwhyXYDcflqEFqTC6pXSpDMh9qK1Hn9S9ktBt7JNgvgZaG Oe+ykODxCWYt9uZgkpzij6XdVKt818i5qp/chiPgkbVCFnfM9G/PICvx4QZkxUPwRpuf EAdrsAI590XbiFwKcOXb6ThTkxA0HQTnPqwp/XLzWIcS98YN699WNzJqw/iuJvq/TFpF JwqZVW5oBd4+bO4liMhVHaLmo1GkdiwKrFfxGwDWEbMjuZZg8XYktw6mM1r9SgdQau9i VpAQ== X-Gm-Message-State: AOJu0Yx4nsj6gHNKx8Ka/IJ7okoOjRVGNVVI4VJexAry0Fb1cKngsAeG vGfrplpkq3LfqPK/TOVvnJE= X-Google-Smtp-Source: AGHT+IFJHcklrkYpYPGNUBnAYT11A43cq4+jsiJeFfpsJu5DamHvCZ/gYUtdumlkkK7V/N6z9GWBsw== X-Received: by 2002:a5d:5a0d:0:b0:32d:a366:7073 with SMTP id bq13-20020a5d5a0d000000b0032da3667073mr5129203wrb.14.1700048737226; Wed, 15 Nov 2023 03:45:37 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id g26-20020adfa49a000000b0030647449730sm10468641wrb.74.2023.11.15.03.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 03:45:36 -0800 (PST) From: luca.boccassi@gmail.com To: Huisong Li Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: remove useless check in TSO command' has been queued to stable release 20.11.10 Date: Wed, 15 Nov 2023 11:45:05 +0000 Message-Id: <20231115114515.2355140-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231115114515.2355140-1-luca.boccassi@gmail.com> References: <20231108192535.922238-37-luca.boccassi@gmail.com> <20231115114515.2355140-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/386140bb85f9038445185f7e047e63eae1736ddd Thanks. Luca Boccassi --- >From 386140bb85f9038445185f7e047e63eae1736ddd Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Tue, 7 Nov 2023 12:11:16 +0800 Subject: [PATCH] app/testpmd: remove useless check in TSO command [ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] Testpmd has added the check of TSO offload capability of port, please see the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") So the code following the check code memtioned above to display warning when port doesn't support TSO offload doesn't access to forever. Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") Signed-off-by: Huisong Li Acked-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a1371dba0c..16b700252f 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -4881,18 +4881,6 @@ cmd_tso_set_parsed(void *parsed_result, ports[res->port_id].tso_segsz); } cmd_config_queue_tx_offloads(&ports[res->port_id]); - - /* display warnings if configuration is not supported by the NIC */ - ret = eth_dev_info_get_print_err(res->port_id, &dev_info); - if (ret != 0) - return; - - if ((ports[res->port_id].tso_segsz != 0) && - (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0) { - printf("Warning: TSO enabled but not " - "supported by port %d\n", res->port_id); - } - cmd_reconfig_device_queue(res->port_id, 1, 1); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-15 11:44:13.849934310 +0000 +++ 0006-app-testpmd-remove-useless-check-in-TSO-command.patch 2023-11-15 11:44:13.550387124 +0000 @@ -1 +1 @@ -From 773397f6f4b5e325e786835343bacbc454d1e5f0 Mon Sep 17 00:00:00 2001 +From 386140bb85f9038445185f7e047e63eae1736ddd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -18,2 +19,2 @@ - app/test-pmd/cmdline.c | 13 ------------- - 1 file changed, 13 deletions(-) + app/test-pmd/cmdline.c | 12 ------------ + 1 file changed, 12 deletions(-) @@ -22 +23 @@ -index 912bf3355c..1c57e07d41 100644 +index a1371dba0c..16b700252f 100644 @@ -25 +26 @@ -@@ -4967,19 +4967,6 @@ cmd_tso_set_parsed(void *parsed_result, +@@ -4881,18 +4881,6 @@ cmd_tso_set_parsed(void *parsed_result, @@ -36,4 +37,3 @@ -- (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) { -- fprintf(stderr, -- "Warning: TSO enabled but not supported by port %d\n", -- res->port_id); +- (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0) { +- printf("Warning: TSO enabled but not " +- "supported by port %d\n", res->port_id);