From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFD8E43345 for ; Thu, 16 Nov 2023 14:24:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B936A40A6C; Thu, 16 Nov 2023 14:24:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 89A02402C6 for ; Thu, 16 Nov 2023 14:24:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=trS36+9gdzXtppz0h8/nBlxDRAgH1gOZNXDp8LtN25c=; b=dKyfW4fLAq4XCtzpredvyvN4mEtRtdleVn1H6GzNvVzHfMpj9+cTyb/lf1JOaJYQu/yNLT 5CBJYsahokXw5/cmxv9yJHZU10v3pepnK4r3P4dluxlMwma1m7k71YNEnkSL86F3rhtXSz Mhn8gn7MnfSWBRJnehv2reX5Uhg4Gs8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-zPBl7DhiMqaYJRHoZgobjw-1; Thu, 16 Nov 2023 08:24:21 -0500 X-MC-Unique: zPBl7DhiMqaYJRHoZgobjw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 525A3887181; Thu, 16 Nov 2023 13:24:21 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FD172166B27; Thu, 16 Nov 2023 13:24:19 +0000 (UTC) From: Kevin Traynor To: Long Wu Cc: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: remove unreachable statement' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:22:59 +0000 Message-ID: <20231116132348.557257-17-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1c29c2395397c2d3dff851c20b6265b897a50bb2 Thanks. Kevin --- >From 1c29c2395397c2d3dff851c20b6265b897a50bb2 Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:02 +0800 Subject: [PATCH] test/bonding: remove unreachable statement [ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] CI found that execution cannot reach the expression "else" inside this statement. Coverity issue: 403097 Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding_mode4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 351129de2f..6eb2620ffd 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -644,6 +644,5 @@ bond_handshake(void) TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); - /* If flags doesn't match - report failure */ - return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; + return TEST_SUCCESS; } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:52.983395564 +0000 +++ 0017-test-bonding-remove-unreachable-statement.patch 2023-11-16 13:21:52.432946322 +0000 @@ -1 +1 @@ -From 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 Mon Sep 17 00:00:00 2001 +From 1c29c2395397c2d3dff851c20b6265b897a50bb2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 645fc1e0d4..ff13dbed93 100644 +index 351129de2f..6eb2620ffd 100644 @@ -25,2 +26,2 @@ -@@ -642,6 +642,5 @@ bond_handshake(void) - TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n"); +@@ -644,6 +644,5 @@ bond_handshake(void) + TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); @@ -29 +30 @@ -- return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED; +- return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;