From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB9D643345 for ; Thu, 16 Nov 2023 14:24:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4C74402DD; Thu, 16 Nov 2023 14:24:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 94E5D402C6 for ; Thu, 16 Nov 2023 14:24:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CzNluJV6SpwU/WFFcHBJ4Ha0km0m73Aauq+SpELY7uE=; b=GqE2/G2ECpP/cX71A64tBSyK1+4LFA19xJpbmwf/3PCU57w0hFqVfSjl4U9msEp/+FxZgk hJ99A4NqtOjteWou/e9Sxl/CXoLgzW/1gxlfeoJ7ln3EefFwaAXyfcAQ6PAf7tMSCRVdgP uT4ZhIYyR8VjzDEJ1GkxPwCzknCZRog= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-QDjUO2UFOim_ibdI6uHBLw-1; Thu, 16 Nov 2023 08:24:23 -0500 X-MC-Unique: QDjUO2UFOim_ibdI6uHBLw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BCA20811E7B; Thu, 16 Nov 2023 13:24:22 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9ACC92166B27; Thu, 16 Nov 2023 13:24:21 +0000 (UTC) From: Kevin Traynor To: Long Wu Cc: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: add missing check' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:23:00 +0000 Message-ID: <20231116132348.557257-18-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/fe5d3a4119ce95d3ec05f91357ea10de6bf45164 Thanks. Kevin --- >From fe5d3a4119ce95d3ec05f91357ea10de6bf45164 Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:04 +0800 Subject: [PATCH] test/bonding: add missing check [ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] CI found the function without checking return value in this place. Coverity issue: 403101 Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index f64f2ddb01..0d5cfd43c4 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -449,5 +449,6 @@ test_add_already_bonded_slave_to_bonded_device(void) char pmd_name[RTE_ETH_NAME_MAX_LEN]; - test_add_slave_to_bonded_device(); + TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), + "Failed to add slave to bonded device"); current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id, -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:53.004812910 +0000 +++ 0018-test-bonding-add-missing-check.patch 2023-11-16 13:21:52.436946334 +0000 @@ -1 +1 @@ -From 0ecafc2e44268e4d0626dcf0c811590466291f20 Mon Sep 17 00:00:00 2001 +From fe5d3a4119ce95d3ec05f91357ea10de6bf45164 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4d715c4465..4d54706c21 100644 +index f64f2ddb01..0d5cfd43c4 100644 @@ -24 +25 @@ -@@ -450,5 +450,6 @@ test_add_already_bonding_member_to_bonding_device(void) +@@ -449,5 +449,6 @@ test_add_already_bonded_slave_to_bonded_device(void) @@ -27,3 +28,3 @@ -- test_add_member_to_bonding_device(); -+ TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(), -+ "Failed to add member to bonding device"); +- test_add_slave_to_bonded_device(); ++ TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), ++ "Failed to add slave to bonded device"); @@ -31 +32 @@ - current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id, + current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id,