From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CCDA43345 for ; Thu, 16 Nov 2023 14:24:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2705A40A7D; Thu, 16 Nov 2023 14:24:39 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 460A1402C6 for ; Thu, 16 Nov 2023 14:24:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTVpdz42leXJ0hqkkCdo2aBFP1hY9hVDD8MVSTcEwbg=; b=SVCP+rEkDYplAOLXyWmFp1AGvbmfxxMJJB7+ZvVWySSFj9ykjRMpFzX9f2s27Ab33x+N+c ltQcm0cIyQx3vqAuR/JG6qLkO3LigSNJjQtwsGsFDPu1jJbwS0MeUWgb9bAX+H6otY6jPI WObzK1oXR0QessHEkbyhUYdqhLwYi2M= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-KqX9nY_NPrqOj6PHVK_VJQ-1; Thu, 16 Nov 2023 08:24:33 -0500 X-MC-Unique: KqX9nY_NPrqOj6PHVK_VJQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 394443C0FCA9; Thu, 16 Nov 2023 13:24:33 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id A07B32166B27; Thu, 16 Nov 2023 13:24:32 +0000 (UTC) From: Kevin Traynor To: Jie Hai Cc: dpdk stable Subject: patch 'net/hns3: fix uninitialized hash algo value' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:23:07 +0000 Message-ID: <20231116132348.557257-25-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c2404cbdfadb2bc5408dacd1450f2dbbc55180cc Thanks. Kevin --- >From c2404cbdfadb2bc5408dacd1450f2dbbc55180cc Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Tue, 31 Oct 2023 20:23:59 +0800 Subject: [PATCH] net/hns3: fix uninitialized hash algo value [ upstream commit 177cf5c93f9ac86d8a2b817115ef1e979023414c ] This patch initializes "hash_algo" as zero to avoid using it uninitialized. Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 19d1ae24fd..b587954508 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -772,5 +772,5 @@ hns3_dev_rss_hash_conf_get(struct rte_eth_dev *dev, struct hns3_adapter *hns = dev->data->dev_private; struct hns3_hw *hw = &hns->hw; - uint8_t hash_algo; + uint8_t hash_algo = 0; int ret; @@ -994,5 +994,5 @@ hns3_update_rss_algo_key(struct hns3_hw *hw, uint8_t hash_func, uint8_t rss_key[HNS3_RSS_KEY_SIZE_MAX] = {0}; bool modify_key, modify_algo; - uint8_t hash_algo; + uint8_t hash_algo = 0; int ret; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:53.160350921 +0000 +++ 0025-net-hns3-fix-uninitialized-hash-algo-value.patch 2023-11-16 13:21:52.450946375 +0000 @@ -1 +1 @@ -From 177cf5c93f9ac86d8a2b817115ef1e979023414c Mon Sep 17 00:00:00 2001 +From c2404cbdfadb2bc5408dacd1450f2dbbc55180cc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 177cf5c93f9ac86d8a2b817115ef1e979023414c ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 9bb8426256..eeeca71a5c 100644 +index 19d1ae24fd..b587954508 100644