From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8FDA43345 for ; Thu, 16 Nov 2023 14:24:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2BBC40DDC; Thu, 16 Nov 2023 14:24:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CB67B402C6 for ; Thu, 16 Nov 2023 14:24:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWpdKkYX775PKyDJVtbMhuHI2fNryvOmB6AFKh/xwS4=; b=dFOfwJg2jESZQrf2uSZyynCoFQPSHMHb5aFxASnKNqnZ+cRC2XSZOKEHtM3/PXXW+Ff41J nQ5qQNl25hypclluQIDtTNZeoP3EXvuBhmKvKoD0nGm9xUN51tNI2VkmcusigZB/TUdtnx RskHR3HmgC5oDECgmB0yM4MIuuTlcgI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-hfji7C84PkCrpH13e5I2QQ-1; Thu, 16 Nov 2023 08:24:39 -0500 X-MC-Unique: hfji7C84PkCrpH13e5I2QQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E14FE82A66C; Thu, 16 Nov 2023 13:24:38 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72E4C2166B27; Thu, 16 Nov 2023 13:24:37 +0000 (UTC) From: Kevin Traynor To: Jie Hai Cc: Dongdong Liu , Reshma Pattan , Chengwen Feng , dpdk stable Subject: patch 'app/procinfo: adjust format of RSS info' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:23:11 +0000 Message-ID: <20231116132348.557257-29-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4c22ff4433d9474801d7710fb8c0091208416bff Thanks. Kevin --- >From 4c22ff4433d9474801d7710fb8c0091208416bff Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Thu, 2 Nov 2023 16:20:17 +0800 Subject: [PATCH] app/procinfo: adjust format of RSS info [ upstream commit 66d4bacc39fb765051594669c33aab4f5d0f9d6c ] This patch splits the length and value of RSS key into two parts, removes spaces between RSS keys, and adds line breaks between RSS key and RSS hf. Before the adjustment, RSS info is shown as: - RSS -- RSS len 40 key (hex): 6d 5a 56 da 25 5b e c2 41 67 \ 25 3d 43 a3 8f b0 d0 ca 2b cb ae 7b 30 b4 77 cb 2d \ a3 80 30 f2 c 6a 42 b7 3b be ac 1 fa -- hf 0x0 and after: - RSS info -- key len : 40 -- key (hex) : 6d5a56da255b0ec24167253d43a38fb0d0c \ a2bcbae7b30b477cb2da38030f20c6a42b73bbeac01fa -- hash function : 0x0 Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan Acked-by: Chengwen Feng --- app/proc-info/main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 41f983d52b..b52c3ffbc5 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -874,10 +874,11 @@ show_port(void) ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf); if (ret == 0) { - printf(" - RSS\n"); - printf("\t -- RSS len %u key (hex):", + printf(" - RSS info\n"); + printf("\t -- key len : %u\n", rss_conf.rss_key_len); + printf("\t -- key (hex) : "); for (k = 0; k < rss_conf.rss_key_len; k++) - printf(" %x", rss_conf.rss_key[k]); - printf("\t -- hf 0x%"PRIx64"\n", + printf("%02x", rss_conf.rss_key[k]); + printf("\n\t -- hash function : 0x%"PRIx64"\n", rss_conf.rss_hf); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:53.248278120 +0000 +++ 0029-app-procinfo-adjust-format-of-RSS-info.patch 2023-11-16 13:21:52.457946395 +0000 @@ -1 +1 @@ -From 66d4bacc39fb765051594669c33aab4f5d0f9d6c Mon Sep 17 00:00:00 2001 +From 4c22ff4433d9474801d7710fb8c0091208416bff Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 66d4bacc39fb765051594669c33aab4f5d0f9d6c ] + @@ -23 +24,0 @@ -Cc: stable@dpdk.org @@ -34 +35 @@ -index 3a441ba075..4c577fa417 100644 +index 41f983d52b..b52c3ffbc5 100644 @@ -37 +38 @@ -@@ -1177,10 +1177,11 @@ show_port(void) +@@ -874,10 +874,11 @@ show_port(void)