From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DE7843345 for ; Thu, 16 Nov 2023 14:25:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3872F40EE7; Thu, 16 Nov 2023 14:25:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E707140A89 for ; Thu, 16 Nov 2023 14:25:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kALHiijgToj26PHUE4viOvbTGxcGLaRW+GFpxDYaMSw=; b=GaQ05f4ctnxINmefTxK1aYnRZdMOm9xIHHOdVANSY7k7NBpLjbXWIaXI9f1DsNgVUphcpo HOYp1FBtbgV1gj4fOOf2lrBGzHFqb78Lu7exDx7umP72a0m6Y7av7YbgZ8U9mp07pzT4EY EKTStT0TBK0s0SA351cl4p0Yw1h2mes= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-43-PxM5-DBzOSGKVw0YxoR0iw-1; Thu, 16 Nov 2023 08:25:07 -0500 X-MC-Unique: PxM5-DBzOSGKVw0YxoR0iw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0EE9D185A785; Thu, 16 Nov 2023 13:25:07 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22F302166B27; Thu, 16 Nov 2023 13:25:05 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: remove useless check in TSO command' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:23:34 +0000 Message-ID: <20231116132348.557257-52-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7c56526795e26f427c0d2413838dbd2b5c8e5ccb Thanks. Kevin --- >From 7c56526795e26f427c0d2413838dbd2b5c8e5ccb Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Tue, 7 Nov 2023 12:11:16 +0800 Subject: [PATCH] app/testpmd: remove useless check in TSO command [ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] Testpmd has added the check of TSO offload capability of port, please see the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") So the code following the check code memtioned above to display warning when port doesn't support TSO offload doesn't access to forever. Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") Signed-off-by: Huisong Li Acked-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 64e6f4159c..8e200c740b 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -5002,17 +5002,4 @@ cmd_tso_set_parsed(void *parsed_result, } cmd_config_queue_tx_offloads(&ports[res->port_id]); - - /* display warnings if configuration is not supported by the NIC */ - ret = eth_dev_info_get_print_err(res->port_id, &dev_info); - if (ret != 0) - return; - - if ((ports[res->port_id].tso_segsz != 0) && - (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) { - fprintf(stderr, - "Warning: TSO enabled but not supported by port %d\n", - res->port_id); - } - cmd_reconfig_device_queue(res->port_id, 1, 1); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:53.780509659 +0000 +++ 0052-app-testpmd-remove-useless-check-in-TSO-command.patch 2023-11-16 13:21:52.527946599 +0000 @@ -1 +1 @@ -From 773397f6f4b5e325e786835343bacbc454d1e5f0 Mon Sep 17 00:00:00 2001 +From 7c56526795e26f427c0d2413838dbd2b5c8e5ccb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 912bf3355c..1c57e07d41 100644 +index 64e6f4159c..8e200c740b 100644 @@ -25 +26 @@ -@@ -4968,17 +4968,4 @@ cmd_tso_set_parsed(void *parsed_result, +@@ -5002,17 +5002,4 @@ cmd_tso_set_parsed(void *parsed_result,