From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4AD243345 for ; Thu, 16 Nov 2023 14:25:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE2A8410E4; Thu, 16 Nov 2023 14:25:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3851340DF5 for ; Thu, 16 Nov 2023 14:25:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700141123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+JAo2UbHyOPlhUGlmahgJrFPPdp14w+WUVX45o2tins=; b=MTaX+yC/0qx0A3LMqKrBkjqlR8CsSxWHj2EWc7O4JfADVUACcdIZaf+BatX3rzIbjI7bvC m9dGGeixHESC6iMP+m6zB0bk2x/lW/uiFDle8O8HjynApV7WU3RsQMlj4xZM4PXJIT62Qg pYuuz1kvYa8bwTMsJMtWKv+/fi6ZG5s= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-rQHyogQeOQyQRuqAs3ZdHQ-1; Thu, 16 Nov 2023 08:25:20 -0500 X-MC-Unique: rQHyogQeOQyQRuqAs3ZdHQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7931B29ABA38; Thu, 16 Nov 2023 13:25:20 +0000 (UTC) Received: from rh.Home (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE87F2166B27; Thu, 16 Nov 2023 13:25:19 +0000 (UTC) From: Kevin Traynor To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix shared Rx queue list management' has been queued to stable release 21.11.6 Date: Thu, 16 Nov 2023 13:23:45 +0000 Message-ID: <20231116132348.557257-63-ktraynor@redhat.com> In-Reply-To: <20231116132348.557257-1-ktraynor@redhat.com> References: <20231116132348.557257-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/ac941d304e541a5a9aad6882ca3cbc3fbd4a7d95 Thanks. Kevin --- >From ac941d304e541a5a9aad6882ca3cbc3fbd4a7d95 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Mon, 13 Nov 2023 09:24:48 +0200 Subject: [PATCH] net/mlx5: fix shared Rx queue list management [ upstream commit bcc220cb57d7a2c45703c7215aad2320ac0a1e51 ] In shared Rx queue case, the shared control structure could only be released after the last port's dereference in the group. There is another management list that holding all of the used Rx queues' structures for a port. If the reference count of a control structure is changed to zero during port close, it can be removed from the list directly without freeing the resource. Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index e4d0291b9d..da1b1f8bb9 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2162,4 +2162,5 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) } } else { /* Refcnt zero, closing device. */ + LIST_REMOVE(rxq_ctrl, next); LIST_REMOVE(rxq, owner_entry); if (LIST_EMPTY(&rxq_ctrl->owners)) { @@ -2169,5 +2170,4 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) if (rxq_ctrl->rxq.shared) LIST_REMOVE(rxq_ctrl, share_entry); - LIST_REMOVE(rxq_ctrl, next); mlx5_free(rxq_ctrl); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-16 13:21:54.055858055 +0000 +++ 0063-net-mlx5-fix-shared-Rx-queue-list-management.patch 2023-11-16 13:21:52.590946783 +0000 @@ -1 +1 @@ -From bcc220cb57d7a2c45703c7215aad2320ac0a1e51 Mon Sep 17 00:00:00 2001 +From ac941d304e541a5a9aad6882ca3cbc3fbd4a7d95 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bcc220cb57d7a2c45703c7215aad2320ac0a1e51 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 88b2dc54b3..2c51af11c7 100644 +index e4d0291b9d..da1b1f8bb9 100644 @@ -27 +28 @@ -@@ -2281,4 +2281,5 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) +@@ -2162,4 +2162,5 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) @@ -33 +34 @@ -@@ -2288,5 +2289,4 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) +@@ -2169,5 +2170,4 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx)