From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A92FD4334C for ; Fri, 17 Nov 2023 04:16:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8487440271; Fri, 17 Nov 2023 04:16:07 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2111.outbound.protection.outlook.com [40.107.94.111]) by mails.dpdk.org (Postfix) with ESMTP id 349754014F for ; Fri, 17 Nov 2023 04:16:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bPHlVA7w29Fy/BPiMFwQl61jZzRc9y3tnVOBRfUgyxiCWlEhLLHH1R9iV51TAiPvadxxYEBrAY/NaBzjgOrxsKOy1I3Eh6021Yo/VOajXQ80dMsEX9P7x4HuIXafXZO/YuNtcfbVPs5ceaGGg+7hEX+AVMttPEPEFOXfh1BKOqluNMdttioTFnTLMlS5fquJ8fy7+hQAnYxwPzvbJVo98PL2rsZlotf4R8kfcqpFVMaDWroqQKW1NS7nXWJegXbKHnv3sxyHg713f5dAoIYJAWmuR6UqG7V5cjtxx0893o2uPAWczSgSBh4hE4UJHeHFGHUM8EGrVuMtjW8tJplySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e5MfptwIYGFU2099DVhIiiLiDSY1cfCxXs0s75AnILE=; b=YBltI1fhqI1ugRzbqQp9AwweqhK76UBfbcxeiNVyrPS9TkQEIaGtzYZ9RpgSVoI4aevbegLTmxb03si7/iLHVv6AQc5q2d8fHmHpJKbPTq7grQqiXc3CBYqHwKQ+OBUkgDsoIHpklMNhjAXR2ADzyk3XEvOlJphXAXpxmoTk0t0/4Lz0BdQZe9NPxuaSec4MYR0X8+/7ZZYt693Ym1qvSkY0pigwU4BNBsKMzXszjTlRHYgV2WBW3PSN/BDZQsvW1Fi9HNxtbBfDq5vQKvq6qQKsQkmVHIz+tXq6yua+EGExg07J+eVznu/pZcaRNfXcyB+R23EWJ0Zy4hdod7PsNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5MfptwIYGFU2099DVhIiiLiDSY1cfCxXs0s75AnILE=; b=suvkI2BPR7sexIbt80v1IvR69CPWutQtSJZzLhccGjXRuLfEb5KnAejhfv7/6Mc608Le/iDpl2bxknH8YSDakEkSxT+KG9/E3bIcJZniEmbHgpyZ6QH9/eaPPVG6k+G6/cn68MRsOqcWn48eI8ACYc0NmHagHNKGtsPMHuwEeZE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5976.namprd13.prod.outlook.com (2603:10b6:510:16f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 17 Nov 2023 03:16:01 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Fri, 17 Nov 2023 03:16:01 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , Shihong Wang , Peng Zhang Subject: [PATCH 21.11] net/nfp: fix DMA error after abnormal exit Date: Fri, 17 Nov 2023 11:14:56 +0800 Message-Id: <20231117031500.1609817-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY3PR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:39b::15) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5976:EE_ X-MS-Office365-Filtering-Correlation-Id: 79dcac80-f030-4af9-2145-08dbe71b8693 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8pnH8UVnWQcSLbz7H5GQgiGRrXoytwAYEFrqFfSovzqKqrXZ9t8m+xNYHDAoQKLq2hEx6tJ88wRAHx0oXhdJE/2sn+xZiKCX3MwzMk0zCNndI4cEE3C/dFYKOvbDc6fUvITIxDUE9LxBw5FGeZVhVuWbS/n9RHmfNY2DvIVbmojlYMZkzA73v1ia/DqJ3m4gSy9CvTMHP3suEWkoPxo6cWhgk9qm05DoXqip0pKprwZgAHT7GJtVPnccptrXwOAhY0pCoyZny5Nf27Jz3Te71WqX9/6NroTS/3b1uGRw1Idn+AmY118ItxtBV4orNWU+8+LxumHIVpoGdkwHIglxUnWACs3l4lh3e6b/aU16cofQq582jhSq8jInSAd7kUfHipNvzKxCTa9IScBed3GInuhMxAYAV+n/ooB15cCtXskT9188p2JmRd1G9gqP1e86TrTY7EKl2SmrPHD1HylZ026FXmON4TYrYW45zXq3Kpc6LHy9ptCqLphtGBWuPOT3viVylhWVhv9MFbvvnsBAZQUVPhd8efXhrDQNJgZDYYjjGh02vu6Ax4mL7xRW/HwQkDLh8o0qmDBseSKsmkwSxdwyejA3pfuP0tFDBdZYH5kQg4aqpVoLnmPQADr+xfj+xlXk3Ms2dum9JJCemOhbCDXuJdtknaiFMoakUiH3bX8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(366004)(396003)(376002)(136003)(346002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(41300700001)(5660300002)(38100700002)(86362001)(38350700005)(2906002)(36756003)(54906003)(4326008)(52116002)(2616005)(8936002)(316002)(6506007)(8676002)(6486002)(6512007)(66476007)(107886003)(6916009)(1076003)(66556008)(66946007)(44832011)(478600001)(6666004)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jHjbsHg1zuyNY9tldCeLQNLwGCijI9PPpe11T3C2HqADu/ChqtvkaBf04SoB?= =?us-ascii?Q?ND8Rnp8poMZvB3r3POlFqvNwDoKoFojm8vwpLWZqoZYD60Nz2UPboKRaOOdB?= =?us-ascii?Q?+C7bgTGRXknbeY6UZnJZwRxotcg+VI0MBeXG30jrFv5M8ASy8EKtPFao8JKR?= =?us-ascii?Q?f0WPMSS1sjLSD8F/gRyOuSKxiy/CJ7gEjZBfjgxqyAb/0RUdjH2de+D/atNh?= =?us-ascii?Q?VmS3Kem8Qnu97DqSsBwJcX+w2vRS8S/eN2jDPEbprZfypgNODSdNTvqFoufk?= =?us-ascii?Q?JNnno2rWk88NV9jhcJLrXKdxAiT07rPN+bV38GD8Ch8Sb64BeWPd53bC3QQS?= =?us-ascii?Q?t9x2aSKjtJ/S9GCEqULuy9eubpi8o4pjEYXonIrTvVwsNeKhWbEmgymKT93W?= =?us-ascii?Q?VdjR95pnYuVhnUis5Vm+m1GIPoS5e5GbktELjIcQvkWb8OQFSU7SwL0o+SHj?= =?us-ascii?Q?YYqYQhvOUjR0GEaIKQrVx2YFWzd++4LbNm1sJH/WoJj5EYaFF2tihpa3bkC1?= =?us-ascii?Q?A5C4vdwvMKc1Fkz8uo+L4Q7ta/9BaK2IFzaBqQ6bD38QLpg3/3PWlhoteOzR?= =?us-ascii?Q?8erLTF1QjVx10VsHCDBEWsANXgjrfmC9BFe5ctP4CoA/4Mh6SlVbYlSXZxac?= =?us-ascii?Q?5jXGZ3MGSnxc7rVFst8rRkPcW9YP/F9O3hF1lIPlSwRwE5cc2wgfNcrsmM8z?= =?us-ascii?Q?o9kWXKckwIxfiBAOzeruNK+PswUoqLey5baTzsB3OX5V6eFUM6k629jULf2s?= =?us-ascii?Q?MAWeUDV7MEb0g/Xgji8LvBh+69ZRIQ+J9aRZXRT6ChJSFuLs/bDElIXvS6DF?= =?us-ascii?Q?l75XdwDFjZEHBFK+9YGDAURay9ZwHg5KU4rIKrDfG7/UTqhtNCzg0UrRVkPq?= =?us-ascii?Q?zbviD4VM98QFfjhPbfi763L41ezYHsqi5FEz2B3b1iW/gC9Xarh3x3A7QqP3?= =?us-ascii?Q?WT/n7cM4170ZXjeVu7b/jMMI8BeDUzsyJejpULEYr6GHxch0eNWOtmXSJlWu?= =?us-ascii?Q?NYDJTXVvZBode9+4BcA4lP7+iIR5X8meVx4b8yWuVJkBSShKVFMNuRDrsK/7?= =?us-ascii?Q?kxaMF+9eE2JdNh73rTAA5iphpnKi/Ms6QMp5KSqvYA6wjpv7T4Wc8rjpOB2b?= =?us-ascii?Q?0wXOt1KJwiyCX4Q3GHynBbABbPHXGfG8ytS5TtOegMR/vQkiF/Cr3ol4Qz5p?= =?us-ascii?Q?sDG2F9xO78pEiOADKUAVvUPt64oIgr8FK7dZtIFMz+WT0/D7Co8XE7InwLVS?= =?us-ascii?Q?pxnmI/SaqJZhhv0RxyIdZHY8UPzFSeUxnZiucydsZwogBdAQKeAb8L0jCHzn?= =?us-ascii?Q?1Nn/vMffvEqdvweiF1fXZTN+BdvEyNYB4Rj8xZEkEgXsokaxKWgrdJqcGKtx?= =?us-ascii?Q?q3AfMintAYZkwER1AVyE46rCYQGdaVvqLLqiTpUyc6eBDSICptyaR+HgUlHv?= =?us-ascii?Q?8MBA5YQvqPXEXhawRPYCDnwNWVN6owAo7vq+7qvYVlxEL0oOuMd3HFZMXXtB?= =?us-ascii?Q?bOBQqY8fyMTSs2EoUXXhVso5yRNh/CPsiS3/AKqW6yEOA1sQHk2xtrd7gInp?= =?us-ascii?Q?3odcQgC6J9lvanm9S2pAFxQIKC3FHGkpozpTHai6CmY/2UAs8L2oyQdZdfFy?= =?us-ascii?Q?4g=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79dcac80-f030-4af9-2145-08dbe71b8693 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 03:16:01.4268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AcwffOUUqHuxc6fOpcgq3EQgQCl8qCmwi7QWHjzr3jF2RMiykI7m7I/NhzOyFE+nWEXC8a8sCHjw3+hIoKLuVe3Z/O7Ou5dAIMguMvWRbuA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5976 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 9e442599802e788874110339901f4eeb8f0ecc3b ] When DPDK application exit abnormally, there might have DMA error, and which will cause the load of firmware failed. Fix this by force the physical port down to clear the possible DMA error. Fixes: 896c265ef954 ("net/nfp: use new CPP interface") Signed-off-by: Shihong Wang Signed-off-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 5729b8a2fd..e1da0bdebe 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -810,6 +810,7 @@ static int nfp_pf_init(struct rte_pci_device *pci_dev) int total_ports; int ret = -ENODEV; int err; + uint32_t i; if (!pci_dev) return ret; @@ -846,6 +847,10 @@ static int nfp_pf_init(struct rte_pci_device *pci_dev) goto hwinfo_cleanup; } + /* Force the physical port down to clear the possible DMA error */ + for (i = 0; i < nfp_eth_table->count; i++) + nfp_eth_set_configured(cpp, nfp_eth_table->ports[i].index, 0); + if (nfp_fw_setup(pci_dev, cpp, nfp_eth_table, hwinfo)) { PMD_INIT_LOG(ERR, "Error when uploading firmware"); ret = -EIO; -- 2.39.1