From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5636A4334C for ; Fri, 17 Nov 2023 04:16:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A49544069F; Fri, 17 Nov 2023 04:16:07 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2111.outbound.protection.outlook.com [40.107.94.111]) by mails.dpdk.org (Postfix) with ESMTP id 96F8440271 for ; Fri, 17 Nov 2023 04:16:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6h6+RUWJshYGKUEsphdchqPGzPGtwtdY+isAPg/lJPZremP5r/KUttcaY8T1ifELZ6Et5WwuCBc6JKvmuOGKhlHtLve4M8YKHtI1HwDlcZIMmc4IvKYdgkaHPIAoPMesyW0umiXDroCGoLoV8tRgz0BZtQMKBoepHz0vsq1w4F/bP6xLgPOaQnXRAZoNUoRsJ2x6fzjow/ixrOkRnicMmUCEj2Sgu+0n1ojO1RHknYttFpUSvG+MsMer+8uWWW+CxeIkJePC9Ep6FZJc3SAkTBj1vP3GRk0ggsc2RetlY91ia00tQvkalFGRhtpAsf0oAHq/cUNIsURUpOzwKj0ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ew/EYXAxzT9ArC5/FavGO6WMiKqHTyIxRWw6MfBIqsE=; b=oCh53E7SEnzdHbqTgSMxxb9Ti3Iuq+bDpDDPubSu6wc552O3N938VXz85fv+eLdCZSQH+RY2dB0DQRcrOxLUrMTHaYbgOOTXsIv81mx6OzVbCoQ5k0Anv7EsSLmHacnHr0ynHMrdcDT3uT2GwNpIHh7SyPHPfLFD/5aeFFAWIm7Hp5zY1DuFCy+aZik/PZCNiy3iPaXKwboX32XbUfepw2HerpSQyORTfb5H22M1zjd7Ln6CyRs/ICV9jhzi8Ug5601lLCXG5b+JAkbzlh44LROfviizCH4kDDgUm76EhJ70qJ/iGGSixBW0TAEaGUrvM9UGqXA88/7W8Nuiqc6H0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ew/EYXAxzT9ArC5/FavGO6WMiKqHTyIxRWw6MfBIqsE=; b=E2/5gY06QFNpiBqS5O7ZT94fuCKd2XoiYCZpkJ/RcXW9tqr5qvRfL2FUknX8UvfgnunAKT+5n5ycWVWiqf8R8ydp5UY39J38s8t3rvfZO9ZMUbn9Ctyw44cc8A+n0/IaL+HTPL97LddHAlNbpPgDN33iOFQfAAyvl2ZZLjtl24s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5976.namprd13.prod.outlook.com (2603:10b6:510:16f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 17 Nov 2023 03:16:03 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6977.029; Fri, 17 Nov 2023 03:16:03 +0000 From: Chaoyong He To: stable@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , Shihong Wang , Peng Zhang Subject: [PATCH 21.11] net/nfp: fix link status interrupt Date: Fri, 17 Nov 2023 11:14:57 +0800 Message-Id: <20231117031500.1609817-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231117031500.1609817-1-chaoyong.he@corigine.com> References: <20231117031500.1609817-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY3PR05CA0040.namprd05.prod.outlook.com (2603:10b6:a03:39b::15) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5976:EE_ X-MS-Office365-Filtering-Correlation-Id: 74821657-17a4-43e7-4e8e-08dbe71b87c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2JZf4pZrJChXV35TrUC3bdM2d3jUstWH587iRzOz4NRKWMcoaE8RX5cA/CdNKppcWb7KUV4L/cbcnP5tFdKpn+BigX3TAlGooDkugPlM39KlGH6aUdudihrfpmfxxlsfs8kACqETmsNqvq0fTsn+Zc0CYXCZk7Y52exhAu1tzCOzCrgpEc9MXjAZBIzcSVcqeab08X99nmXxXMtY5Ozy9XdJKB8EPXQTPIQ3B265jRCOgp+fA/AVE1XJh4VwnD0VkDrNn/vrFN2LLo3ELA/r95/XKLEjyFNGE/oJIbKofDW+TN6Nkj+Ep7WUiMYJaMuZoVwFnC82Vzx//+JhNnOaQNQ+j4NikaR3MU+ZdnszJUpIP765VkaUiqFOwQl+lYeS2CU401CnOJA92Ovzm0Q8oAH4TBV36HzcU5u1cE6lYTeSTzXAqEvgd6XYgIKkEQG5VDiio3YSSX0Wm/10vqbvZJvRqc8wGk/ZSZc//yyQm3MlQltgJMYtVL+jApm0X7jQ64LZ90auoX3KbYS+aNnSkyWy7RKRESsr0H/Md1bNjXSAGlA1mBdobwWd3eIjJtrlgatnBSHczyOhQhiF0sEkydvsMzTxw+80nNY/3Ybw9i8LtuZpx1mkW8pbJcTYfqkZVG9ssbHSStItfCAGaUOqnj9NtBrjpf+NimEEsUAWLKM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39830400003)(366004)(396003)(376002)(136003)(346002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(41300700001)(5660300002)(38100700002)(86362001)(38350700005)(2906002)(36756003)(54906003)(4326008)(52116002)(83380400001)(2616005)(8936002)(316002)(6506007)(8676002)(6486002)(6512007)(66476007)(107886003)(6916009)(1076003)(66556008)(66946007)(44832011)(478600001)(6666004)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lTLltrV/jCBsUm/iH08iI+IeAMioS9lPNTKiaNHqbuODO4qjG+yLue6YJ3Dl?= =?us-ascii?Q?Cj3zLjyppG0xuNMS8oNum5vJrSWhkluPjFZA+LztIFv7vLw+vjQluVBu72cv?= =?us-ascii?Q?/+G1pILO5AaDCQifVG8KwtIxOAH2zq36vLvqsYQmF8vhcBIgy+g2bPEs+5EO?= =?us-ascii?Q?2qFKa0xmwKb1KzprNBN6zn4VNDNGxGBmHgIj4TkDuCRaSXVpeTURggGOapjx?= =?us-ascii?Q?PqF9aLx8xxMpzWpucvd7zFaHw7oFNTBBN9H+0bC3LF21hIkK4jftCwr/3bY3?= =?us-ascii?Q?tCjzOr3ppMFXJIF9Db5x+d/L99fX8mDV0XY3hD2flKKyuQfqBp1PmCD2SljW?= =?us-ascii?Q?Li9PHO4Y97DRqujpkPRX8f2yGI1MOlPS4vxDfwInyawz3kctb/GV2w0/8bJM?= =?us-ascii?Q?OtV7OVJfubUSwdh3BevRvnABkCvdveHuZ0zegzDEH1Ka5EKTPdWJoF6vYRdA?= =?us-ascii?Q?ISwBCGa3sZoe1lw0/33xTKWaO3Jvh0QLDJOpHnGHHsIs7huK009PvGz9J4Zf?= =?us-ascii?Q?uP8pOk/ebapP5xVXPGeiXJlHnFtvHFql4TeDVGQxq5maiPdWi6zSmeKqgW7I?= =?us-ascii?Q?8F9IeV4ikNklSd7iOlqDkqaYEkEUdoPicqrTsq3p4lRw4e+WFQ3NVKnHLem9?= =?us-ascii?Q?Pddi4ido0/qT8Ge1k2KN42kjiYkoRASNUT+XNgSV3S0Cqd4eC+rktVz/d4KG?= =?us-ascii?Q?VajzVkneZ5m8Zn5aCNzy7HZLZqovEPFgxucniNIKF2qzj9qehctXJqyowX5Q?= =?us-ascii?Q?lBZFfII4th8sTgSSO/ssRz9uwaKS62kLU8KNck/RWcavmOwqkH41hdbTbuDP?= =?us-ascii?Q?8WK9giRvKA2w1uIOKDUsjMSXwsRxmF3CpPTlDXqOyDZj7qGli1b/4A0yrMVN?= =?us-ascii?Q?4Rgp+iQ6MvB3wIj0WLEvry/Ohh2/uNa90sbCtSeiYe/JXYdRd8U9/cJe6FnQ?= =?us-ascii?Q?tNiQraZPP+bBWhXjzflUJXirO/KXC3AkN9iHwPwLNfYuGXH/dBqFdFPcYz21?= =?us-ascii?Q?+jZadxJXlp9R2iU4aH/kOosrpwbiPq7FvC0sHINNSRa04Z9vnO0b/wbjDtuY?= =?us-ascii?Q?/LTNdq010qSWpyXSovYMo3YPq8gv/4Qx5NfDzT8rOwqnnHKTDWPoO7MKBvSh?= =?us-ascii?Q?NFZqDt+S5BmaaHOGRDQ2ba7NLZP+0YJCxaPwvTULufNv3w/gBlGFxV5M1E0y?= =?us-ascii?Q?bMQpISeWlltpAK5/nMuFXsI4H/FAzendmQjypWlaPHkeKjyh1f3utH2atElh?= =?us-ascii?Q?fU5RH6jxQ/2bQm2d/iBrWaQqnEkupLrsftItW0j9LgQZEjK6g3Nt+DZZt4ea?= =?us-ascii?Q?/I3IGEOtpfjHQjHEw2mHjq0V1IditK9y8ElSrMbDePJtbXXC4DKfueKmq11R?= =?us-ascii?Q?0gLs1H1egfipjTw312OdlL7wF+5cDPKgEz0/7tkSQJSgrF4jmvbKu1VLlYM5?= =?us-ascii?Q?3DpvOkYgSKi4ptHKEhgwddbwZKigRyejdJ0teKdFn2EPl5JgiRGsGSozYkoH?= =?us-ascii?Q?Fraawg4pJvBq8ZAH1xv1whbb5Tl/1RDn899WqnMwEAexOV//ziSOLZ7X9niw?= =?us-ascii?Q?JT6GKbIbr0Tz5ye7YuogD72k/vkhGnY9f1T3qSsHt/9OYkPivoZUqYigTc99?= =?us-ascii?Q?FQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74821657-17a4-43e7-4e8e-08dbe71b87c4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 03:16:03.4300 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T+bc/LYd7DKgQtv4/ejvQ78ePBIRXuDv9x+93TxS5nCiNfr2ppMYQSZM44YHGcI7Oz7T3p02KbdLPOkEKOKJ5cRheGsTRQr1D23XukhZs4I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5976 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org [ upstream commit 94d0631a8275afa4314ee1d4f08d2fbd02325124 ] In rare cases, when DPDK application exit, the interrupt handler was not processed the interrupt in time, resulting in the LSC interrupt mask bit not being cleared. So when the DPDK application start again, the newly coming LSC interrupts cannot be received and processed properly. Fix this problem by force clear the LSC interrupt mask on port initialization. Fixes: 6c53f87b3497 ("nfp: add link status interrupt") Signed-off-by: Shihong Wang Signed-off-by: Peng Zhang --- drivers/net/nfp/nfp_common.c | 2 +- drivers/net/nfp/nfp_common.h | 1 + drivers/net/nfp/nfp_ethdev.c | 2 ++ drivers/net/nfp/nfp_ethdev_vf.c | 2 ++ 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c index 7dce3cf9a9..f73f7dd0be 100644 --- a/drivers/net/nfp/nfp_common.c +++ b/drivers/net/nfp/nfp_common.c @@ -881,7 +881,7 @@ nfp_net_dev_link_status_print(struct rte_eth_dev *dev) * If MSI-X auto-masking is enabled clear the mask bit, otherwise * clear the ICR for the entry. */ -static void +void nfp_net_irq_unmask(struct rte_eth_dev *dev) { struct nfp_net_hw *hw; diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h index 466e5a7932..8c39b84c36 100644 --- a/drivers/net/nfp/nfp_common.h +++ b/drivers/net/nfp/nfp_common.h @@ -379,6 +379,7 @@ int nfp_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id); void nfp_net_params_setup(struct nfp_net_hw *hw); void nfp_net_cfg_queue_setup(struct nfp_net_hw *hw); void nfp_eth_copy_mac(uint8_t *dst, const uint8_t *src); +void nfp_net_irq_unmask(struct rte_eth_dev *dev); void nfp_net_dev_interrupt_handler(void *param); void nfp_net_dev_interrupt_delayed_handler(void *param); int nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 83232d4b73..5729b8a2fd 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -595,6 +595,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev) (void *)eth_dev); /* Telling the firmware about the LSC interrupt entry */ nn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX); + /* Unmask the LSC interrupt */ + nfp_net_irq_unmask(eth_dev); /* Recording current stats counters values */ nfp_net_stats_reset(eth_dev); } diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index ed80487acb..0dda3961ce 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -454,6 +454,8 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev) (void *)eth_dev); /* Telling the firmware about the LSC interrupt entry */ nn_cfg_writeb(hw, NFP_NET_CFG_LSC, NFP_NET_IRQ_LSC_IDX); + /* Unmask the LSC interrupt */ + nfp_net_irq_unmask(eth_dev); /* Recording current stats counters values */ nfp_net_stats_reset(eth_dev); } -- 2.39.1