From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79683433AC for ; Thu, 23 Nov 2023 17:17:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72D4242F99; Thu, 23 Nov 2023 17:17:35 +0100 (CET) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id AE31642F21 for ; Thu, 23 Nov 2023 17:17:33 +0100 (CET) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so13817171fa.3 for ; Thu, 23 Nov 2023 08:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700756253; x=1701361053; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OpYNFB6r/oiaDXYt4e/C06jgtCE2Qn8essdTO/9HTi0=; b=anryRZ6mtHAmfswL0E+GENv5BCb3GUNTU4FnDqrEkvWa2R7mfY93Aq+VEhnyaOFfo1 1WW1ZZ2s2cqhH/rEBpPtmGRMDZVfossnEVBR+8UHRYCT71nnd2JApphFDLg2nlsHSalD re0z5bQJxqhzxhn1yhy1oWctUxE268EiTzj9C3gemqFKeM+SK4C5qpxxxIPPOUbMMhbQ 24ICJ8h2E+pjnwc1MlrI2GmaDOlfIFx0FGKV7o3jPH+Nky3QMGAKFpJvm60yH4D/sfjw NLXGqbRBOYjVWVJeCyLZ6GJaftUejSQZGJudnduqc+hatOphUYraUwGnBVAaCB3ksjXR l56w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700756253; x=1701361053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpYNFB6r/oiaDXYt4e/C06jgtCE2Qn8essdTO/9HTi0=; b=Y4zU4/ChEIrPWu+DWmxcBO1OsNPctr6SJsTDaXbjaGCa4ensnpi7+aL31D1uWveS0g C5EsCB3QlYWHsbZ4apMX1ugAivGFF/Wu0bMKn4jTVTdFW2dUKNUPyKyoLRIQDkwwEu16 RGPNmWrWKfpNP4RCf4pbYWsdB87RKuP8+fE8Qx4GIWA/nNlxaT4/SnHid9g3M64e1piE evrIoC6RSmH2NQBy1CZ/bjU0rkmdhxHPgdj99Uy1Xq7AuHGqJMzQXc4WGs1xF769q+OV 2WI8Hfir8VmOkr4B286Sa3oGzC+o3H65S565qynn5WeHtW9N4h/QTrmb/SSFmSWS6C8x eJgA== X-Gm-Message-State: AOJu0YxIjl/dWMB8FZbVj/HhqRguvOnVF+cwQnf2pa7dUUXN2+GWVmcj 2GIOKJh5xBIejJjmo1GtMQKbyOWO7ZaOdBqQ X-Google-Smtp-Source: AGHT+IG9/Td6/RsqF3b12zu05hDMk0nyRhOT7PerQ9RVvMLgrRaXqa1luTICrAvziXfPgTvniCc0+Q== X-Received: by 2002:a2e:a48f:0:b0:2c8:87bd:7bfd with SMTP id h15-20020a2ea48f000000b002c887bd7bfdmr3859086lji.0.1700756252651; Thu, 23 Nov 2023 08:17:32 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id h8-20020a05600c314800b0040b3937833dsm149742wmo.3.2023.11.23.08.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:17:31 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'pdump: fix error number on IPC response' has been queued to stable release 20.11.10 Date: Thu, 23 Nov 2023 16:17:06 +0000 Message-Id: <20231123161709.670852-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123161709.670852-1-luca.boccassi@gmail.com> References: <20231115114515.2355140-16-luca.boccassi@gmail.com> <20231123161709.670852-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/00d4567c7245620b51477b2388f65c1d0daf8212 Thanks. Luca Boccassi --- >From 00d4567c7245620b51477b2388f65c1d0daf8212 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 17 Nov 2023 08:35:55 -0800 Subject: [PATCH] pdump: fix error number on IPC response MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/librte_pdump/rte_pdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 29eafaa101..746005af60 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -473,9 +473,10 @@ pdump_prepare_client_request(char *device, uint16_t queue, if (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) { mp_rep = &mp_reply.msgs[0]; resp = (struct pdump_response *)mp_rep->param; - rte_errno = resp->err_value; - if (!resp->err_value) + if (resp->err_value == 0) ret = 0; + else + rte_errno = -resp->err_value; free(mp_reply.msgs); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-23 16:15:19.459000728 +0000 +++ 0006-pdump-fix-error-number-on-IPC-response.patch 2023-11-23 16:15:19.215058380 +0000 @@ -1 +1 @@ -From 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 Mon Sep 17 00:00:00 2001 +From 00d4567c7245620b51477b2388f65c1d0daf8212 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - lib/pdump/rte_pdump.c | 5 +++-- + lib/librte_pdump/rte_pdump.c | 5 +++-- @@ -23,5 +24,5 @@ -diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c -index 80b90c6f7d..e94f49e212 100644 ---- a/lib/pdump/rte_pdump.c -+++ b/lib/pdump/rte_pdump.c -@@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue, +diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c +index 29eafaa101..746005af60 100644 +--- a/lib/librte_pdump/rte_pdump.c ++++ b/lib/librte_pdump/rte_pdump.c +@@ -473,9 +473,10 @@ pdump_prepare_client_request(char *device, uint16_t queue,