From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50BBC433B8 for ; Fri, 24 Nov 2023 14:53:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46D7B432D8; Fri, 24 Nov 2023 14:53:16 +0100 (CET) Received: from mail-ej1-f98.google.com (mail-ej1-f98.google.com [209.85.218.98]) by mails.dpdk.org (Postfix) with ESMTP id 45443432B6 for ; Fri, 24 Nov 2023 14:53:14 +0100 (CET) Received: by mail-ej1-f98.google.com with SMTP id a640c23a62f3a-a00191363c1so289757766b.0 for ; Fri, 24 Nov 2023 05:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1700833994; x=1701438794; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KXpSx26RDIo6dTfCRwPOlT+BHhYhl1f3t0gNKwh2Ojs=; b=imWTp9Au+7JNTikb4WstJTURWAEbx9E8PcuHFCP306eBtRzgdY0qYrsCzb+jM/WGkj pXaMcDQRq8G8B/gE7BqheMyojZryU9jngUABRNUvFzLc5a1fNWozVR8cFbf0Eo0EhBGB bM1Jam4aW/BXDFhYpO22B5GPV1Yv+8lzi4NTTmwP8gVxlIJgLc/n/TA6I5TKCqTItPMz 6GK3ktO6JwqqbEf1OxRUK6YDur7qLGFv72PvCHV6KKr9SYngKg4raeYUYs+HrupVL7Dn jhfuVK32Zn/Ja2kdB2QzLB/Bot+MRpPaqr2scOfSRwHHPPOmtE7Db6kh6UnB05gaD3tf T63Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700833994; x=1701438794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KXpSx26RDIo6dTfCRwPOlT+BHhYhl1f3t0gNKwh2Ojs=; b=c3JCyaC0TSQ/bzBmSJWsbvn+T6ihMxh+vkCoJ9dn+hI5DKV65McZC13cfQkKRQ70hY 9o/O4TJ6bkNQTb6vnAye0nU+cPHLpiGXlNji+o07Jukmd0FwE7iWp2eqFn2ABCbddL7E UrDdsSMYWY7owBiOKxlQvrQtFdPP4aYnZA2B5QKjvqveXmpesB8VAZUOJbWUlfdqyTmm OeRVfm0GheU7cTJCIwxMSx3sM1l4nnSCK7AiLCrRQwCKT1E8N2ZatEE/fV9ayy/9IqaB xMgmH55hvcb6LrUqPUBH5WicFnyySeYO0Qg7GKDpL91erdaVg4kUnTRpyEN855CTo3X9 9jZw== X-Gm-Message-State: AOJu0YxgxlQyPxgSvhETFnvEQpFaOEs5hpTqKHW/eZGRrqVjNfJCA3W5 tMJprlgBd/BDOM3ZZvIK2VGB5xt2QxpLobZqTUd/abOG/BVDzA== X-Google-Smtp-Source: AGHT+IGNXO6rlnIrU5pNJDelE3Yz3u6aOgmQshME9L8Ep5Q7HbG5iGcI6MvgwloRBMJ5+MljXDAteZ2IULeY X-Received: by 2002:a17:906:a1c8:b0:9a1:891b:6eed with SMTP id bx8-20020a170906a1c800b009a1891b6eedmr2278343ejb.76.1700833993934; Fri, 24 Nov 2023 05:53:13 -0800 (PST) Received: from smtpservice.6wind.com ([185.13.181.2]) by smtp-relay.gmail.com with ESMTP id hh11-20020a170906a94b00b009fbfaffc931sm527089ejb.110.2023.11.24.05.53.13; Fri, 24 Nov 2023 05:53:13 -0800 (PST) X-Relaying-Domain: 6wind.com Received: from localhost (dio.dev.6wind.com [10.17.1.86]) by smtpservice.6wind.com (Postfix) with ESMTP id 90F716003E; Fri, 24 Nov 2023 14:53:13 +0100 (CET) From: edwin.brossette@6wind.com To: dev@dpdk.org Cc: maxime.coquelin@redhat.com, ferruh.yigit@amd.com, olivier.matz@6wind.com, stable@dpdk.org, Edwin Brossette Subject: [PATCH] net/virtio: fix duplicated rxq xstats Date: Fri, 24 Nov 2023 14:52:36 +0100 Message-Id: <20231124135235.1831304-1-edwin.brossette@6wind.com> X-Mailer: git-send-email 2.35.0.4.g44a5d4affccf In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Edwin Brossette The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while moving queue stats from 'struct rte_eth_stats' to the individual pmds, as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats"). This flag was added so every pmd would keep its original behavior until the change was implemented. However, this flag was not removed afterwards in the virtio pmd and as a result, some queue stats are displayed twice when trying to get them: once in lib_rte_ethdev, and a second time in the virtio pmd. Remove this flag so stats are printed only once. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: stable@dpdk.org Signed-off-by: Edwin Brossette --- drivers/net/virtio/virtio_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index c2c0a1a11137..517585740eeb 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1793,8 +1793,6 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features) else eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; - eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; - /* Setting up rx_header size for the device */ if (virtio_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF) || virtio_with_feature(hw, VIRTIO_F_VERSION_1) || -- 2.35.0.4.g44a5d4affccf