* [PATCH] net/virtio: fix duplicated rxq xstats [not found] <CANDF9xARG2SvzRRK_3+8RK2SCP_Zj7DggOtPmnNDR9sWmr-j5Q@mail.gmail.com> @ 2023-11-24 13:52 ` edwin.brossette 2023-11-27 10:20 ` Ferruh Yigit 2024-02-06 14:56 ` Maxime Coquelin 0 siblings, 2 replies; 3+ messages in thread From: edwin.brossette @ 2023-11-24 13:52 UTC (permalink / raw) To: dev; +Cc: maxime.coquelin, ferruh.yigit, olivier.matz, stable, Edwin Brossette From: Edwin Brossette <edwin.brossette@6wind.com> The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while moving queue stats from 'struct rte_eth_stats' to the individual pmds, as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats"). This flag was added so every pmd would keep its original behavior until the change was implemented. However, this flag was not removed afterwards in the virtio pmd and as a result, some queue stats are displayed twice when trying to get them: once in lib_rte_ethdev, and a second time in the virtio pmd. Remove this flag so stats are printed only once. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: stable@dpdk.org Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com> --- drivers/net/virtio/virtio_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index c2c0a1a11137..517585740eeb 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -1793,8 +1793,6 @@ virtio_init_device(struct rte_eth_dev *eth_dev, uint64_t req_features) else eth_dev->data->dev_flags &= ~RTE_ETH_DEV_INTR_LSC; - eth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; - /* Setting up rx_header size for the device */ if (virtio_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF) || virtio_with_feature(hw, VIRTIO_F_VERSION_1) || -- 2.35.0.4.g44a5d4affccf ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/virtio: fix duplicated rxq xstats 2023-11-24 13:52 ` [PATCH] net/virtio: fix duplicated rxq xstats edwin.brossette @ 2023-11-27 10:20 ` Ferruh Yigit 2024-02-06 14:56 ` Maxime Coquelin 1 sibling, 0 replies; 3+ messages in thread From: Ferruh Yigit @ 2023-11-27 10:20 UTC (permalink / raw) To: edwin.brossette, dev; +Cc: maxime.coquelin, olivier.matz, stable On 11/24/2023 1:52 PM, edwin.brossette@6wind.com wrote: > From: Edwin Brossette <edwin.brossette@6wind.com> > > The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while > moving queue stats from 'struct rte_eth_stats' to the individual pmds, > as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass > auto-filled queue xstats"). > > This flag was added so every pmd would keep its original behavior until > the change was implemented. However, this flag was not removed > afterwards in the virtio pmd and as a result, some queue stats are > displayed twice when trying to get them: once in lib_rte_ethdev, and a > second time in the virtio pmd. > > Remove this flag so stats are printed only once. > > Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") > Cc: stable@dpdk.org > > Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com> > Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/virtio: fix duplicated rxq xstats 2023-11-24 13:52 ` [PATCH] net/virtio: fix duplicated rxq xstats edwin.brossette 2023-11-27 10:20 ` Ferruh Yigit @ 2024-02-06 14:56 ` Maxime Coquelin 1 sibling, 0 replies; 3+ messages in thread From: Maxime Coquelin @ 2024-02-06 14:56 UTC (permalink / raw) To: edwin.brossette, dev; +Cc: ferruh.yigit, olivier.matz, stable On 11/24/23 14:52, edwin.brossette@6wind.com wrote: > From: Edwin Brossette <edwin.brossette@6wind.com> > > The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while > moving queue stats from 'struct rte_eth_stats' to the individual pmds, > as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass > auto-filled queue xstats"). > > This flag was added so every pmd would keep its original behavior until > the change was implemented. However, this flag was not removed > afterwards in the virtio pmd and as a result, some queue stats are > displayed twice when trying to get them: once in lib_rte_ethdev, and a > second time in the virtio pmd. > > Remove this flag so stats are printed only once. > > Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") > Cc: stable@dpdk.org > > Signed-off-by: Edwin Brossette <edwin.brossette@6wind.com> > --- > drivers/net/virtio/virtio_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > Applied to next-virtio tree. Thanks, Maxime ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-06 14:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CANDF9xARG2SvzRRK_3+8RK2SCP_Zj7DggOtPmnNDR9sWmr-j5Q@mail.gmail.com> 2023-11-24 13:52 ` [PATCH] net/virtio: fix duplicated rxq xstats edwin.brossette 2023-11-27 10:20 ` Ferruh Yigit 2024-02-06 14:56 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).