From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3BF3433F5 for ; Wed, 29 Nov 2023 03:33:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE59942E1C; Wed, 29 Nov 2023 03:33:01 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id 90A1142E18 for ; Wed, 29 Nov 2023 03:33:00 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40b34563987so2274695e9.1 for ; Tue, 28 Nov 2023 18:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701225180; x=1701829980; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hnhkk8Mo7m653LQHe0GNuHhd8yqCWgG5u7/naq2xD88=; b=ku1/YzRjSyrtlr2+rzInV1iJ/YwEPOgbumBKnkozoSqvIdrQe3U3PNISYGnHDUVPTZ 5FjwGFWox0XHstlofDmXSwuqRhpOHzP4gW1ZssL6/6h9zH5DEQwRNs6KMeYLZZjVe1Aq 4F2zPa0TNvm3GCRW5rPLzC6BLjYEHLC1sMLHVf5I6wjJmU0I3AIZ873ws1To3woqVfgP AhzClO6j332CA0m0D/PbC22gG9D5mmLVdytOWry/VchFH31Uee941E4eymBWRb+M+CWb CI/ZibEYKn+EWLyEL5MIoYObYw9B38T2uZVZLiJm0KVj8go6gUwTnJiBXi4Jj6LmyxgA Yvow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701225180; x=1701829980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hnhkk8Mo7m653LQHe0GNuHhd8yqCWgG5u7/naq2xD88=; b=QI40+wyH6lBhEuUNaSZgY48jLKFyX8CGp1ChNTfYNySwmT9BgJ3ADOs/hR3uN4VGVr IbuQuEPxq1sraYITutmwcj+SH2Az8Bd+ha45IunKdVUNB+hziPJdQon9WOL3QywKz4xq f+1PC2aP4jLFRDx4t7qOzg/xmzCCq91OQUCLAjFBqzcVHXq4cTc18PUkvp+i+JMZEh9P OoRA4VBa0R6tZnACu1p16pNYU+/xuIrxbcNLfzkaqsthyqzYQC8+VKBz+TkgIKbBXOn4 tq8IlYUO3nTVpZcne1alRuCa19BnisDPK3+BI2maPR9CMjLHuE3RqNItpHBjp2rJrs+B 7lQw== X-Gm-Message-State: AOJu0Yw+utZbF2XkruUJTTajFl7MJKQf3yQy+2c3RL+aezgASeqfZntD VgkEFN65UPiNN1uiRsN3EBY= X-Google-Smtp-Source: AGHT+IH3dXKsDqJCyESmLmUQjThrztg/yMBbYKLGq8HTqESn37beOl/P5pvN/l8MSQdIG5+QZ9cwTg== X-Received: by 2002:a05:600c:1c89:b0:3fe:d67d:5040 with SMTP id k9-20020a05600c1c8900b003fed67d5040mr18275666wms.5.1701225179953; Tue, 28 Nov 2023 18:32:59 -0800 (PST) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id f17-20020a05600c155100b004083729fc14sm363775wmg.20.2023.11.28.18.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 18:32:59 -0800 (PST) From: luca.boccassi@gmail.com To: David Marchand Cc: Bruce Richardson , dpdk stable Subject: patch 'doc: fix some ordered lists' has been queued to stable release 20.11.10 Date: Wed, 29 Nov 2023 02:32:47 +0000 Message-Id: <20231129023251.1780959-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231129023251.1780959-1-luca.boccassi@gmail.com> References: <20231123161709.670852-9-luca.boccassi@gmail.com> <20231129023251.1780959-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/11b2f328f49fb7abc4b0e39f275d301af5fe4696 Thanks. Luca Boccassi --- >From 11b2f328f49fb7abc4b0e39f275d301af5fe4696 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 10 Nov 2023 11:15:05 +0100 Subject: [PATCH] doc: fix some ordered lists [ upstream commit fc7428ead4ee6e1239ccd0bd4065edd974549ad6 ] Ordered lists must start preceded by an empty line. Entries must be separated by an empty line (as per our coding style). Incorrectly indented lines are seen as a separator and result in starting a new list in the rendered doc. Fix issues in some guides. Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") Fixes: 9dcf5d15569b ("doc: clarify path selection in virtio guide") Fixes: 68a03efeed65 ("doc: add Marvell cnxk platform guide") Fixes: f6010c7655cc ("doc: add GSO programmer's guide") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- doc/guides/nics/virtio.rst | 12 ++++++++++++ doc/guides/platform/octeontx2.rst | 3 +++ .../prog_guide/generic_segmentation_offload_lib.rst | 2 +- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst index 30a99be534..1922e1b444 100644 --- a/doc/guides/nics/virtio.rst +++ b/doc/guides/nics/virtio.rst @@ -301,6 +301,7 @@ Prerequisites for Rx interrupts ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ To support Rx interrupts, + #. Check if guest kernel supports VFIO-NOIOMMU: Linux started to support VFIO-NOIOMMU since 4.8.0. Make sure the guest @@ -463,12 +464,16 @@ according to below configuration: #. Split virtqueue mergeable path: If Rx mergeable is negotiated, in-order feature is not negotiated, this path will be selected. + #. Split virtqueue non-mergeable path: If Rx mergeable and in-order feature are not negotiated, also Rx offload(s) are requested, this path will be selected. + #. Split virtqueue in-order mergeable path: If Rx mergeable and in-order feature are both negotiated, this path will be selected. + #. Split virtqueue in-order non-mergeable path: If in-order feature is negotiated and Rx mergeable is not negotiated, this path will be selected. + #. Split virtqueue vectorized Rx path: If Rx mergeable is disabled and no Rx offload requested, this path will be selected. @@ -477,16 +482,21 @@ according to below configuration: #. Packed virtqueue mergeable path: If Rx mergeable is negotiated, in-order feature is not negotiated, this path will be selected. + #. Packed virtqueue non-mergeable path: If Rx mergeable and in-order feature are not negotiated, this path will be selected. + #. Packed virtqueue in-order mergeable path: If in-order and Rx mergeable feature are both negotiated, this path will be selected. + #. Packed virtqueue in-order non-mergeable path: If in-order feature is negotiated and Rx mergeable is not negotiated, this path will be selected. + #. Packed virtqueue vectorized Rx path: If building and running environment support AVX512 && in-order feature is negotiated && Rx mergeable is not negotiated && TCP_LRO Rx offloading is disabled && vectorized option enabled, this path will be selected. + #. Packed virtqueue vectorized Tx path: If building and running environment support AVX512 && in-order feature is negotiated && vectorized option enabled, this path will be selected. @@ -564,5 +574,7 @@ or configuration, below steps can help you identify which path you selected and root cause faster. #. Run vhost/virtio test case; + #. Run "perf top" and check virtio Rx/Tx callback names; + #. Identify which virtio path is selected refer to above table. diff --git a/doc/guides/platform/octeontx2.rst b/doc/guides/platform/octeontx2.rst index f7b5fdf22a..9640d39b75 100644 --- a/doc/guides/platform/octeontx2.rst +++ b/doc/guides/platform/octeontx2.rst @@ -104,7 +104,9 @@ where even VF bound to the first domain and odd VF bound to the second domain. Typical application usage models are, #. Communication between the Linux kernel and DPDK application. + #. Exception path to Linux kernel from DPDK application as SW ``KNI`` replacement. + #. Communication between two different DPDK applications. SDP interface @@ -123,6 +125,7 @@ can bind PF or VF to use SDP interface and it will be enumerated as ethdev ports The primary use case for SDP is to enable the smart NIC use case. Typical usage models are, #. Communication channel between remote host and OCTEON TX2 SoC over PCIe. + #. Transfer packets received from network interface to remote host over PCIe and vice-versa. diff --git a/doc/guides/prog_guide/generic_segmentation_offload_lib.rst b/doc/guides/prog_guide/generic_segmentation_offload_lib.rst index ad91c6e5fc..ad2a8d04bb 100644 --- a/doc/guides/prog_guide/generic_segmentation_offload_lib.rst +++ b/doc/guides/prog_guide/generic_segmentation_offload_lib.rst @@ -204,7 +204,7 @@ To segment an outgoing packet, an application must: - a flag, that indicates whether the IPv4 headers of output segments should contain fixed or incremental ID values. -2. Set the appropriate ol_flags in the mbuf. +#. Set the appropriate ol_flags in the mbuf. - The GSO library use the value of an mbuf's ``ol_flags`` attribute to determine how a packet should be segmented. It is the application's -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-29 02:31:24.876054114 +0000 +++ 0002-doc-fix-some-ordered-lists.patch 2023-11-29 02:31:24.785770721 +0000 @@ -1 +1 @@ -From fc7428ead4ee6e1239ccd0bd4065edd974549ad6 Mon Sep 17 00:00:00 2001 +From 11b2f328f49fb7abc4b0e39f275d301af5fe4696 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fc7428ead4ee6e1239ccd0bd4065edd974549ad6 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ - doc/guides/platform/cnxk.rst | 3 +++ + doc/guides/platform/octeontx2.rst | 3 +++ @@ -28 +29 @@ -index ba6247170d..c22ce56a02 100644 +index 30a99be534..1922e1b444 100644 @@ -31 +32 @@ -@@ -217,6 +217,7 @@ Prerequisites for Rx interrupts +@@ -301,6 +301,7 @@ Prerequisites for Rx interrupts @@ -39 +40 @@ -@@ -379,12 +380,16 @@ according to below configuration: +@@ -463,12 +464,16 @@ according to below configuration: @@ -56 +57 @@ -@@ -393,16 +398,21 @@ according to below configuration: +@@ -477,16 +482,21 @@ according to below configuration: @@ -71,2 +72,2 @@ - (AVX512 || NEON) && in-order feature is negotiated && Rx mergeable - is not negotiated && TCP_LRO Rx offloading is disabled && vectorized option enabled, + AVX512 && in-order feature is negotiated && Rx mergeable is not negotiated && + TCP_LRO Rx offloading is disabled && vectorized option enabled, @@ -76 +77 @@ - (AVX512 || NEON) && in-order feature is negotiated && vectorized option enabled, + AVX512 && in-order feature is negotiated && vectorized option enabled, @@ -78 +79 @@ -@@ -480,5 +490,7 @@ or configuration, below steps can help you identify which path you selected and +@@ -564,5 +574,7 @@ or configuration, below steps can help you identify which path you selected and @@ -86,5 +87,5 @@ -diff --git a/doc/guides/platform/cnxk.rst b/doc/guides/platform/cnxk.rst -index b3aa4de09d..b901062c93 100644 ---- a/doc/guides/platform/cnxk.rst -+++ b/doc/guides/platform/cnxk.rst -@@ -113,7 +113,9 @@ where even VF bound to the first domain and odd VF bound to the second domain. +diff --git a/doc/guides/platform/octeontx2.rst b/doc/guides/platform/octeontx2.rst +index f7b5fdf22a..9640d39b75 100644 +--- a/doc/guides/platform/octeontx2.rst ++++ b/doc/guides/platform/octeontx2.rst +@@ -104,7 +104,9 @@ where even VF bound to the first domain and odd VF bound to the second domain. @@ -100 +101 @@ -@@ -132,6 +134,7 @@ can bind PF or VF to use SDP interface and it will be enumerated as ethdev ports +@@ -123,6 +125,7 @@ can bind PF or VF to use SDP interface and it will be enumerated as ethdev ports @@ -103 +104 @@ - #. Communication channel between remote host and cnxk SoC over PCIe. + #. Communication channel between remote host and OCTEON TX2 SoC over PCIe. @@ -109 +110 @@ -index e605b86376..30d13bcc61 100644 +index ad91c6e5fc..ad2a8d04bb 100644