From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CE6E433F5 for ; Wed, 29 Nov 2023 03:33:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4497642E18; Wed, 29 Nov 2023 03:33:05 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id C9F8042E27 for ; Wed, 29 Nov 2023 03:33:03 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-40b4c2ef5cdso11456885e9.2 for ; Tue, 28 Nov 2023 18:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701225183; x=1701829983; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CX5K3f11OjCVxx0kiPUDdcYBFv1RrctlwnPFRuGWwW8=; b=RscfpxBVy2Yxi+hDvQmfO7FnoG/O+JCYSlDfh9shSHk4LNsN5omFPP3rpJ68VWxvAq QNimg4FsI/I8lmVZyU8/dLt6Qg5kZiKbaNGIHGMSwrC7c+a9DJES55M2yrws3mQ1PCSq yj5XZymYWvCtZqAB0A2QeUK0BAnNfXq3utYKL/xvaFdghXpUkrIZom9lOKiJ3PXkQCew 0q9s+jLctehC9fwzTh1dD9HfO9/xU/7kZQPjAUkkRWzZnhVR/4Ia5sSJ7oA9huNN5jwS CTQnnAKJHNqdB7Hptkprhey9L3FtXUMDJFm1o9NJwR2xGZooKaQTadbM+TNiD77aiQ2D CQGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701225183; x=1701829983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CX5K3f11OjCVxx0kiPUDdcYBFv1RrctlwnPFRuGWwW8=; b=Nyt3ZHk2wG0HopMMbazKHyq9LGhkRB3Fqnl+YLQ27AZw1HYezm/lrEZtDAodg3tHZo hpl1seykMofPRrEdvX2OryIo7wBquVUmSrgQ0TXfdI5eQeKn2fdDnjK9zcojtomd4U/Y udu+zxj9VBoocNfRvQFaZjTQ5Ky0gMNlrcGaTfKFBMavEeWmkJaQ0TMkYouHiFi7GKH7 CfaRM93v9DUjbIfJ1pZzpWiXmVkbJ4KC08xL1nOv04hoU4vtKY5Kg/kOXxxYgRldEZRI RmgNnGQ80QchuD8mfLq8k/R2jIPKS7JwhjYwnLj2Iew7/fnngF706HQbIqRPnlVtR3Jd kEwA== X-Gm-Message-State: AOJu0YyPzYbtTRwonz8CUwPKSv9Ek4/6qHl4+PJ4a+RHu5EkFYEYGZBK ilmfx/imNsxcVhqhPEW6SS3jcY19MWJTk0RG X-Google-Smtp-Source: AGHT+IGSkOTBEtGziKfQJ3B5dtr2IiVmiqyTyLbt5z5yI5kp1I47ECs/yT9et+O9p+dSMU+7aBXI1A== X-Received: by 2002:a05:600c:4f82:b0:40b:2b42:a1c9 with SMTP id n2-20020a05600c4f8200b0040b2b42a1c9mr11788996wmq.23.1701225183137; Tue, 28 Nov 2023 18:33:03 -0800 (PST) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c4e8f00b0040b3632e993sm356046wmq.46.2023.11.28.18.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 18:33:02 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Mahesh Adulla , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Huisong Li , dpdk stable Subject: patch 'mempool: fix get function documentation' has been queued to stable release 20.11.10 Date: Wed, 29 Nov 2023 02:32:49 +0000 Message-Id: <20231129023251.1780959-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231129023251.1780959-1-luca.boccassi@gmail.com> References: <20231123161709.670852-9-luca.boccassi@gmail.com> <20231129023251.1780959-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/714ae833955ef08138ad7fba5dfd58e73b97466d Thanks. Luca Boccassi --- >From 714ae833955ef08138ad7fba5dfd58e73b97466d Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 23 Oct 2023 10:38:42 +0100 Subject: [PATCH] mempool: fix get function documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 9b3233ab09ea331dcf5fb38d215d91818bef3b47 ] static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the internal function documentation for return value. Fixes: af75078fece3 ("first public release") Reported-by: Mahesh Adulla Signed-off-by: Ferruh Yigit Reviewed-by: Morten Brørup Acked-by: Huisong Li --- lib/librte_mempool/rte_mempool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h index 19cfcd4db7..10c023b93f 100644 --- a/lib/librte_mempool/rte_mempool.h +++ b/lib/librte_mempool/rte_mempool.h @@ -1402,7 +1402,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj) * @param cache * A pointer to a mempool cache structure. May be NULL if not needed. * @return - * - >=0: Success; number of objects supplied. + * - 0: Success. * - <0: Error; code of driver dequeue function. */ static __rte_always_inline int -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-11-29 02:31:24.963853170 +0000 +++ 0004-mempool-fix-get-function-documentation.patch 2023-11-29 02:31:24.789770801 +0000 @@ -1 +1 @@ -From 9b3233ab09ea331dcf5fb38d215d91818bef3b47 Mon Sep 17 00:00:00 2001 +From 714ae833955ef08138ad7fba5dfd58e73b97466d Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 9b3233ab09ea331dcf5fb38d215d91818bef3b47 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -25,21 +26,8 @@ - .mailmap | 1 + - lib/mempool/rte_mempool.h | 2 +- - 2 files changed, 2 insertions(+), 1 deletion(-) - -diff --git a/.mailmap b/.mailmap -index 49d3616c4c..3630e72f41 100644 ---- a/.mailmap -+++ b/.mailmap -@@ -839,6 +839,7 @@ Maciej Rabeda - Maciej Szwed - Madhu Chittim - Madhuker Mythri -+Mahesh Adulla - Mahipal Challa - Mah Yock Gen - Mairtin o Loingsigh -diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h -index df87cd231e..1303eef494 100644 ---- a/lib/mempool/rte_mempool.h -+++ b/lib/mempool/rte_mempool.h -@@ -1484,7 +1484,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj) + lib/librte_mempool/rte_mempool.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h +index 19cfcd4db7..10c023b93f 100644 +--- a/lib/librte_mempool/rte_mempool.h ++++ b/lib/librte_mempool/rte_mempool.h +@@ -1402,7 +1402,7 @@ rte_mempool_put(struct rte_mempool *mp, void *obj)