From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C611243699 for ; Thu, 7 Dec 2023 12:21:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C071042EEA; Thu, 7 Dec 2023 12:21:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 83FC14025C for ; Thu, 7 Dec 2023 12:21:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701948092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syr5GH6aCQhBZVX4iTD3kITKxiGsJ8dId33SHVF8XJo=; b=JARwnr3yT4DJu2WFtRzCdSI1bf7bndZqb5mnB/ozJ57eD3zNyjoVyg10ys79OwbvQDizof lAntSA6hf7G5D9M4tSs3MCARr5HQIwaskeMiaoz1A6m5D4XQNrprAO0PqMF2b3mR7biGfH 3UqpmKfnN6Rq0QG6qeZOT611TPR8ck0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-cwx7FAT9MLijHOGr6i6mNA-1; Thu, 07 Dec 2023 06:21:29 -0500 X-MC-Unique: cwx7FAT9MLijHOGr6i6mNA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A7E33101A555; Thu, 7 Dec 2023 11:21:28 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id B78E1C15880; Thu, 7 Dec 2023 11:21:27 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Jie Hai , dpdk stable Subject: patch 'doc: fix RSS flow description in hns3 guide' has been queued to stable release 21.11.6 Date: Thu, 7 Dec 2023 11:20:56 +0000 Message-ID: <20231207112116.769502-4-ktraynor@redhat.com> In-Reply-To: <20231207112116.769502-1-ktraynor@redhat.com> References: <20231207112116.769502-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/12/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/384083681747bd3936e81e633a9176e8105ddc31 Thanks. Kevin --- >From 384083681747bd3936e81e633a9176e8105ddc31 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Mon, 20 Nov 2023 19:14:04 +0800 Subject: [PATCH] doc: fix RSS flow description in hns3 guide [ upstream commit 9036f9fef8ed7002ba45d78ef1e5c604dfc9948a ] The hns3 driver supports for creating rule base on input tuple, hash key, queues and hash algorithm. But hash key, queues and hash algorithm are the global configuration for hardware which will affect other rules. The rule just setting input tuple is completely independent. Fixes: 63a0f65c9572 ("doc: add more description in hns3 guide") Signed-off-by: Huisong Li Acked-by: Jie Hai --- doc/guides/nics/hns3.rst | 42 ++++++++++++++++++++++++++-------------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst index d4ca2b718c..380024600b 100644 --- a/doc/guides/nics/hns3.rst +++ b/doc/guides/nics/hns3.rst @@ -213,34 +213,48 @@ Generic flow API - ``RSS Flow`` - RSS Flow supports to set hash input set, hash function, enable hash - and configure queues. - For example: - Configure queues as queue 0, 1, 2, 3. + RSS Flow supports for creating rule base on input tuple, hash key, queues + and hash algorithm. But hash key, queues and hash algorithm are the global + configuration for hardware which will affect other rules. + The rule just setting input tuple is completely independent. + + Run ``testpmd``: .. code-block:: console - testpmd> flow create 0 ingress pattern end actions rss types end \ - queues 0 1 2 3 end / end + dpdk-testpmd -a 0000:7d:00.0 -l 10-18 -- -i --rxq=8 --txq=8 + + All IP packets can be distributed to 8 queues. - Enable hash and set input set for IPv4-TCP. + Set IPv4-TCP packet is distributed to 8 queues based on L3/L4 SRC only. .. code-block:: console - testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \ - actions rss types ipv4-tcp l3-src-only end queues end / end + testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions \ + rss types ipv4-tcp l4-src-only l3-src-only end queues end / end - Set symmetric hash enable for flow type IPv4-TCP. + Disable IPv4 packet RSS hash. .. code-block:: console - testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end \ - actions rss types ipv4-tcp end queues end func symmetric_toeplitz / end + testpmd> flow create 0 ingress pattern eth / ipv4 / end actions rss \ + types none end queues end / end - Set hash function as simple xor. + Set hash function as symmetric Toeplitz. .. code-block:: console testpmd> flow create 0 ingress pattern end actions rss types end \ - queues end func simple_xor / end + queues end func symmetric_toeplitz / end + + In this case, all packets that enabled RSS are hashed using symmetric + Toeplitz algorithm. + + Flush all RSS rules + + .. code-block:: console + + testpmd> flow flush 0 + + The RSS configurations of hardwre is back to the one ethdev ops set. Statistics -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-07 11:18:59.732936414 +0000 +++ 0004-doc-fix-RSS-flow-description-in-hns3-guide.patch 2023-12-07 11:18:59.611873873 +0000 @@ -1 +1 @@ -From 9036f9fef8ed7002ba45d78ef1e5c604dfc9948a Mon Sep 17 00:00:00 2001 +From 384083681747bd3936e81e633a9176e8105ddc31 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9036f9fef8ed7002ba45d78ef1e5c604dfc9948a ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3703987309..3b0613fc1b 100644 +index d4ca2b718c..380024600b 100644 @@ -24 +25 @@ -@@ -240,34 +240,48 @@ Generic flow API +@@ -213,34 +213,48 @@ Generic flow API