From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C601843699 for ; Thu, 7 Dec 2023 12:21:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87D1F42EF8; Thu, 7 Dec 2023 12:21:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 395FD4025C for ; Thu, 7 Dec 2023 12:21:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701948097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FapG1yujVdfOREgsUhI5DBcXwZPPV+4SfMpwkx3tZ6U=; b=AJq+Z3K0d3ijcxHXWWsbrmD/D0U63DBlxPkbK0OC4dO52psodx95nij/PieUKSr+k9MVO7 JFm5ffgZRhy7vRN8S40gF0+uAEHXQ0Jsyi36nmlFdggXbVumLdBDKCDOU3Pqjk1nYhYDQW vl2x3ITgWBfjo1LTXgp5UFCypzxEqE4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-POdL2D7ROby5oIKaSHBhFw-1; Thu, 07 Dec 2023 06:21:34 -0500 X-MC-Unique: POdL2D7ROby5oIKaSHBhFw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E48E1C0BB41; Thu, 7 Dec 2023 11:21:34 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5480BC15A0C; Thu, 7 Dec 2023 11:21:33 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'pdump: fix error number on IPC response' has been queued to stable release 21.11.6 Date: Thu, 7 Dec 2023 11:21:00 +0000 Message-ID: <20231207112116.769502-8-ktraynor@redhat.com> In-Reply-To: <20231207112116.769502-1-ktraynor@redhat.com> References: <20231207112116.769502-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/12/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c9a8aa95deb8b31cf7744828dd4778840b83a615 Thanks. Kevin --- >From c9a8aa95deb8b31cf7744828dd4778840b83a615 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 17 Nov 2023 08:35:55 -0800 Subject: [PATCH] pdump: fix error number on IPC response MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pdump/rte_pdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 805d12236c..3b3618bc3a 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -564,7 +564,8 @@ pdump_prepare_client_request(const char *device, uint16_t queue, mp_rep = &mp_reply.msgs[0]; resp = (struct pdump_response *)mp_rep->param; - rte_errno = resp->err_value; - if (!resp->err_value) + if (resp->err_value == 0) ret = 0; + else + rte_errno = -resp->err_value; free(mp_reply.msgs); } -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-07 11:18:59.817145456 +0000 +++ 0008-pdump-fix-error-number-on-IPC-response.patch 2023-12-07 11:18:59.618873896 +0000 @@ -1 +1 @@ -From 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 Mon Sep 17 00:00:00 2001 +From c9a8aa95deb8b31cf7744828dd4778840b83a615 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 80b90c6f7d..e94f49e212 100644 +index 805d12236c..3b3618bc3a 100644 @@ -27 +28 @@ -@@ -565,7 +565,8 @@ pdump_prepare_client_request(const char *device, uint16_t queue, +@@ -564,7 +564,8 @@ pdump_prepare_client_request(const char *device, uint16_t queue,