From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38ABA433D8 for ; Mon, 11 Dec 2023 11:19:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3373740ED2; Mon, 11 Dec 2023 11:19:47 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2067.outbound.protection.outlook.com [40.107.93.67]) by mails.dpdk.org (Postfix) with ESMTP id 812B640E0F for ; Mon, 11 Dec 2023 11:19:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WfHHwxUEXtWZ76Hp7MCK1xgBHE4vrqm0d3AjypjDi7BIGDHhEUzD5klZBNB+yBY9XgJ82QQXt+jRq+eEgwvr0vsMGRxLHXZvKW7cUCICcgJFlubx8jWH220xEATbYtNCls7wSc16z5qt0+pp2qhFnBlBfZQcCJg9mBvbE4ULUVhGQp0FJzTNaCaPPr28E3gWGYzhN3HmoX4ctSTP9loVJEW3zH4JSVhrBMuMI7cMp4gyW+9Kuz0rJYyqFJXhcIp+/bebpCtmQurDVuK4eD9veC9o624YuAJbP6Ytltu+x7+L7KYX4+D9CS7Rg0gHy08GANdiqHcjhkoEXYDqwevw5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLvfboFfe5ilrJrIPvwpe4ck1Wcea4tv4DqLLJTzdAo=; b=V/83K4vHt057HnHHNiipu8cMCsZ3uT8mOSgmBA14t/c/ilwVUqvjNeQBL9wrr2xtFrnjqv1Z27R/gkmz6lYpr+A/P6Y7uRcQaT4D7uRTiReQ2dWS+91qNbpNF4aNVyQU3Ze7Sfn6NFSejXk0s7hncl2+euJSzJAGpXY/YEzYKJx4XfC+dwHOlncAE3lxoel23VXzMLbrpUzlPkhLtTXEBvbI0FIob7wRv7J9obQR5jp5M1DTY/keVkiP7yArkhS72mdVxWZ35ga6pgIzHx7REVBSkSXTC3q9ktUH25CINf9enTdu4Zb+kUry3GUcb+AVs5u8odMmk5ZUKO/xsqzbKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lLvfboFfe5ilrJrIPvwpe4ck1Wcea4tv4DqLLJTzdAo=; b=bzbPlyOuxhAdYW8nNrr+cTr21Q0CORzMhdi8RJYZJj+nqZjeStFE9R1V0zcNs/Fc1kPXA0iJEGgseEXpnbyFhcZN5560d04Y7AmGG5ZeUzwmkiaUnuydeOE+rJmSloGE+QtuEZmdGJ3mZDgRvIT+50c9InL19qckOioqChBBFAusYrW8Xm++yu6qQbEEmB5DGn5ZflwttawYqZXdD9PXNWGC+8TnU0rP+JzwTDi0nFK6GjotHxktQPKM1zHTMs91sQkHnLjC/Pb6qdSVJR7klChDCI7aOPhm4CB1TS3Sd493FxTrAYqVXCp4A6rs5YY++/MTUCpMxErgkcu03guU7Q== Received: from CY5PR10CA0028.namprd10.prod.outlook.com (2603:10b6:930:1c::21) by MN0PR12MB5884.namprd12.prod.outlook.com (2603:10b6:208:37c::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:19:44 +0000 Received: from CY4PEPF0000EE3C.namprd03.prod.outlook.com (2603:10b6:930:1c:cafe::21) by CY5PR10CA0028.outlook.office365.com (2603:10b6:930:1c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33 via Frontend Transport; Mon, 11 Dec 2023 10:19:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE3C.mail.protection.outlook.com (10.167.242.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:19:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:19:32 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:19:30 -0800 From: Xueming Li To: Huisong Li CC: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: remove useless check in TSO command' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:42 +0800 Message-ID: <20231211101226.2122-78-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3C:EE_|MN0PR12MB5884:EE_ X-MS-Office365-Filtering-Correlation-Id: 333db168-772e-41eb-8bea-08dbfa32b119 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: olyyn+iszO4yjyNntr/3o/JdMpl2Uh5JVXke71AO0E+pRnFiFj9zClMBVEmE2YlIultc/D8CGo6T4Vs6d8JL2COv3C2+XvaTDLExB0WgY2yd1kKUMRTXxrWhDTKPMXDrukw/Ace4nJJYw6Qdfi7Tc6MrO3RdoYm4WInLSDH/hV9quexTmXgw3aRL7V/PGqKZ/JRAMxYMKHETodz23ett279hnb7dlmN+VfQt4/frthFoFXmn2vQm6I1boeI2WykEEGs7S/hiUL+5DYa4tbdMCo8ELObx9i0oxmn3O0sFVfv08DY1vSRhp6lLTxhss6xCZ1uzx+uEqF5VguHJZlx67JGnnJnql6sVeTueRfEcU8JzFz+EPIS+GmjfKYjbDBPPRpyJ5pla3n3G+fqAefJfGGBPoqDzYe/91OOHH3ZqSJsGOPWMDM5rIG3VAGAN2FBe8fNzYmJz6hy4ndBK5K/goSHsx15dIBsg4mUBIuBFeEWSYfBevi8OuOKbdpXYTK9oulL94GDBHXQYMXJF30628lJ6kv5xqJVXH4fodN3qoIFfppjb+JZFgBnKGo2oRmzX1xMgLKMFdGji1DUnQxeYEAs5DLXqGKkMJJ245IgKvzUZ1lOn5k8DfeJjS/eFevEvVGAfOtyTRWQnKFPy+EO86RpiB7PvW7+TSnvORGUQCJ3eLt5/hqNOwZOwvc32ML4iz90D2/Z1h15To1dA7Z6IuSlDKKlfAIxLs1PlhX56bmB8A71h/Vt476fLarbVG7fc/Bdf/zvCK6v12n7ARsD0spDK5ZkI/DQkMNfwu6CZno5azWUFeMUqT3VhF3tnmphG3YYMjY3JDfT2vLZvB3SuhA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(230173577357003)(230273577357003)(451199024)(1800799012)(186009)(82310400011)(64100799003)(40470700004)(36840700001)(46966006)(83380400001)(2906002)(82740400003)(478600001)(356005)(41300700001)(4001150100001)(7636003)(55016003)(70206006)(70586007)(54906003)(6916009)(426003)(966005)(40480700001)(316002)(6666004)(86362001)(7696005)(4326008)(8936002)(8676002)(53546011)(40460700003)(36756003)(1076003)(47076005)(6286002)(5660300002)(36860700001)(26005)(336012)(2616005)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:19:42.8201 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 333db168-772e-41eb-8bea-08dbfa32b119 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5884 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=5508c2d500628bc85aaa83060ea07d6b80075077 Thanks. Xueming Li --- >From 5508c2d500628bc85aaa83060ea07d6b80075077 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Tue, 7 Nov 2023 12:11:16 +0800 Subject: [PATCH] app/testpmd: remove useless check in TSO command Cc: Xueming Li [ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] Testpmd has added the check of TSO offload capability of port, please see the commit 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") So the code following the check code memtioned above to display warning when port doesn't support TSO offload doesn't access to forever. Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") Signed-off-by: Huisong Li Acked-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index bfccadbd49..d24d16c7e0 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -4893,19 +4893,6 @@ cmd_tso_set_parsed(void *parsed_result, ports[res->port_id].tso_segsz); } cmd_config_queue_tx_offloads(&ports[res->port_id]); - - /* display warnings if configuration is not supported by the NIC */ - ret = eth_dev_info_get_print_err(res->port_id, &dev_info); - if (ret != 0) - return; - - if ((ports[res->port_id].tso_segsz != 0) && - (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) { - fprintf(stderr, - "Warning: TSO enabled but not supported by port %d\n", - res->port_id); - } - cmd_reconfig_device_queue(res->port_id, 1, 1); } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:25.568715000 +0800 +++ 0077-app-testpmd-remove-useless-check-in-TSO-command.patch 2023-12-11 17:56:23.097652300 +0800 @@ -1 +1 @@ -From 773397f6f4b5e325e786835343bacbc454d1e5f0 Mon Sep 17 00:00:00 2001 +From 5508c2d500628bc85aaa83060ea07d6b80075077 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 773397f6f4b5e325e786835343bacbc454d1e5f0 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 912bf3355c..1c57e07d41 100644 +index bfccadbd49..d24d16c7e0 100644 @@ -25 +27 @@ -@@ -4967,19 +4967,6 @@ cmd_tso_set_parsed(void *parsed_result, +@@ -4893,19 +4893,6 @@ cmd_tso_set_parsed(void *parsed_result,