From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDF1A433D8 for ; Mon, 11 Dec 2023 11:19:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E310642D87; Mon, 11 Dec 2023 11:19:55 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2083.outbound.protection.outlook.com [40.107.212.83]) by mails.dpdk.org (Postfix) with ESMTP id 53A5D40ED2 for ; Mon, 11 Dec 2023 11:19:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Io/QfYoA/fRx7fhddGKb1DlizoEU9594AqHz9qA5y9AOVOlqDqoTroIi8ReZ4ZdBx8SNKZfz/96Z0WNXcGUbtaPWaiPjMsOeHwBZxvATwAjT73peRTbkw5FdUXcKcLOpWR1tEA7NTBEQc6NSivuRnu28sicq7EhO0OaqCGNYDz+pjzm/JaIlHTFUdmJKUtNMg6ZkgjXqkPuCUb81JCKFeHu27HZLE3sBfIRPkA4kq+Zs5ee2+kGdblDdAfX5xLmn0ApGamkSFVJNxt90RKWu074jR5yhdw2KrCkjQilTK89gTHxE0iyNgOkUrIBXcOaqo1RiT7unnFgFVF2hf64sxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OFL3Y+Q09Tu08MDDnKQki2G2Xg8bg6Vp9ppO5FKVxCQ=; b=Hcrpkb1uAKK0Ga8mPsgNIdRukUUuuj7JUC0CgVaLwD9GAjE+TZht+fvgUAz1W3WB0QXVrSzASsTIv/wr6ezjdyuthzWgSxM8IHY0fV0C6kf266CvFefh5q9+DW2dbdN1UTYQ55kqJrCNy35iNI0PtHcNA3DfbuJPYmI/OydVaMgLaL+vcCp5gEaPBGXWtV2zoSciWmWno4NK+hOdiaHNZlRfY+4Nbnatup2O1JXMLaao0l/PnuVciymN6/pSxck9J8uKBCYdB/i9AfhycBZa0lxyELnuo3VL5FF46wrcYl0jLrRvelu83Q8jer6xiK6aSpE+j+NqkKjH/IMWmdPfTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OFL3Y+Q09Tu08MDDnKQki2G2Xg8bg6Vp9ppO5FKVxCQ=; b=eGXAnE282G4K5aNfwSwa1M8k9D6txkj99d6gjDmgW7UJ+Q17nlOFhryutVRy5aoreUvbuMT6bDaTf2lucdfw2wsLZExydgUxA+8kxFXWeTEniVKGq+GYpEsnIpiFwyNwghlaSWRIjTmKq/lnohvy1esGpjFeV5r3sQccKPzPb2Kn5kmgNzUE0QTc9ZBDLs3T3lu0Enw8VLThlbje7fdxPJaQzOwsfoaqV2/dQBYms/zL7fVe5ZOrpEYAUoZERlIUZVhcSmB+nL3cKweKy1whUM3MIJ2Owb/2QNRtenawSxt/ftFakmabb4pbtNmxIbBK5sgc6UHVJLXYhDdNqmDGwQ== Received: from PH8PR15CA0007.namprd15.prod.outlook.com (2603:10b6:510:2d2::10) by DS0PR12MB8245.namprd12.prod.outlook.com (2603:10b6:8:f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:19:52 +0000 Received: from SN1PEPF0002529F.namprd05.prod.outlook.com (2603:10b6:510:2d2:cafe::90) by PH8PR15CA0007.outlook.office365.com (2603:10b6:510:2d2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:19:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002529F.mail.protection.outlook.com (10.167.242.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:19:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:19:34 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:19:32 -0800 From: Xueming Li To: Joshua Washington CC: Rushil Gupta , Andrew Rybchenko , Ajit Khaparde , dpdk stable Subject: patch 'ethdev: account for smaller MTU when setting default' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:43 +0800 Message-ID: <20231211101226.2122-79-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002529F:EE_|DS0PR12MB8245:EE_ X-MS-Office365-Filtering-Correlation-Id: 8112f9b8-18ca-4260-e85c-08dbfa32b675 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RC/LDOvUueRuPx6kbHmWJ5XEjjpKShy6GYnQlAbzNioy1ufWlhDHtSOnmtp+NUooO0C+362K6abe7GdkffmEkMKApcb7Tki8RBpfmbThLjv+otHZqJSGsJ9Et3yROnn70Je3VNxqgQu0BY7agShfhBUyDC07Noq42OHVM9dGzApVZQV8Mr5UM3RzbqkLSOxQzGbG32n2SBeO3gdMoshtRLntJ0mTCYp0+CyHPBkF/VqXkDr8okvSpqWR9cN4uM6/qgRBgGkYlRd1I2K9Q4UUhtEwnAftYRmo2M5KMHBlN9ekvd0/uxFkntZpbupdN2tPmyPe+ZUbMVy8BMxyzCMovPnPS6Y4ufl0vULM+skY/+6OuHC7Q0v+X6ZyFPSi3cg3BLPkC9CUbvNDwT+IJlqpygcksOEm07dH1H1jBTGp78lbAl1PH0XHtM5XU3wzXRBdG2B624ej6y8xSejKru9uXREeeTE1/MPxvavg+hOh17/EWLnkGxU08ji13AUo/ss62TfmEQnf/Psh6EMoxhcq65VB9RAiuMd+alciZmjcqxT/q/iAur9YPVHHjDoZttYeraCBd7vo1JrSvZrZb5IkUcpGdQzGAhE/QjYmopiSw9KrerVp15eKpy+Ka06eKaGMSe+f0v48RdbkEokUMLZ022pHulAMlL/wvzOwZPnpi/WcjfIz0d+eNbH6HbzBt+HxpXoOsSiOkOftv05+tn9WVfiEqXPzdw8PodyQCgOZabIwHh+JRkBh2xIgHlC6BnriKGIr2jDhNePV2nYiVrZPix75+bwVo2swdoARf5zoYSI= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(451199024)(1800799012)(186009)(82310400011)(64100799003)(40470700004)(36840700001)(46966006)(83380400001)(2906002)(82740400003)(478600001)(356005)(41300700001)(4001150100001)(7636003)(55016003)(70206006)(70586007)(54906003)(6916009)(426003)(966005)(40480700001)(15650500001)(316002)(6666004)(86362001)(7696005)(4326008)(8936002)(8676002)(53546011)(40460700003)(36756003)(1076003)(47076005)(6286002)(5660300002)(36860700001)(26005)(336012)(2616005)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:19:51.8140 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8112f9b8-18ca-4260-e85c-08dbfa32b675 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002529F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8245 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=5b8da03c1d206ff0a3d26f4b4062a29f35b10ec4 Thanks. Xueming Li --- >From 5b8da03c1d206ff0a3d26f4b4062a29f35b10ec4 Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Tue, 7 Nov 2023 22:05:34 -0800 Subject: [PATCH] ethdev: account for smaller MTU when setting default Cc: Xueming Li [ upstream commit da266c6556d22b470679484b62e3f9db192e4032 ] Currently, if not specified in the user configuration, rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU. This value could potentially be larger than the MTU that the device supports. This change updates the configured MTU to be the minimum of the maximum supported MTU and the default DPDK MTU. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Signed-off-by: Joshua Washington Signed-off-by: Rushil Gupta Acked-by: Andrew Rybchenko Acked-by: Ajit Khaparde --- lib/ethdev/rte_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 437d04b34e..4f50e2fa80 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1192,7 +1192,9 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, } if (dev_conf->rxmode.mtu == 0) - dev->data->dev_conf.rxmode.mtu = RTE_ETHER_MTU; + dev->data->dev_conf.rxmode.mtu = + (dev_info.max_mtu == 0) ? RTE_ETHER_MTU : + RTE_MIN(dev_info.max_mtu, RTE_ETHER_MTU); ret = eth_dev_validate_mtu(port_id, &dev_info, dev->data->dev_conf.rxmode.mtu); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:25.604314900 +0800 +++ 0078-ethdev-account-for-smaller-MTU-when-setting-default.patch 2023-12-11 17:56:23.097652300 +0800 @@ -1 +1 @@ -From da266c6556d22b470679484b62e3f9db192e4032 Mon Sep 17 00:00:00 2001 +From 5b8da03c1d206ff0a3d26f4b4062a29f35b10ec4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit da266c6556d22b470679484b62e3f9db192e4032 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 9163ef47ea..3858983fcc 100644 +index 437d04b34e..4f50e2fa80 100644 @@ -28 +30 @@ -@@ -1419,7 +1419,9 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, +@@ -1192,7 +1192,9 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,