From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 758D4433D8 for ; Mon, 11 Dec 2023 11:21:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BC1642D83; Mon, 11 Dec 2023 11:21:13 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2070.outbound.protection.outlook.com [40.107.95.70]) by mails.dpdk.org (Postfix) with ESMTP id 46D0940E0F for ; Mon, 11 Dec 2023 11:21:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a7UgSzVV3nPxrKCoz6IqBNuSlfRq6DGMkcl+Wi/mzcmFoIMYiH3qB16d6HDsR5Mq1hKXd4GKQ6DMP/ui1GJLnXidUS7q+mFTT+qwcFgxpgNBWyKDtqP8/pq+CWaWnUyeP0V91lLzeNZ2r0fBApJL9LR8dCOYlv6vt+xlmhu3otRylgLifR5S59fJemdO5sLNQRqlC4zWGVXQOVHzJBTvndUmAgItCbDtzCAmTn+o8YIdKRjD+sWsc/TUBFdA77JGaq6Otl8auEsjwYINbDn56sw9LUpHOktC6TbFya4HUcWdUX+1yEkEycgcSTq3EhJhloHb1jnIlMxSDIqlVG8bfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dBJjxL7K+5LWkB/znOHPcaHOOB3dYJTAx0xHSYV4xeU=; b=HStdC8Oljik3DDmSbTwqzqg7z8CNoyaz6KCq1WLpDn+ZQbUDQYnfOt9jye+eol4sv3eCRG6jU/7g63Fp1p6MM0aRuqP/CA+xT4SwOCwyNuRCVcYhgg2S1A8io4+8C5kIsOqOX53Q6vaSEwkQJzlg0wdj0k+RfKiHSziplEAgmZkpPLcHcxuh7Ave6BvJ9a3Do2Izj5t5ZZHj/s0E5RdcBMN8iEohyxDnuzHt4c4c6MvY3TjQYb30KwA/i5h7bIFpUdKIHETzB7SVPJMgF2e7hq/RnzZYTb/4h2iN7yQeAFvm4OGOWfWUke/He7kVxFDQ2yxsgsfFNrvoOhNR/rxTUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBJjxL7K+5LWkB/znOHPcaHOOB3dYJTAx0xHSYV4xeU=; b=RCH2uQWnTDfsPLICRRiGifRtXsqDl49ohnmLgxyBM0/yHlgJBKJfDwSkkTyefoYGXmFC4AH1iBo5JJBH2F8R/Eic9S8TXF6osluC2AbEBxGEZMYGYWCIly3MaBmp5Q+vxLDMbniZ9zEHYURHuHQ7i2clWA57XqppBpTFz3PNuxq+kLwLY4ltMGxVZBIDARbedp9ol+L5pLe9Mwdrasaom4pyyiPs0+hZCtfnVq0tUJJu0SW5k/6vzHWGrwvOcZQFuD//f1CaXKAaOo5dYPc9zJ5FLqs9oUwt6MjQOgbjhCojXcr+yDmEWfyw5RXGKI/HoQ4Vl1JUvQMUN5OyHF4KGg== Received: from CH5P221CA0021.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::8) by PH7PR12MB6860.namprd12.prod.outlook.com (2603:10b6:510:1b6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:21:08 +0000 Received: from SN1PEPF000252A2.namprd05.prod.outlook.com (2603:10b6:610:1f2:cafe::1c) by CH5P221CA0021.outlook.office365.com (2603:10b6:610:1f2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:21:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF000252A2.mail.protection.outlook.com (10.167.242.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:21:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:20:53 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:20:51 -0800 From: Xueming Li To: Bing Zhao CC: Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix shared Rx queue list management' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:58 +0800 Message-ID: <20231211101226.2122-94-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A2:EE_|PH7PR12MB6860:EE_ X-MS-Office365-Filtering-Correlation-Id: bd7f8bae-f208-4f33-34f4-08dbfa32e3ea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dElIrfacGphZZ3Qseaa27LMm7ayIdzmvsqlMaq/87O03jDamzbr5dzlX+q4OsyIj+DdKOE59Pr3z+nIadm5wx9NymzbjaiJcRw+G/uZkTxLtBrmmszYTGuskmzcdDkKB7PS33fDEhkpcwr/EVFIZ9czMKMvOKJm49MHTRYPS+ATJtPSMySjvkVC6LhXI6SbZPRfGi3MNQQrikf7czRncDycOfNWpZ/LSEThmsfVu+TQnzxrw2HLBNTSRpX/y/SlEaR6k6ZA9ViAAJAKh+SMFa4chrWXu18Ttqkz0w4tZlOWrYqZ0UHtu1wCRjwamdlma1EZSTUxx711zw5l8xdrz8C9/HAFk40KwnM+ZFqX5PgjtgOIoLikrhlMGqVLHXDyCEz9ZhUnAvOTAzPWsF7JxwI7DPnBK07goZsU5q8htZkGRIapnvopI0xYGf0S0c212CgXjuV8F9QjsS7+P1xSEa2b/PEahA3++5VEyMy+HXsSoIEsh8f12jY7/p/6I9zIcHUxXTKz5tRZK/z0ZTVK+Wh5teN7R7rwtf8bNHnmtWQszaKEJiUfW70oh1mA2Ovp0gaeOgJv3UYM8piRKqzsbC87iZd4if+HSlHYaqeYwCop+bQZVvvf2oF7NhLnsChIPyb/0xu0HmvgqouLS6EIAq2A105GnijwwXBCmUuQtE4p5MeXavtYGmgSWKIXVIFfyc6Xe3DoVHkIT+hKLU0DWOX/Le9lAJqyaA86PBsMbt8A6vEzFEvq9v7xDlT42Tbj6D1gPKAE+ImOd82dpFydRK2Tsf+kVPLv4rOg6e9Injsw= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(376002)(39860400002)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(82310400011)(36840700001)(40470700004)(46966006)(55016003)(40480700001)(1076003)(6286002)(336012)(426003)(26005)(16526019)(2616005)(40460700003)(82740400003)(86362001)(7636003)(356005)(36756003)(47076005)(83380400001)(5660300002)(7696005)(36860700001)(53546011)(70586007)(70206006)(316002)(8936002)(8676002)(966005)(6636002)(54906003)(37006003)(2906002)(6862004)(4326008)(4001150100001)(41300700001)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:21:08.0736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd7f8bae-f208-4f33-34f4-08dbfa32e3ea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6860 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=c9e75ba878863c8535670b6137fd6d9380388444 Thanks. Xueming Li --- >From c9e75ba878863c8535670b6137fd6d9380388444 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Mon, 13 Nov 2023 09:24:48 +0200 Subject: [PATCH] net/mlx5: fix shared Rx queue list management Cc: Xueming Li [ upstream commit bcc220cb57d7a2c45703c7215aad2320ac0a1e51 ] In shared Rx queue case, the shared control structure could only be released after the last port's dereference in the group. There is another management list that holding all of the used Rx queues' structures for a port. If the reference count of a control structure is changed to zero during port close, it can be removed from the list directly without freeing the resource. Fixes: 09c2555303be ("net/mlx5: support shared Rx queue") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 6b2af87cd2..834707ea87 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2277,6 +2277,7 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) RTE_ETH_QUEUE_STATE_STOPPED; } } else { /* Refcnt zero, closing device. */ + LIST_REMOVE(rxq_ctrl, next); LIST_REMOVE(rxq, owner_entry); if (LIST_EMPTY(&rxq_ctrl->owners)) { if (!rxq_ctrl->is_hairpin) @@ -2284,7 +2285,6 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) (&rxq_ctrl->rxq.mr_ctrl.cache_bh); if (rxq_ctrl->rxq.shared) LIST_REMOVE(rxq_ctrl, share_entry); - LIST_REMOVE(rxq_ctrl, next); mlx5_free(rxq_ctrl); } dev->data->rx_queues[idx] = NULL; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:26.105760100 +0800 +++ 0093-net-mlx5-fix-shared-Rx-queue-list-management.patch 2023-12-11 17:56:23.197652300 +0800 @@ -1 +1 @@ -From bcc220cb57d7a2c45703c7215aad2320ac0a1e51 Mon Sep 17 00:00:00 2001 +From c9e75ba878863c8535670b6137fd6d9380388444 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit bcc220cb57d7a2c45703c7215aad2320ac0a1e51 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 88b2dc54b3..2c51af11c7 100644 +index 6b2af87cd2..834707ea87 100644 @@ -27 +29 @@ -@@ -2280,6 +2280,7 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) +@@ -2277,6 +2277,7 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) @@ -35 +37 @@ -@@ -2287,7 +2288,6 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx) +@@ -2284,7 +2285,6 @@ mlx5_rxq_release(struct rte_eth_dev *dev, uint16_t idx)