From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3630E43810
for <public@inbox.dpdk.org>; Thu, 4 Jan 2024 02:04:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2FFF04114B;
Thu, 4 Jan 2024 02:04:04 +0100 (CET)
Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com
[209.85.167.182])
by mails.dpdk.org (Postfix) with ESMTP id 79469402BF
for <stable@dpdk.org>; Thu, 4 Jan 2024 02:04:01 +0100 (CET)
Received: by mail-oi1-f182.google.com with SMTP id
5614622812f47-3bb53e20a43so23381b6e.1
for <stable@dpdk.org>; Wed, 03 Jan 2024 17:04:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704330240;
x=1704935040; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=p8Z3ag5n9BtuBdr8mZwIMyVdIBBOx5PC0r8wIgH8tT8=;
b=j6Na5uTTj4VkjR0vbqrtwG2uKy/VlRImlBp8/V8YvePLuAGml2a6ABx5g2qgEYRIMM
Ki4pbCMyHncLWG5/NFxQ7SlpQErE3sPnBKH2Ttlg2KG1x84T1zMUO/VgsNLFT3qdArao
hJld+nucOl1dI1E1LoCdFT66gYPEKvrtETNkgWF6/0rZOCR4QzWyxRBHE+4q878fRCs4
AVrhzoWXq9grhIDP87LCWxqcCZaDF6sXiGPLlpLTmQrhML27fzUzwhcLrb9SfHbo+vCU
J56DtH9mH+7gORx++U6QFEnXFLVD8/jnDVhevQVbwWN7DejYo3GIu0iDwcgXwQtsKUvU
3Yng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1704330240; x=1704935040;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=p8Z3ag5n9BtuBdr8mZwIMyVdIBBOx5PC0r8wIgH8tT8=;
b=NbVhy8raQXAwlpOK9pj94atKrK3hIPdFYk983zJ78Rqef+8cz895n48/QZLnGbtcMN
hksu/JjsLn2+b80Q0WfPmM5SIw8V1dFE8lYjWpdfupdScR85e+0zin78TyBSUD62c3js
AV6L807m/Gdug5odgCALsleW67QONNovNGT9kq8/BN01MfAiXAuS/ZvwZ7Nb7nBC1wEF
IHasgCM36NpsvK4yIxiZ9gTWVEM9mBEW3bOmfE397NX6dBbMv87Ug5f6La1qaLHgCB7q
TMHIAhE+xfPOMlhJrYm9yOPRvdXmuQUR64mAT9newGXgrb9y3tdF+W8HFjyWIQw4U3Rt
fBMA==
X-Gm-Message-State: AOJu0Yz4jokyBfM739TX3zVoOU9AuoGZHu486SFsX295seFErwTGMK9Y
4bEOgUA7foI9uRrqMXiXij4zK3wBhjHs7Q==
X-Google-Smtp-Source: AGHT+IEVIimGF27lqJ3VnjD1cr+MGNAh+gNgHPcQidM0IauIFLjyoXqeba7K4sVj7cMFFvu0is42Gg==
X-Received: by 2002:a05:6358:9214:b0:175:565c:b07f with SMTP id
d20-20020a056358921400b00175565cb07fmr2049525rwb.43.1704330240513;
Wed, 03 Jan 2024 17:04:00 -0800 (PST)
Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])
by smtp.gmail.com with ESMTPSA id
j22-20020a62e916000000b006d97cc5cc13sm22548837pfh.8.2024.01.03.17.03.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 03 Jan 2024 17:04:00 -0800 (PST)
Date: Wed, 3 Jan 2024 17:03:58 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Kaiwen Deng <kaiwenx.deng@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com,
yidingx.zhou@intel.com, Aman Singh <aman.deep.singh@intel.com>, Yuying
Zhang <yuying.zhang@intel.com>, David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v1] app/testpmd: use Tx preparation in txonly engine
Message-ID: <20240103170358.6762efb8@hermes.local>
In-Reply-To: <20240103012912.4334-1-kaiwenx.deng@intel.com>
References: <20240103012912.4334-1-kaiwenx.deng@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On Wed, 3 Jan 2024 09:29:12 +0800
Kaiwen Deng <kaiwenx.deng@intel.com> wrote:
>
> - nb_tx = common_fwd_stream_transmit(fs, pkts_burst, nb_pkt);
> + nb_prep = rte_eth_tx_prepare(fs->tx_port, fs->tx_queue,
> + pkts_burst, nb_pkt);
> + if (unlikely(nb_prep != nb_pkt)) {
> + fprintf(stderr,
> + "Preparing packet burst to transmit failed: %s\n",
> + rte_strerror(rte_errno));
The main failure likely is mismatched offload flags, so it might be helpful
to print offload flags of that mbuf.
> + fs->fwd_dropped += (nb_pkt - nb_prep);
Nit: no parenthesis needed here.
> + rte_pktmbuf_free_bulk(&pkts_burst[nb_prep], nb_pkt - nb_prep);
> + }
> +
> + nb_tx = common_fwd_stream_transmit(fs, pkts_burst, nb_prep);
>