From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4161243894 for ; Thu, 11 Jan 2024 17:57:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77EFE402AD; Thu, 11 Jan 2024 17:57:12 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 1845440269 for ; Thu, 11 Jan 2024 17:57:11 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d54b763d15so27237555ad.0 for ; Thu, 11 Jan 2024 08:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1704992231; x=1705597031; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zMVRngBABDpba1j1NHbqSxUSmDZUhH1dvYJXu5Ha7Dk=; b=cTNwrvDb3KYE1AmIDzD6nst1FH0Gb82RRsqnV9TUnlhKTUW4dIh2Teb/fXJWnu4/4r Z367bSApqaYqr5Tow+eCsXNMd+xgd2XSEPhewIwWIBVk9sHEiS9PjC/1jSxvA0SNnnAX P876Xx2n0u8xJzRX3KJMQR+J7OEeC2wXei5Pnp9vCzKZX4HBJrIj/cliQENFoYskYd2L ybQvi+8AAKNh88Etxybs0TTIK7W0JkxXHmk+Q/Mf/TCU9l8VVwhUN5vpiUWTEo3yA7sG Rb3/PRHOWLWfwEXaxNTCvScqzdqZpZt28g6GRBLxblChHWW5y/s6afWt/CobQB2CwiGk 2TwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704992231; x=1705597031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zMVRngBABDpba1j1NHbqSxUSmDZUhH1dvYJXu5Ha7Dk=; b=h8Hm2KIN3KZnSXmwowmKB1RFPi8P4uE1Y17PnpDPWBtzQqsi6U+feaP7d6T2cmXLSL S/LJjZYToMUe7MU12BhdQuE7H/8t2tW/cSzyqjkODbQZS1b4XAPND8ACib5Bhx16ImTq dfLTrLmgRczUbKJbJF89EYkWVpnLWm6v7Z+Mv1l5gZsypg4OK22/wk6rcT9uHdNLkUj7 fW+goB/2E4N9WY9kzMRPLsozB0EdZMd566v5IZ6jcs2WDUjYS+uR5Au4mhBa80lkNHf2 sG6jXIm4htC0y/64rfu31GQDct7LyO+ic/izuHfVhqv2RVc0YQp689C5Pz0xaX4Mnd2o 6FJg== X-Gm-Message-State: AOJu0YzlAUpNfmQb5AV9c/cn3ZiB/2ty6g9FIR3l2ub+n5ch3Fvsv4sh 7JT7okzl9c0vHU/1FXpqndG7lSfWvllNYw== X-Google-Smtp-Source: AGHT+IHKjUM0oJ39iRIhlBHPUma8QY404o/+c6qFUXjYaViJJPAtFJWFjVsEG49Ymc7M1QqbOUAX/Q== X-Received: by 2002:a17:902:d353:b0:1d5:5ec8:b3a6 with SMTP id l19-20020a170902d35300b001d55ec8b3a6mr1446181plk.120.1704992230668; Thu, 11 Jan 2024 08:57:10 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id kh4-20020a170903064400b001d4c9c9be42sm1379402plb.151.2024.01.11.08.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 08:57:10 -0800 (PST) Date: Thu, 11 Jan 2024 08:57:06 -0800 From: Stephen Hemminger To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Aman Singh , Yuying Zhang , Ferruh Yigit , David Marchand Subject: Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine Message-ID: <20240111085706.72fef7d0@hermes.local> In-Reply-To: <20240111052555.35930-1-kaiwenx.deng@intel.com> References: <20240103012912.4334-1-kaiwenx.deng@intel.com> <20240111052555.35930-1-kaiwenx.deng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, 11 Jan 2024 13:25:55 +0800 Kaiwen Deng wrote: > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but it will cause > MDD event if txonly forwarding engine does not call the Tx preparation > API before transmitting packets. > > We can reproduce this issue by these steps list blow on ICE and I40e. > > ./x86_64-native-linuxapp-gcc/app/dpdk-testpmd -c 0xf -n 4 -- -i > --tx-offloads=0x00008000 > > testpmd>set txpkts 64,128,256,512,64,128,256,512,512 > testpmd>set burst 1 > testpmd>start tx_first 1 > > This commit will use Tx preparation API in txonly forwarding engine. > > Fixes: 655131ccf727 ("app/testpmd: factorize fwd engines Tx") > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng Acked-by: Stephen Hemminger