* [PATCH 3/5] common/cnxk: fix for inline dev pointer check [not found] <20240119055721.1750399-1-rbhansali@marvell.com> @ 2024-01-19 5:57 ` Rahul Bhansali 2024-01-19 5:57 ` [PATCH 4/5] net/cnxk: fix to add reassembly fast path flag Rahul Bhansali [not found] ` <20240222100729.991411-1-rbhansali@marvell.com> 2 siblings, 0 replies; 4+ messages in thread From: Rahul Bhansali @ 2024-01-19 5:57 UTC (permalink / raw) To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, Rahul Bhansali Cc: stable Add missing check of Inline device pointer before accessing is_multi_channel variable. Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF") Cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- drivers/common/cnxk/roc_nix_inl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c index de8fd2a605..a205c658e9 100644 --- a/drivers/common/cnxk/roc_nix_inl.c +++ b/drivers/common/cnxk/roc_nix_inl.c @@ -933,7 +933,8 @@ roc_nix_inl_inb_init(struct roc_nix *roc_nix) inl_dev = idev->nix_inl_dev; roc_nix->custom_meta_aura_ena = (roc_nix->local_meta_aura_ena && - (inl_dev->is_multi_channel || roc_nix->custom_sa_action)); + ((inl_dev && inl_dev->is_multi_channel) || + roc_nix->custom_sa_action)); if (!roc_model_is_cn9k() && !roc_errata_nix_no_meta_aura()) { nix->need_meta_aura = true; if (!roc_nix->local_meta_aura_ena || roc_nix->custom_meta_aura_ena) -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/5] net/cnxk: fix to add reassembly fast path flag [not found] <20240119055721.1750399-1-rbhansali@marvell.com> 2024-01-19 5:57 ` [PATCH 3/5] common/cnxk: fix for inline dev pointer check Rahul Bhansali @ 2024-01-19 5:57 ` Rahul Bhansali [not found] ` <20240222100729.991411-1-rbhansali@marvell.com> 2 siblings, 0 replies; 4+ messages in thread From: Rahul Bhansali @ 2024-01-19 5:57 UTC (permalink / raw) To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, Akhil Goyal Cc: Rahul Bhansali, stable For IPsec decrypted packets, full packet format condition check is enabled for both reassembly and non-reassembly path as part of OOP handling. Instead, it should be only in reassembly path. To fix this, NIX_RX_REAS_F flag condition is added to avoid packet format check in non-reassembly fast path. Fixes: 5e9e008d0127 ("net/cnxk: support inline ingress out-of-place session") Cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- drivers/net/cnxk/cn10k_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index c4ad1b64fe..89621af3fb 100644 --- a/drivers/net/cnxk/cn10k_rx.h +++ b/drivers/net/cnxk/cn10k_rx.h @@ -734,7 +734,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf, else wqe = (const uint64_t *)(mbuf + 1); - if (hdr->w0.pkt_fmt != ROC_IE_OT_SA_PKT_FMT_FULL) + if (!(flags & NIX_RX_REAS_F) || hdr->w0.pkt_fmt != ROC_IE_OT_SA_PKT_FMT_FULL) rx = (const union nix_rx_parse_u *)(wqe + 1); } -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20240222100729.991411-1-rbhansali@marvell.com>]
* [PATCH v2 3/5] common/cnxk: fix for inline dev pointer check [not found] ` <20240222100729.991411-1-rbhansali@marvell.com> @ 2024-02-22 10:07 ` Rahul Bhansali 2024-02-22 10:07 ` [PATCH v2 4/5] net/cnxk: fix to add reassembly fast path flag Rahul Bhansali 1 sibling, 0 replies; 4+ messages in thread From: Rahul Bhansali @ 2024-02-22 10:07 UTC (permalink / raw) To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, Rahul Bhansali Cc: stable Add missing check of Inline device pointer before accessing is_multi_channel variable. Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF") Cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- Changes in v2: No change drivers/common/cnxk/roc_nix_inl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c index de8fd2a605..a205c658e9 100644 --- a/drivers/common/cnxk/roc_nix_inl.c +++ b/drivers/common/cnxk/roc_nix_inl.c @@ -933,7 +933,8 @@ roc_nix_inl_inb_init(struct roc_nix *roc_nix) inl_dev = idev->nix_inl_dev; roc_nix->custom_meta_aura_ena = (roc_nix->local_meta_aura_ena && - (inl_dev->is_multi_channel || roc_nix->custom_sa_action)); + ((inl_dev && inl_dev->is_multi_channel) || + roc_nix->custom_sa_action)); if (!roc_model_is_cn9k() && !roc_errata_nix_no_meta_aura()) { nix->need_meta_aura = true; if (!roc_nix->local_meta_aura_ena || roc_nix->custom_meta_aura_ena) -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 4/5] net/cnxk: fix to add reassembly fast path flag [not found] ` <20240222100729.991411-1-rbhansali@marvell.com> 2024-02-22 10:07 ` [PATCH v2 3/5] common/cnxk: fix for inline dev pointer check Rahul Bhansali @ 2024-02-22 10:07 ` Rahul Bhansali 1 sibling, 0 replies; 4+ messages in thread From: Rahul Bhansali @ 2024-02-22 10:07 UTC (permalink / raw) To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao, Akhil Goyal Cc: Rahul Bhansali, stable For IPsec decrypted packets, full packet format condition check is enabled for both reassembly and non-reassembly path as part of OOP handling. Instead, it should be only in reassembly path. To fix this, NIX_RX_REAS_F flag condition is added to avoid packet format check in non-reassembly fast path. Fixes: 5e9e008d0127 ("net/cnxk: support inline ingress out-of-place session") Cc: stable@dpdk.org Signed-off-by: Rahul Bhansali <rbhansali@marvell.com> --- Changes in v2: No change drivers/net/cnxk/cn10k_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index c4ad1b64fe..89621af3fb 100644 --- a/drivers/net/cnxk/cn10k_rx.h +++ b/drivers/net/cnxk/cn10k_rx.h @@ -734,7 +734,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf, else wqe = (const uint64_t *)(mbuf + 1); - if (hdr->w0.pkt_fmt != ROC_IE_OT_SA_PKT_FMT_FULL) + if (!(flags & NIX_RX_REAS_F) || hdr->w0.pkt_fmt != ROC_IE_OT_SA_PKT_FMT_FULL) rx = (const union nix_rx_parse_u *)(wqe + 1); } -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-22 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240119055721.1750399-1-rbhansali@marvell.com>
2024-01-19 5:57 ` [PATCH 3/5] common/cnxk: fix for inline dev pointer check Rahul Bhansali
2024-01-19 5:57 ` [PATCH 4/5] net/cnxk: fix to add reassembly fast path flag Rahul Bhansali
[not found] ` <20240222100729.991411-1-rbhansali@marvell.com>
2024-02-22 10:07 ` [PATCH v2 3/5] common/cnxk: fix for inline dev pointer check Rahul Bhansali
2024-02-22 10:07 ` [PATCH v2 4/5] net/cnxk: fix to add reassembly fast path flag Rahul Bhansali
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).