From: Ashish Sadanandan <ashish.sadanandan@gmail.com>
To: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Cc: Ashish Sadanandan <ashish.sadanandan@gmail.com>,
nelio.laranjeiro@6wind.com, stable@dpdk.org
Subject: [PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h
Date: Thu, 1 Feb 2024 22:13:35 -0700 [thread overview]
Message-ID: <20240202051335.776290-1-ashish.sadanandan@gmail.com> (raw)
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Fixes: 86c743cf9140 ("eal: define generic vector types")
Cc: nelio.laranjeiro@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
.mailmap | 2 +-
lib/eal/include/generic/rte_vect.h | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index aa569ff456..3938ace307 100644
--- a/.mailmap
+++ b/.mailmap
@@ -140,7 +140,7 @@ Ashijeet Acharya <ashijeet.acharya@6wind.com>
Ashish Gupta <ashishg@marvell.com> <ashish.gupta@marvell.com> <ashish.gupta@caviumnetworks.com>
Ashish Jain <ashish.jain@nxp.com>
Ashish Paul <apaul@juniper.net>
-Ashish Sadanandan <ashish.sadanandan@gmail.com>
+Ashish Sadanandan <ashish.sadanandan@gmail.com> <quic_asadanan@quicinc.com>
Ashish Shah <ashish.n.shah@intel.com>
Ashwin Sekhar T K <asekhar@marvell.com> <ashwin.sekhar@caviumnetworks.com>
Asim Jamshed <asim.jamshed@gmail.com>
diff --git a/lib/eal/include/generic/rte_vect.h b/lib/eal/include/generic/rte_vect.h
index 6540419cd2..3578d8749b 100644
--- a/lib/eal/include/generic/rte_vect.h
+++ b/lib/eal/include/generic/rte_vect.h
@@ -15,6 +15,10 @@
#include <stdint.h>
+#ifdef __cplusplus
+extern "C" {
+#endif
+
#ifndef RTE_TOOLCHAIN_MSVC
/* Unsigned vector types */
@@ -226,4 +230,8 @@ uint16_t rte_vect_get_max_simd_bitwidth(void);
*/
int rte_vect_set_max_simd_bitwidth(uint16_t bitwidth);
+#ifdef __cplusplus
+}
+#endif
+
#endif /* _RTE_VECT_H_ */
--
2.31.1
next reply other threads:[~2024-02-02 5:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 5:13 Ashish Sadanandan [this message]
2024-02-02 9:18 ` Thomas Monjalon
2024-02-02 9:40 ` Bruce Richardson
2024-02-02 20:58 ` Ashish Sadanandan
2024-03-13 23:45 ` Stephen Hemminger
2024-03-14 3:45 ` Tyler Retzlaff
2024-02-05 17:36 ` Tyler Retzlaff
2024-02-05 21:07 ` Morten Brørup
2024-02-12 15:43 ` Ferruh Yigit
2024-02-12 16:02 ` Morten Brørup
2024-03-13 20:26 ` Ashish Sadanandan
2024-03-13 20:45 ` Thomas Monjalon
2024-03-13 22:11 ` Ashish Sadanandan
2024-02-12 15:42 ` Ferruh Yigit
2024-03-18 2:40 ` [PATCH v2 " Ashish Sadanandan
2024-03-18 2:44 ` [PATCH v3 " Ashish Sadanandan
2024-04-02 16:03 ` Ashish Sadanandan
2024-04-03 14:52 ` Thomas Monjalon
2024-04-07 1:30 ` Ashish Sadanandan
2024-04-07 17:04 ` Stephen Hemminger
2024-04-08 8:50 ` Ferruh Yigit
2024-04-08 9:04 ` Bruce Richardson
2024-04-08 15:29 ` Tyler Retzlaff
2024-04-02 16:10 ` Bruce Richardson
2024-04-02 16:19 ` Tyler Retzlaff
2024-10-07 20:20 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202051335.776290-1-ashish.sadanandan@gmail.com \
--to=ashish.sadanandan@gmail.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).