patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH 1/2] rcu: use atomic operation on acked token
@ 2024-02-05  4:59 Honnappa Nagarahalli
  2024-02-05  4:59 ` [PATCH 2/2] rcu: use correct value of acked token in debug print Honnappa Nagarahalli
  0 siblings, 1 reply; 3+ messages in thread
From: Honnappa Nagarahalli @ 2024-02-05  4:59 UTC (permalink / raw)
  To: dev
  Cc: wathsala.vithanage, dhruv.tripathi, nd, Honnappa Nagarahalli,
	stable, Ola Liljedahl

acked_token should be read using atomic operation as the
the API rte_rcu_qsbr_check is advertised as multi-thread safe.

Fixes: 1f90d32ce175 ("rcu: add least acknowledged token optimization")
Cc: stable@dpdk.org

Reported-by: Ola Liljedahl <ola.liljedahl@arm.com>
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>
---
 lib/rcu/rte_rcu_qsbr.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 5979fb0efb..f6a3731308 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -667,7 +667,8 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
 	RTE_ASSERT(v != NULL);
 
 	/* Check if all the readers have already acknowledged this token */
-	if (likely(t <= v->acked_token)) {
+	if (likely(t <= rte_atomic_load_explicit(&v->acked_token,
+						rte_memory_order_relaxed))) {
 		__RTE_RCU_DP_LOG(DEBUG,
 			"%s: check: token = %" PRIu64 ", wait = %d",
 			__func__, t, wait);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-18 18:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-05  4:59 [PATCH 1/2] rcu: use atomic operation on acked token Honnappa Nagarahalli
2024-02-05  4:59 ` [PATCH 2/2] rcu: use correct value of acked token in debug print Honnappa Nagarahalli
2024-02-18 18:13   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).