* [PATCH 11/11] net/mlx5: remove unneeded device status checking [not found] <20240228170046.176600-1-dsosnowski@nvidia.com> @ 2024-02-28 17:00 ` Dariusz Sosnowski [not found] ` <20240229115157.201671-1-dsosnowski@nvidia.com> 1 sibling, 0 replies; 2+ messages in thread From: Dariusz Sosnowski @ 2024-02-28 17:00 UTC (permalink / raw) To: Viacheslav Ovsiienko, Ori Kam, Suanming Mou, Matan Azrad Cc: dev, Raslan Darawsheh, Bing Zhao, stable From: Bing Zhao <bingz@nvidia.com> The flow rule can be inserted even before the device started. The only exception is for a queue or RSS action. For the other interfaces of template API, the start status is not checked. The checking would cause some cache miss or eviction since the flag locates on some other cache line. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Cc: stable@dpdk.org Signed-off-by: Bing Zhao <bingz@nvidia.com> --- drivers/net/mlx5/mlx5_flow_hw.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 4e4beb4428..8481a9b7f0 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -3501,11 +3501,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, uint32_t res_idx = 0; int ret; - if (unlikely((!dev->data->dev_started))) { - rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, - "Port must be started before enqueueing flow operations"); - return NULL; - } flow = mlx5_ipool_malloc(table->flow, &flow_idx); if (!flow) goto error; -- 2.39.2 ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <20240229115157.201671-1-dsosnowski@nvidia.com>]
* [PATCH v2 11/11] net/mlx5: remove unneeded device status checking [not found] ` <20240229115157.201671-1-dsosnowski@nvidia.com> @ 2024-02-29 11:51 ` Dariusz Sosnowski 0 siblings, 0 replies; 2+ messages in thread From: Dariusz Sosnowski @ 2024-02-29 11:51 UTC (permalink / raw) To: Viacheslav Ovsiienko, Ori Kam, Suanming Mou, Matan Azrad Cc: dev, Raslan Darawsheh, Bing Zhao, stable From: Bing Zhao <bingz@nvidia.com> The flow rule can be inserted even before the device started. The only exception is for a queue or RSS action. For the other interfaces of template API, the start status is not checked. The checking would cause some cache miss or eviction since the flag locates on some other cache line. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Cc: stable@dpdk.org Signed-off-by: Bing Zhao <bingz@nvidia.com> Acked-by: Ori Kam <orika@nvidia.com> --- drivers/net/mlx5/mlx5_flow_hw.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 979be4764a..285ec603d3 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -3520,11 +3520,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, uint32_t res_idx = 0; int ret; - if (unlikely((!dev->data->dev_started))) { - rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, - "Port must be started before enqueueing flow operations"); - return NULL; - } flow = mlx5_ipool_malloc(table->flow, &flow_idx); if (!flow) goto error; -- 2.39.2 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-29 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240228170046.176600-1-dsosnowski@nvidia.com>
2024-02-28 17:00 ` [PATCH 11/11] net/mlx5: remove unneeded device status checking Dariusz Sosnowski
[not found] ` <20240229115157.201671-1-dsosnowski@nvidia.com>
2024-02-29 11:51 ` [PATCH v2 " Dariusz Sosnowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).