From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5446D43B7D for ; Tue, 5 Mar 2024 10:58:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D38042E4D; Tue, 5 Mar 2024 10:58:49 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2077.outbound.protection.outlook.com [40.107.93.77]) by mails.dpdk.org (Postfix) with ESMTP id BDED84026B for ; Tue, 5 Mar 2024 10:58:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqBoJGVycvUbHvHOJkErQRcyeLSkgKiH8VWfrkIKyOO7C9BfH25WsPQ/4BzEgL5ppHX/Z2yMlSCQcMjPQkgDHnO7nT6P9Gqu4BadbnrzRTGup5lbaEgHjuzjiZ6RRWmzn8Y/bYgI2JcsvH7FeSP8+fyVKnbs7VRKnYpqZi3cnvTqSCWiqY/UBmI3MKOzXBtVl36jj/7lfQ+FjTMsZoA2f4OFee0HxVGWppZD190V9yx5tCJthnEAlvarQc54wo/hIIifmvq8i3YFDeqRN0eaxhzD2n23c4Sp6QuYnrh/5BnZ2iuY3h+BRNiCOieaufa18g8tekoS42/jWOF8AfdivQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvvG28RmZ9pElOO+Jk5gayiNiIHw7O1MoLt3Mby+s1Q=; b=mea7leXVVMQuCw0yA9PWOMh+Cnxfs6EPgf0L/VtF0wNoFN1eTyRWVJE3C93w0om++02lNuGj+2rfmb8KFUwj877gF6GBEF9+kV60GPe22/4Pogc0PkJjd7OPcnuuFHADRxysvKCFFJ69bafiEDkpuA9Q98heSex4UGyFi67EpaIaBXogfpObppyM9MpwtfN0wFXdycuEHgSYnpP6VCeAr1XO6lThntjA/Ds/PVIwxD7D6Jwy2bgeoPflVXM+1ktCthjfUPSuNYPfxECSoH1mwO4KqdyQAC6VAO2eP276GUoOk3lqyT51ijXLhd+g1RpNbEJx2t1/fiJBngt49EjlEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=broadcom.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvvG28RmZ9pElOO+Jk5gayiNiIHw7O1MoLt3Mby+s1Q=; b=mTzd2JOupZtIsvr2mJ0vyUXHrG70WadgfwfRN36qjjz4I1Pcs/FrqcaCf72+bykjP/p7Z85EBS/IjtnwbXSCU6/g9/4l1BNqTFKp3IK6IhWUwT+cilKIYB3Qj9TwQo5JSzN2TNs1hxMoThmCQlSbwjKLpfR6wuXKSkEwllj/wR6V2D5QqWXjVJjMqMG18UOli3XbjbTEbj6PnblhUxLr23bpQmVmZm7vwj42PTSS1kuuPxUVWWtHawyqiD4EBHLGruLFWZfHbOJzMAggoVB1NgmQVk/m5srCNG0siYsy4bURyQ3NFa0AwuGdn4WSmzbxcpQZtaPtFnH9Div+iNzQQA== Received: from SJ0PR05CA0129.namprd05.prod.outlook.com (2603:10b6:a03:33d::14) by LV3PR12MB9355.namprd12.prod.outlook.com (2603:10b6:408:216::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Tue, 5 Mar 2024 09:58:45 +0000 Received: from CO1PEPF000042A7.namprd03.prod.outlook.com (2603:10b6:a03:33d:cafe::82) by SJ0PR05CA0129.outlook.office365.com (2603:10b6:a03:33d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24 via Frontend Transport; Tue, 5 Mar 2024 09:58:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042A7.mail.protection.outlook.com (10.167.243.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:58:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:58:27 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:58:25 -0800 From: Xueming Li To: Kalesh AP CC: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix backward firmware compatibility' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:47:37 +0800 Message-ID: <20240305094757.439387-117-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A7:EE_|LV3PR12MB9355:EE_ X-MS-Office365-Filtering-Correlation-Id: c8cd282c-8ee2-49dd-797c-08dc3cfad83b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yb0TRYmdaT/D43jMyh5hUTNejrE9TZ31Uc51fOgD3h4hVqOlftxacDrukHjMhzZ5wy3h/CvJ16BCkTlmx7rgc0sDa6FrL/55ULHMooNDgtdqtYsUaCoiwGXNzl+g152rEgIm4VC3dlm+FggsQOzc+rVg77fZgWDy0QXUlylZ8wsSob08PPDMTnalQ0QoHBD9gdRT80p9tWjFI1V2KiKw9/EgZHf+OA6B4cf55le7pzcZs0RaKKXuYQXdr/AcMf87fkxl3LbMejalAIZ3ifZ7/eQpAKpZwiuV+EHZWziv7BcA75PhZENJ7HeNcAsM520fZUgv+nabbZS+Cq9n9iNf/m9stJ5xGJd15Z7PLeTDSwsIojdTuqP4Sa80gXVASYA3KfBycRLv3lcvHYPTOXl/4tnyvQYc7u5/Wv79WfXgkNIa1ad3l8UEPLUVgh3Np3IdyFFlLaXDcGIfcnrPHql08l8kDRhb8Ye4XilD4tAag6/tyjwn44owdKTZTxPlUPa45bg7FdDaFNa0OL9GGpjeyiKBy2VoV1b8FQ33RHW+t3QcvfXZcYLHcfq0UKqxbZeRh5VZ+KNwPhICRS15YGZb4kw32NroRXuLJWu3QOh29Iuv78C1jPRPA6TcMMm26QyBc8N6zs484bJmJidJpKD8S7Rxwpxc+QrSzCI8zw7AEdmAsdMYu0M2VXjPYELJEiM3F5eJ3kHYiX7tdFfKT3CpjAwkgX7mvMk/uj1C5rpiKgB4jEV+gnWUN09/XN4J7uoK X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:58:44.5472 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c8cd282c-8ee2-49dd-797c-08dc3cfad83b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A7.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9355 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c26cb2a6440e50a23c799612306ae3b746f7b54a Thanks. Xueming Li --- >From c26cb2a6440e50a23c799612306ae3b746f7b54a Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Thu, 7 Dec 2023 07:56:26 -0800 Subject: [PATCH] net/bnxt: fix backward firmware compatibility Cc: Xueming Li [ upstream commit 589619999b0411a4266e335fe105e1c7cba6e02b ] On older firmware versions, HWRM_FUNC_QCAPS response is not returning the maximum number of multicast filters that can be supported by the function. As a result, memory allocation with size 0 fails. Bugzilla ID: 1309 Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index aab09e3edf..7908efba78 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -896,6 +896,7 @@ struct bnxt { struct rte_ether_addr *mcast_addr_list; rte_iova_t mc_list_dma_addr; uint32_t nb_mc_addr; +#define BNXT_DFLT_MAX_MC_ADDR 16 /* for compatibility with older firmware */ uint32_t max_mcast_addr; /* maximum number of mcast filters supported */ struct rte_eth_rss_conf rss_conf; /* RSS configuration. */ diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index d9ad361c6c..94c3249ae4 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -863,6 +863,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) bp->max_l2_ctx, bp->max_vnics); bp->max_stat_ctx = rte_le_to_cpu_16(resp->max_stat_ctx); bp->max_mcast_addr = rte_le_to_cpu_32(resp->max_mcast_filters); + if (!bp->max_mcast_addr) + bp->max_mcast_addr = BNXT_DFLT_MAX_MC_ADDR; memcpy(bp->dsn, resp->device_serial_number, sizeof(bp->dsn)); if (BNXT_PF(bp)) -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:34.447695315 +0800 +++ 0116-net-bnxt-fix-backward-firmware-compatibility.patch 2024-03-05 17:39:30.943566499 +0800 @@ -1 +1 @@ -From 589619999b0411a4266e335fe105e1c7cba6e02b Mon Sep 17 00:00:00 2001 +From c26cb2a6440e50a23c799612306ae3b746f7b54a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 589619999b0411a4266e335fe105e1c7cba6e02b ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 3290c57a72..4b8a691f80 100644 +index aab09e3edf..7908efba78 100644 @@ -25 +27 @@ -@@ -974,6 +974,7 @@ struct bnxt { +@@ -896,6 +896,7 @@ struct bnxt { @@ -34 +36 @@ -index 441e3aef51..9260bcb4cd 100644 +index d9ad361c6c..94c3249ae4 100644 @@ -37 +39 @@ -@@ -901,6 +901,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) +@@ -863,6 +863,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)