From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8281843B7D for ; Tue, 5 Mar 2024 10:59:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D89A42E52; Tue, 5 Mar 2024 10:59:32 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2043.outbound.protection.outlook.com [40.107.102.43]) by mails.dpdk.org (Postfix) with ESMTP id 1FAC84014F for ; Tue, 5 Mar 2024 10:59:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rgyrp31W3ojqyvZ7CQRa1fE4QjPGS1fCYnLdU1skkLw4vSUx76qR68seSHmOxqY8lB067JCb0Z5eFapmHn/aW+C8zBZ2mVqmxOdJVXk58xSakay9q3Te6TfXWQvyA0qQHLvhQBvkh/d9Oq8aYZUwBjdxknKlbIjZs3eLzKPcaZIS1qQy16xCEFI8Mq2Wr7wb7jZkrNqv39pV6bEyCQ5D0nByN09Xx5in1nskcsc1OHxSvzLwKeBHAtut/vKfvQ9+Qw1gSeiTNNpgGVShovBDVP8HTgtasBT67y39SMe7ImCkhoTEsEVsTNyHkp7qTP9GP4xDwpOW2ZqRYWFOY+pStw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GgThqtqzjIwC28hhXGgErG8HaiixyKKGmqcuWRnKiSI=; b=ZvycYwUlJg9GSUkcBqSy8BDSdp3alBXi8E3XrOJFvxxZQSENxMvfuRUccdZOWODW5qzMBnFDHui2ckWWcyPiFH79ups0l4X15G+mtMKHSLLHP+nT1ifYY6T9o3cPCDetfirMSTW91F5w8+TEjbraEdOVQmrkf5hCpXyNRlot+1tfHyveS+PvYThWSKFbNvex0ctFpH/+LP2SXGHTOAc1Ai5kuxp2K87GekuDYuDjHG+/gibKCs4dutlXsyo+EeQp0W5d7JQq53DU5geyOXBBSQGGpDij7AvzVQoRULyCfmKGeOOs7hBynKsZ8ZJ0zCqZLlsfu1d4kTPSdqQcpLkUrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GgThqtqzjIwC28hhXGgErG8HaiixyKKGmqcuWRnKiSI=; b=gZZEQsJoHFvGZyu9dArylLPSVLj3qgDNaOLTvX5iIZzokLTEy/UGJNSHBWUzdGOsu6SVMSMJS1FTxNG5zbh5nJvGEIuWQSdd49KXkH/X70AUZ2u6i0w83xFSHwWKVj3XoH1jAtEEYKChCdclQXoslxliKKeWqqie9+kokieVcDGRNqTJumg75WHcWZ83qUr8T9nmjWoQeKf3t/Xp+BM+5wntbefibnrq06f0VLBqOCx0kQn4yq2ljRUl2onODddKMG7nfSUANJf1OrND0X4/YMLgA/Ga3hOXxWyRfQw87ipQgL/of3kQiNO+NwscVrjKb9tlq2B+EaoolOJvRR3eTg== Received: from CY8P220CA0027.NAMP220.PROD.OUTLOOK.COM (2603:10b6:930:47::27) by MW4PR12MB7189.namprd12.prod.outlook.com (2603:10b6:303:224::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 09:59:27 +0000 Received: from CY4PEPF0000EDD0.namprd03.prod.outlook.com (2603:10b6:930:47:cafe::d9) by CY8P220CA0027.outlook.office365.com (2603:10b6:930:47::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:59:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EDD0.mail.protection.outlook.com (10.167.241.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:59:27 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:59:17 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:59:15 -0800 From: Xueming Li To: Michael Baum CC: Matan Azrad , dpdk stable Subject: patch 'net/mlx5: fix jump action validation' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:47:46 +0800 Message-ID: <20240305094757.439387-126-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD0:EE_|MW4PR12MB7189:EE_ X-MS-Office365-Filtering-Correlation-Id: 92a678f8-1a65-4347-cb33-08dc3cfaf1a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GYp2Gccx+c48QVedQw0DB4KOS6lSQCsHCgGUJvsg+tGPbxJSrCedUGBIUB4LeiD9f9ZlxXy9BlM7/9dPhqtqdthg2eh+alDHXGk4jmknajuzu+okWRZIWOiTrz45pJzrXs7dUal5c1Cgtidylaf+raSxt4Zsn0EmM3XZ5f5F9SZ8avj+mQKQVr2EKHI+1H1t6+zNOqvcCFqRyetSn0o3Qa5BNEOSj3xrOKnS8mQFMwG75DPDEPmz2KXK/8vcBuGd1CqHD/HwE8hPA53Bv7YmoMXnPcH7LCByhCcwDZO3j5peUcGlR/48rHweaBZhX8uNWB/0V9glVROjjyeXC8y+jOQVycgbUwAehnqN1JNnUtSuxC/5PAUviKsEe/8ztgqnlsxg3a1h9bQLwZCV2UTvMgzqIhUZ7PH3eB9Qrk8x6774fpENIk14PrufE2efKEiqe4JvkOKwsa2iO9oCLEjPtVNdme/bedXCKQPFOe34jPQKJ0f6Qyqj2IvxOXrlQWUJVzxgpP19Y/o6b+oKPSC2ucD2CpwKJV2fsvYcvgpcrB0eA7U7P032VvmKomADuxC8IaPrjjgn/0FsczaWhzsfnVUbI/c319ItTy/6o4kqc2dHeUNCx7AMCoWYudmMOpAZZKuiY4otPuPiXLEwNzn7dBuIRDyLUM5tEDPPHXgWWq+lS/3CpHiZghM+nt9OcwsvO28L9yWQW8U0IGUquklwj47/52OL63QAZSmD1N4Qm7oy/wiRio2c0ijgbdmRMePw X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:59:27.2273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 92a678f8-1a65-4347-cb33-08dc3cfaf1a4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7189 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=7c8f2e719a182fea1576fe02f9d2e57ef3e17830 Thanks. Xueming Li --- >From 7c8f2e719a182fea1576fe02f9d2e57ef3e17830 Mon Sep 17 00:00:00 2001 From: Michael Baum Date: Mon, 27 Nov 2023 14:42:59 +0200 Subject: [PATCH] net/mlx5: fix jump action validation Cc: Xueming Li [ upstream commit 9c289272ae692bd03d1dc9726ef19785beedd313 ] Currently PMD doesn't allow to jump to the same group in order to avoid dead loop. But this also prevent experienced user to create flow with less Hops in order to have better performance. For example, rules in [1] should have better performance then [2]. Furthermore, this protection will not really prevent dead loop, i.e [3]. So just remove this protection and user should take the responsibility to avoid dead loop. This patch enables jumping to the same group. [1]: flow create 0 group 1 priority 1 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 1 / end flow create 0 group 1 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [2]: flow create 0 group 1 priority 0 pattern eth / ipv4 / udp / gtp / end actions raw_decap / raw_encap / jump group 2 / end flow create 0 group 2 priority 0 pattern eth / ipv4 src is 1.0.0.1 / tcp / end actions queues index 1 / end [3]: flow create 0 group 1 pattern eth / end actions jump group 2 / end flow create 0 group 2 pattern eth / end actions jump group 1 / end Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 115d730317..5d0cb4278b 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -5484,13 +5484,6 @@ flow_dv_validate_action_jump(struct rte_eth_dev *dev, &grp_info, error); if (ret) return ret; - if (attributes->group == target_group && - !(action_flags & (MLX5_FLOW_ACTION_TUNNEL_SET | - MLX5_FLOW_ACTION_TUNNEL_MATCH))) - return rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ACTION, NULL, - "target group must be other than" - " the current flow group"); if (table == 0) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:34.716128724 +0800 +++ 0125-net-mlx5-fix-jump-action-validation.patch 2024-03-05 17:39:30.983566500 +0800 @@ -1 +1 @@ -From 9c289272ae692bd03d1dc9726ef19785beedd313 Mon Sep 17 00:00:00 2001 +From 7c8f2e719a182fea1576fe02f9d2e57ef3e17830 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9c289272ae692bd03d1dc9726ef19785beedd313 ] @@ -35 +37,0 @@ -Cc: stable@dpdk.org @@ -44 +46 @@ -index 52620be262..f881dae6e8 100644 +index 115d730317..5d0cb4278b 100644