From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57BA243B86 for ; Tue, 5 Mar 2024 10:51:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51E6E4026B; Tue, 5 Mar 2024 10:51:41 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by mails.dpdk.org (Postfix) with ESMTP id CC44342D7D for ; Tue, 5 Mar 2024 10:51:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kn3VQOYs5QjXH3+LGOWpF+PPDwFltOoV/eeV8pa8Rn9viqzU+RkuXb7clddbq/I29+d6WiQl8N/AqCjCP+EO3DvMJkILLryUZHZVd2NntKxm4kZ7We6q6EZ4gY55tNnVj6aadQSbgE2Ee0HC9LdEW8gupsaUo5JwDAhYgz5U/7XaiKRPknW3b+oEMgUDZKFUIBPYpo0s74iHpMgFjd5663ZyQLu+DJl/TR0HW/sT+0aDqXAVAG7cMDfQ2eiVeTzmk0rNvq+5cV4HtGGGD+TsBbuGo/dJqskeOp+yeeGXrEODCDFilDX8654xkQbAL93VbBnLFYCPY7zOpYhWo+OwDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BVpUUqrvZ2ZPOt4A/oHoDydXru35wONSQd+SGgQA7oI=; b=SfxtoMCsG8h4AbGUzuq3ZCK+w54fyPfO8hxxQeqec0EYjBPXdwMULfvWBDYAYS27FyNLoYZLB0Yk0BJ90fTm159Kq1Dbmv7b3lt8iK4v+i/Lau7pnIp2EqpnryzUUDoVbsDH23+GqyEfFknP7gl3XLdKIlf6xgJ1yGqbq+gk4LdiZD6qn95aNnUBUsfHrc3Y2Jaa5Jrq9MCr//dw0GViSs4VDmiQfRCFm0i9gCPcLV9W0GYJnKLvYt82j5QOgK3lcAXCpqGgcG8TXECZxtoD14m2+O84YdRInNhFMQg9qBpoRLaw8/uHVtCHOHUGR4Nipd7Ry3FR7eetTnGmreRbYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVpUUqrvZ2ZPOt4A/oHoDydXru35wONSQd+SGgQA7oI=; b=O6SlBE/EhFS0zaXk82alrF4vjqHLX5vzOeJPzkMqRrta/dy8ciVaL2riyX4tSQerwMr1TYCodo7YuYjG19e32vbUqrO0vMoxu2RIJ4UOy4TJpBhzBKQeauqTwJkCJimVjihzTTFtGx+39uPYVgTngVbOIwGNhtM5TNeGzqXAi6BC8lwF+GD9MDiCB20ylEm0SBh2t//5H6Oyiey1+NWS48euMVh2L1F+hQbQJnhwwyelzZFKZfkIVGdQSDl23RCD8bLy9sFqYShmlpep1CWdT+sM9VvIaEJiQW1g0hLRllAXLtPSETEcJtxX177RtQT3DW7tXBeiLnZg4BFAm62M4A== Received: from SA9PR13CA0098.namprd13.prod.outlook.com (2603:10b6:806:24::13) by SJ1PR12MB6028.namprd12.prod.outlook.com (2603:10b6:a03:489::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Tue, 5 Mar 2024 09:51:35 +0000 Received: from SN1PEPF0002BA51.namprd03.prod.outlook.com (2603:10b6:806:24:cafe::62) by SA9PR13CA0098.outlook.office365.com (2603:10b6:806:24::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24 via Frontend Transport; Tue, 5 Mar 2024 09:51:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002BA51.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:51:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:51:21 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:51:19 -0800 From: Xueming Li To: Chengwen Feng CC: dpdk stable Subject: patch 'app/pdump: verify strdup return' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:16 +0800 Message-ID: <20240305094757.439387-36-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA51:EE_|SJ1PR12MB6028:EE_ X-MS-Office365-Filtering-Correlation-Id: 571f3ff8-9465-4a61-39a9-08dc3cf9d7f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: budwhP5N1Iirknm8WlYRKi0xQp7alSchWI7yLlDDUxtg0hm+0Ndm8Q0TJSPsPuaFlheX/pLQelVBW4b6LcTF85qKhA7RVB3WzsjAEOG0Bpcu/I7fPbhL801X0HjxMhA6KIdQdnTEdRSz4z17FpFrAs08qBAop06z7UgvbU3xAfouZ392ImuDRp+so9+1WOGgPjPlyKt9Xdgapdv9Pni1vDEzTDmBz+H8IHn7awbO2EvrxCFIN69NCC5GG/PD6itMXLZ69kUFRXuetHeUo7QJHzRvhKQ1H8ebcuQm5I6bNpHLgiA4d7OwWN8Ytwr/TIYTHt+z4Msrl3nub2pbHz/YMK6hJ4yCqVJynPAV5fprOlXteF30oYtK2KAj2E2FyXD1N3PPoRuOtGZtHTq93xyKm3h8raQ/SFbXEbJBZVd6p9TK/Vq0p9iOQu7ntDNZveyEzrZXYlzu4d14AV9Ef9gQqsCRBRKaCIsKAb6CkmVpJ74LWBkNC1XAl5YA0XpU71C8ugO9TXgS/84GW0gz3FjN7LhX5/g/AziCjOmHTN0nQAggio7LljtIIMptnrqPeEm3t02w/GGqhSa/wxz9Jx+b0ajGhJ1hgO1sv3ejgrs/Y+IP6zBJ1V2ThIBwSQXC717xPKxS2YkyakcmCf8r/Deu1bqIdxBnsd5GCabz16q5CGmldJigaaVilW1mTMUG4+A123cSuAJzBb1Dg5XOXakkM4LmPpqeHJb6OUS3Nh/1H8JTLiuoDN8RH7aqq9M4YBmd X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:51:34.6279 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 571f3ff8-9465-4a61-39a9-08dc3cf9d7f6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA51.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6028 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=e0fd44c6abb047b5030d0dd0e8b497c739694368 Thanks. Xueming Li --- >From e0fd44c6abb047b5030d0dd0e8b497c739694368 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:11 +0000 Subject: [PATCH] app/pdump: verify strdup return Cc: Xueming Li [ upstream commit 32e1cb918d4bbe94c5da8d0888ce29fac1f4dbb4 ] Add verify strdup return value logic. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Chengwen Feng --- app/pdump/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 7a1c7bdf60..a9205e130b 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -171,6 +171,9 @@ parse_device_id(const char *key __rte_unused, const char *value, struct pdump_tuples *pt = extra_args; pt->device_id = strdup(value); + if (pt->device_id == NULL) + return -1; + pt->dump_by_type = DEVICE_ID; return 0; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.109601237 +0800 +++ 0035-app-pdump-verify-strdup-return.patch 2024-03-05 17:39:30.723566491 +0800 @@ -1 +1 @@ -From 32e1cb918d4bbe94c5da8d0888ce29fac1f4dbb4 Mon Sep 17 00:00:00 2001 +From e0fd44c6abb047b5030d0dd0e8b497c739694368 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 32e1cb918d4bbe94c5da8d0888ce29fac1f4dbb4 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org