From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A911F43B86 for ; Tue, 5 Mar 2024 10:52:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1851410E7; Tue, 5 Mar 2024 10:52:07 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id 5C55F4026B for ; Tue, 5 Mar 2024 10:52:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6st93XqswUgFwfDIa2XyT1blckuxXVlMPkGeoUIlVaRrKonaUrVBWolGGKwTOvOaGLks1ewLpcLr7O7INJEPSxPqyc6Zi/NOc/4UnzB6vRoMp31Qdhv+k8gNShz75hk0omYHSQbZ40C30urnODnZsl2HQejeRJm0AQSEgnWbGtgM/nEbr4S2ufdRnD9iWUZoT3YHXB8QxcFwoAjP2+v685D2qHKIKImmAVAIuhRRGclGm4wOHKdAMj/RkMWDDiWejkClvhXJMo89Mqp+qKAsJC6vNz3qkSolE+wTy/n22dtprwYV+ob3GldN8BrQq7F7cjh3J0zIxwNO9yrwJYnWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ak9ctwRvdzG5nU6e6zmnGDVYFGLzpDYOAyxLl2L8dwA=; b=b0K+DG5lhaYLOJlkULArvw9DTJtQv+MsstqFDWta3Yem/PnT6eJB1y+W/Pe3pdlpaRNG0rPoDeeF3rDZF5FCQMz34hSWnX2iR4y1NElqN29mx+lynX/pwVCsgeuQ8hXUdGwb6+PePSC4J5N80oODTStbBbQrCtuFtgVxlkrTeqjHHmnHufRra01b2b4E4WvG8ZELZIQ7pi1smtwWOPrHf1ulNysazyK76+zVyE+wMkiAoD8+Z1dMML5vwu76ilEKZ8Pteo0fQEz0o4xac6SeLRAUarHRfC0Kg0SBhGKvw5HTbG4gGB6XG7skGskpWvkr2lSwd080AZMzDzWP2t3xNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ak9ctwRvdzG5nU6e6zmnGDVYFGLzpDYOAyxLl2L8dwA=; b=ouIjabe+LLChAd4cqaNYPGvBxJV39v4zeUXEZJCwqytOkliaEhydqbUFC6NVO6s3dnCH3Y/s+il0eUuqmO31Km1BO2EXeV4WmrZNaQFXy3X8wvqv0FgKVEhdCfSTsRHnsMe1PJXpqi7N8wrvdEHnCbpZhGOYQyZqfJVsXJ37pRCMwXamSGM2xIKcHm8qT/sP0xoFEP7+vtv4rzBtgP2I0msQSRmZ2GzA8zyjcQ5BIomzqggOS2pN2C/yX8D1IGjmSVDa64FijaQWCNeaAa7gq/jDjIPQDczEQXP2XWBcyxaPHLzHmrzcHJbuFRlgQa/8qn8vzCIwu92s7a22Mh0sPg== Received: from SA0PR11CA0163.namprd11.prod.outlook.com (2603:10b6:806:1bb::18) by BL3PR12MB6404.namprd12.prod.outlook.com (2603:10b6:208:3b4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 09:52:02 +0000 Received: from SN1PEPF0002BA4D.namprd03.prod.outlook.com (2603:10b6:806:1bb:cafe::f6) by SA0PR11CA0163.outlook.office365.com (2603:10b6:806:1bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38 via Frontend Transport; Tue, 5 Mar 2024 09:52:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002BA4D.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:52:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:51:53 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:51:52 -0800 From: Xueming Li To: Ferruh Yigit CC: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Chengwen Feng , dpdk stable Subject: patch 'dmadev: fix calloc parameters' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:25 +0800 Message-ID: <20240305094757.439387-45-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4D:EE_|BL3PR12MB6404:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f85a3f9-08cb-4202-c741-08dc3cf9e82c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 07KyzQDJS4aOHBy+Ft1+E2qQqhnb1k3VlM/aosY+mnOgKkw1mW0z0IUcxjjVdqjswQKD7+Ik69D7O1GZONHPnaRhTsQoC7h6TWYUAnKlMtBPs1HiI3/Q992i6O0XPYsLaJqWliJutlGwdAZxYF0T7RCd1NFB8eWHJuz6TNkgwQ4sQDq1j7lRAWukEwIPtyHBacARH4qCQx9WAALohU6SQir5b9i80gGHtP04REna3ddBSLbkvSGQ+dUVmQ5VvvDilutojg6AE4bmMh8XbD/w0S/c74nEKYM2xt5LMDr4kUjgX7wTY4UIxuwucthidaPWTNAlhuygeeFJwaezdvErs0HebKqkrR8707DZvxA2UrxV/40H0tBS33InyWVZOwYHJF7Xr5xKQtCdGAJYZrKKkk9P9r0joSQYWVwYfp6aay8qXD4uwGjddWV1BsuygXST37a2MGk4P8h3szGeY/ioYAjIruw24QVbKZCOAc+vQqJacAcF92DuQtFj/wWkqBDDN5RbbkeXE2IQ3IEt5hBIjOl6M+n+wmWpJuRM6p3qWHacvEW4bPtBhsBwhyLXxLXK4w6e6A8hpbp+kPcCA9aztugD4qhCjLiNmYN0wZDTYVZ9f7S8kzloGkuWcGu0yFXmpL3LNf+89JliOfIrz6S2QoX45FrGfaoW9OZhzFn4A5nCF90qkYf+MfRRqy+g73//XGwHdK+6LHuzG1tGaWkD/aswlRDefUL9y6FXpjiaVss64/qVIpP37fYLwgnitHOP X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:52:01.8289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f85a3f9-08cb-4202-c741-08dc3cf9e82c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6404 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ad881b0db859fe2e4762ab2313a8e2fd4881894f Thanks. Xueming Li --- >From ad881b0db859fe2e4762ab2313a8e2fd4881894f Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 24 Jan 2024 18:54:02 +0000 Subject: [PATCH] dmadev: fix calloc parameters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 905f8335f916aed1f3119e35332a32119dea4510 ] gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_dmadev.a.p/dmadev_rte_dmadev.c.o ../lib/dmadev/rte_dmadev.c: In function ‘dmadev_handle_dev_dump’: ../lib/dmadev/rte_dmadev.c:1033:29: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 1033 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: 94043b04212a ("dmadev: support telemetry dump dmadev") Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng --- lib/dmadev/rte_dmadev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index 009a21849a..31a268cfdb 100644 --- a/lib/dmadev/rte_dmadev.c +++ b/lib/dmadev/rte_dmadev.c @@ -1028,7 +1028,7 @@ dmadev_handle_dev_dump(const char *cmd __rte_unused, if (*end_param != '\0') RTE_DMA_LOG(WARNING, "Extra parameters passed to dmadev telemetry command, ignoring"); - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.350643745 +0800 +++ 0044-dmadev-fix-calloc-parameters.patch 2024-03-05 17:39:30.743566492 +0800 @@ -1 +1 @@ -From 905f8335f916aed1f3119e35332a32119dea4510 Mon Sep 17 00:00:00 2001 +From ad881b0db859fe2e4762ab2313a8e2fd4881894f Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 905f8335f916aed1f3119e35332a32119dea4510 ] @@ -25 +27,0 @@ -Cc: stable@dpdk.org @@ -35 +37 @@ -index 25c92ef8a8..e64b279bac 100644 +index 009a21849a..31a268cfdb 100644 @@ -38 +40 @@ -@@ -1040,7 +1040,7 @@ dmadev_handle_dev_dump(const char *cmd __rte_unused, +@@ -1028,7 +1028,7 @@ dmadev_handle_dev_dump(const char *cmd __rte_unused,