From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D79A843B86 for ; Tue, 5 Mar 2024 10:54:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1BBF4026B; Tue, 5 Mar 2024 10:54:18 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061.outbound.protection.outlook.com [40.107.237.61]) by mails.dpdk.org (Postfix) with ESMTP id E8A5A4014F for ; Tue, 5 Mar 2024 10:54:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAJ3uRLzxvIW3k2ud9WXsZ1J9Do2KEfn8Ni5W8TL80h8u+kb6xfZMovMqO7JOgwl7QarfaouV0HlVX2XkGlVYBK0XcZtElqh4oMIP6p+cPjK/vZ8bEyqqQHHIPBFvv6KkqxUeqUGMWfekOkr8+akEgYr6n2DEOaidLe0v45nI5ccU4G22tziAUFViv5Khr/4zt8V4xSts/1gN1+DEzIj9SfssjmZAOmVDIjUVqCFJm5l73kB2UW1ik6tuaps1+rd1SS9Bi9AwkxfySfMFIdaqRtCFe6olAeit/Y/vY0ipPaHikvx+Z9Og4uRj5GhRtfpZ4p7n6hNJVk3HLl+HN1RDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z59ZNKd2F0oopMBxosjhhixpx4aM/Vv22xxcUR1sV5k=; b=TxXKYL10SXs/JoDD8uBkRMVkekVquf/Gaw57b7QODSkhUVVSHUDzQBpnJfBVTxFNBZyUwgryC220zEjyPC8HRhzWYUpmL6NSTVE73mqICUf2hk5kTXh/1cdENr5Lr2ixZJDkxVdAhFgjBj8tKyT57gT+JZDXYjuUN9hdYM2dPjwoGRzt4z/4J68hyyWMJT8s6PJQl9iHYiwvxalbQFE2tZuAMacfAtcI56v8po8IDau8m6GRhfHK6zRpgXxQuXxFxgxqVjgi1A6gKOehQWtgcZk6XqvyrXAp7k226UFzDR9iJ0S73/PxUGtCoCeE6cy8h+G9fXIkWbIPlXe49maRqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z59ZNKd2F0oopMBxosjhhixpx4aM/Vv22xxcUR1sV5k=; b=F6fRJ0sW8G9EaapGn3N7mrw2muDvqUdAzUvtcXonL8ifWOBuR32WteNctheXWPTjHEJf381LSrjHCN3qn3a/QmG17jKQTqNs16ddZXUOtu5WF1n9VGFcFJkHHK0Q8VOxBz3SEB6DrebGuOh2tkLKHJhfQprUBSt+lc0Y2agUOeRpINe5In23zO36Bw3dvQCBqFHAnwOO4SZBSspNvNJBaSUxcXxOZh6QeAs6H8Whx/7uYFVOnaXq7fLczjSJNoLoBrtnWuL7c3R1cOf7rL5tmm9ON810h2aZ7SgKqbs7MQuw41XV7cn04dgxU8PsDemRMtUNBwTuYOPt0aulmgL+4g== Received: from SJ0PR03CA0156.namprd03.prod.outlook.com (2603:10b6:a03:338::11) by SJ1PR12MB6337.namprd12.prod.outlook.com (2603:10b6:a03:456::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.15; Tue, 5 Mar 2024 09:54:10 +0000 Received: from SJ5PEPF000001D2.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::a6) by SJ0PR03CA0156.outlook.office365.com (2603:10b6:a03:338::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:54:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001D2.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:54:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:54:00 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:53:58 -0800 From: Xueming Li To: Gowrishankar Muthukrishnan CC: Akhil Goyal , dpdk stable Subject: patch 'crypto/cnxk: fix CN9K ECDH public key verification' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:46 +0800 Message-ID: <20240305094757.439387-66-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001D2:EE_|SJ1PR12MB6337:EE_ X-MS-Office365-Filtering-Correlation-Id: f73a4048-1647-4fb0-dfb3-08dc3cfa34e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DFtKbKDen5aMTwnyDihj+/738Qs+bBiOpi8O1W/WKV+JGri7tqofRR0u1yQcII7sDo9Y251Wrxkim8MFKGbrW3j5Bxey1P31a8/GeSkykddKSeVY7obuc9tar9eJ2Npi951sXIn+JKfdMNm74Wq+rbLgLIJtyDRgMhA92RrzBELm9K9Yf1Nnv+uoIV9iLaotAbiPMGJGogSAXFAKCKrYBhg0wbBjiwpcECQPUuO9KlTa2iK+C9Q3Y0K9vOus1QHJQ5ampj6ImHn9303R3gl2f/3aaz5ldMHaVr79A2Q8ac+fuxIWdw0wAduN3yDcnTwakA3GzuVk8jo2MWCN/YRzVLqsy5ZcH/P1w2CnjR+BiSDC8LoxKmW7HAomZjjh6vi4G+qjlp/xSNQdBcL7FyWqkR1dsnGVbAPPdQb6tfqmyN1dJca17q/W25U6yIf+W2C7J52p6ba4IXxOCymmNlrc8EVo6VvSqL7mvR0F9Z1NlFFY90ukzVPF5gfB8gM71XKwY82wAbYv8au8rXO9CVUxtGr4jaGVnwbI+t6r+OBs+3efiMxUi/Veqx7S7d1ZX7PSRRxgc7Ex4Wr7elThO7FbkZGsi5IV/5C/fg9d00pFY6t71P1taXMllVTrRGvWuR5JzAAT60C6CbwE+yNBr1qzl320Iy5qlapfgvANsdpvTwghBHEq2RbZgmD0dIiqg3FQsziZBxuB3LEM9uIMgbMu/F/NLuAKaGCZyDL3mCWGMjs4BE91jbSylVPoENGfSrrv X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:54:10.6713 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f73a4048-1647-4fb0-dfb3-08dc3cfa34e7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001D2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6337 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=8988726643bc4e51fc69195f98fde69422761cf0 Thanks. Xueming Li --- >From 8988726643bc4e51fc69195f98fde69422761cf0 Mon Sep 17 00:00:00 2001 From: Gowrishankar Muthukrishnan Date: Wed, 17 Jan 2024 16:00:50 +0530 Subject: [PATCH] crypto/cnxk: fix CN9K ECDH public key verification Cc: Xueming Li [ upstream commit 5c90255831675489f3e303f7c2b08012f8401505 ] Fix ECDH pubkey verify in cn9k. Fixes: baae0994fa96 ("crypto/cnxk: support ECDH") Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c index 34d40b07d4..442cd8e5a9 100644 --- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c +++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c @@ -578,7 +578,17 @@ cn9k_cpt_dequeue_post_process(struct cnxk_cpt_qp *qp, struct rte_crypto_op *cop, if (unlikely(res->uc_compcode)) { if (res->uc_compcode == ROC_SE_ERR_GC_ICV_MISCOMPARE) cop->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED; - else + else if (cop->type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC && + cop->sess_type == RTE_CRYPTO_OP_WITH_SESSION && + cop->asym->ecdh.ke_type == RTE_CRYPTO_ASYM_KE_PUB_KEY_VERIFY) { + if (res->uc_compcode == ROC_AE_ERR_ECC_POINT_NOT_ON_CURVE) { + cop->status = RTE_CRYPTO_OP_STATUS_ERROR; + return; + } else if (res->uc_compcode == ROC_AE_ERR_ECC_PAI) { + cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS; + return; + } + } else cop->status = RTE_CRYPTO_OP_STATUS_ERROR; plt_dp_info("Request failed with microcode error"); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.903248864 +0800 +++ 0065-crypto-cnxk-fix-CN9K-ECDH-public-key-verification.patch 2024-03-05 17:39:30.783566493 +0800 @@ -1 +1 @@ -From 5c90255831675489f3e303f7c2b08012f8401505 Mon Sep 17 00:00:00 2001 +From 8988726643bc4e51fc69195f98fde69422761cf0 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 5c90255831675489f3e303f7c2b08012f8401505 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index 8b91d11b79..ccbd390bd7 100644 +index 34d40b07d4..442cd8e5a9 100644