From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E08343829 for ; Tue, 5 Mar 2024 16:35:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8904542DC9; Tue, 5 Mar 2024 16:35:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4972E42DD3 for ; Tue, 5 Mar 2024 16:35:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOuntqclqR/BBofF/BvBtN1CYKnZCSb13iOplV6nRF8=; b=gec23x5MV5WK051+HJKQ8bivKPTG4NwuS+c/Pdnw/2YvpGol6Ing9btkv4ik7Ech9Dg8Pk Git0lCOzkoympkoEOVnOYti6TnmnDi6AzmZXgN2u4hdzHORGCCB/0kf2yM0233SOMMoYkj Z/h3haWUcfVT9GR4zgAabgbjDnOXhGE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-MR-aYjblP4q56ZmcK2I4eg-1; Tue, 05 Mar 2024 10:35:20 -0500 X-MC-Unique: MR-aYjblP4q56ZmcK2I4eg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61505185A781; Tue, 5 Mar 2024 15:35:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id A18972022C24; Tue, 5 Mar 2024 15:35:19 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: dpdk stable Subject: patch 'net/failsafe: fix memory leak in args parsing' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:33:50 +0000 Message-ID: <20240305153449.263666-17-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b8422c5011caa63214bc3d343e56208eb84fbedb Thanks. Kevin --- >From b8422c5011caa63214bc3d343e56208eb84fbedb Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:08 +0000 Subject: [PATCH] net/failsafe: fix memory leak in args parsing [ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index b203e02d9a..3b867437d7 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -249,5 +249,5 @@ fs_parse_device_param(struct rte_eth_dev *dev, const char *param, } else { ERROR("Unrecognized device type: %.*s", (int)b, param); - return -EINVAL; + ret = -EINVAL; } free_args: -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:55.125535921 +0000 +++ 0017-net-failsafe-fix-memory-leak-in-args-parsing.patch 2024-03-05 14:08:54.626520702 +0000 @@ -1 +1 @@ -From 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 Mon Sep 17 00:00:00 2001 +From b8422c5011caa63214bc3d343e56208eb84fbedb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org