From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B88D743BA7 for ; Tue, 5 Mar 2024 16:35:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B31F642D2E; Tue, 5 Mar 2024 16:35:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 047D942686 for ; Tue, 5 Mar 2024 16:35:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Zz6yoxsGu3W5ua+MNIVec4Fz68DF4fiCLDQDBWZp6E=; b=QB2jSTtuxwA2GlOIMTVIDqSQlK3LLlYEn5tmW3lsDQcAJ/oHpsyQdU4RSCwQcpWFbmP9Fm IcMvRXOMsgkPIFjnHN9WByByKIApnZQt7g1ji1ecf5Bx8m+J0g/uyjE/iD+cAUBf89kpaa RvaAmksUlOkUfHnhRdpsTZnT7WknEVc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-Y3IvZcEQNumMii1R5Nvpbg-1; Tue, 05 Mar 2024 10:35:23 -0500 X-MC-Unique: Y3IvZcEQNumMii1R5Nvpbg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 209DE1C01E86; Tue, 5 Mar 2024 15:35:23 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98F92200AFA2; Tue, 5 Mar 2024 15:35:22 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: dpdk stable Subject: patch 'app/crypto-perf: verify strdup return' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:33:53 +0000 Message-ID: <20240305153449.263666-20-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/868c62ad591652fc8623ed4c5f04c02a0c711e58 Thanks. Kevin --- >From 868c62ad591652fc8623ed4c5f04c02a0c711e58 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:13 +0000 Subject: [PATCH] app/crypto-perf: verify strdup return [ upstream commit bf4728da1842bd264b2038e9f67e519ae9a0b4e3 ] Add verify strdup return value logic. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Chengwen Feng --- app/test-crypto-perf/cperf_options_parsing.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index 1d91bea0c9..c29a1c31e1 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -502,4 +502,8 @@ parse_test_file(struct cperf_options *opts, { opts->test_file = strdup(arg); + if (opts->test_file == NULL) { + RTE_LOG(ERR, USER1, "Dup vector file failed!\n"); + return -1; + } if (access(opts->test_file, F_OK) != -1) return 0; -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:55.187363364 +0000 +++ 0020-app-crypto-perf-verify-strdup-return.patch 2024-03-05 14:08:54.628520707 +0000 @@ -1 +1 @@ -From bf4728da1842bd264b2038e9f67e519ae9a0b4e3 Mon Sep 17 00:00:00 2001 +From 868c62ad591652fc8623ed4c5f04c02a0c711e58 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bf4728da1842bd264b2038e9f67e519ae9a0b4e3 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ -index 75afedc7fd..8909b5690d 100644 +index 1d91bea0c9..c29a1c31e1 100644 @@ -20 +21 @@ -@@ -517,4 +517,8 @@ parse_test_file(struct cperf_options *opts, +@@ -502,4 +502,8 @@ parse_test_file(struct cperf_options *opts,