From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10CD443829 for ; Tue, 5 Mar 2024 16:35:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C1ED42DE9; Tue, 5 Mar 2024 16:35:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8C6CB42686 for ; Tue, 5 Mar 2024 16:35:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e+WWtCiL2dLnd2V5YYE37J4zq+ZNvuBni2daom3QuMs=; b=a10JiGIickfg0vFEoAMehA6+/f/AZTT0Szg0ezbo5BNiL2sL/ycSJ9tLGtqQmKpfqNNcK7 Qoiw1n2n+qwBodaYPoAiQYTwDg7L5gqlkg1++dlvhVKjlU0bsRAXathPjQVb1utaP/cDoM T/s0lR6a63+egjsgsMPcxfB7DExVb88= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-ClWjOeVkOD2q0kDB1LYRng-1; Tue, 05 Mar 2024 10:35:24 -0500 X-MC-Unique: ClWjOeVkOD2q0kDB1LYRng-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E4AC101A586; Tue, 5 Mar 2024 15:35:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73647200AFA2; Tue, 5 Mar 2024 15:35:23 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: Huisong Li , dpdk stable Subject: patch 'test: verify strdup return' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:33:54 +0000 Message-ID: <20240305153449.263666-21-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f30f9a3c5e8b07630ca28b9355cfba56ca9f53ed Thanks. Kevin --- >From f30f9a3c5e8b07630ca28b9355cfba56ca9f53ed Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:12 +0000 Subject: [PATCH] test: verify strdup return [ upstream commit 68edcacf428994d3088afb6f5278958cc76665da ] Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Signed-off-by: Chengwen Feng Acked-by: Huisong Li --- app/test/process.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/process.h b/app/test/process.h index 5b10cf64df..622cb0b218 100644 --- a/app/test/process.h +++ b/app/test/process.h @@ -58,6 +58,9 @@ process_dup(const char *const argv[], int numargs, const char *env_value) else if (pid == 0) { /* make a copy of the arguments to be passed to exec */ - for (i = 0; i < numargs; i++) + for (i = 0; i < numargs; i++) { argv_cpy[i] = strdup(argv[i]); + if (argv_cpy[i] == NULL) + rte_panic("Error dup args\n"); + } argv_cpy[i] = NULL; num = numargs; -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:55.207991337 +0000 +++ 0021-test-verify-strdup-return.patch 2024-03-05 14:08:54.629520709 +0000 @@ -1 +1 @@ -From 68edcacf428994d3088afb6f5278958cc76665da Mon Sep 17 00:00:00 2001 +From f30f9a3c5e8b07630ca28b9355cfba56ca9f53ed Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 68edcacf428994d3088afb6f5278958cc76665da ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index af7bc3e0de..c576c42349 100644 +index 5b10cf64df..622cb0b218 100644 @@ -21 +22 @@ -@@ -60,6 +60,9 @@ process_dup(const char *const argv[], int numargs, const char *env_value) +@@ -58,6 +58,9 @@ process_dup(const char *const argv[], int numargs, const char *env_value)