From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB8C43829 for ; Tue, 5 Mar 2024 16:35:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96A8842DFC; Tue, 5 Mar 2024 16:35:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8126942686 for ; Tue, 5 Mar 2024 16:35:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709652932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wS7Vd42S1KFTZ5h2U9ryizZY0Zcw1KRcLVlwBTVki0o=; b=DWlQI6y2jmFUNZvRVT8AKceyB51H7qRUnIcf4zmBd0IzYfiuvHb/2qOtGf3kAo/Eb8/CwG gsaqwMkCQGhCviCxld6hQVPDaoQS7XMVBwDxNCik4osoFTcAgJ2SfASht3OFQhrJGEUk4y +u4aExVfvtDEP4y4JzlKh9Cda6tuV/g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-XY2ZouHtP7W67M0o4gLIeA-1; Tue, 05 Mar 2024 10:35:30 -0500 X-MC-Unique: XY2ZouHtP7W67M0o4gLIeA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86A7429AA3B9; Tue, 5 Mar 2024 15:35:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8D072022AA9; Tue, 5 Mar 2024 15:35:29 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: dpdk stable Subject: patch 'build: fix linker warnings about undefined symbols' has been queued to stable release 21.11.7 Date: Tue, 5 Mar 2024 15:33:59 +0000 Message-ID: <20240305153449.263666-26-ktraynor@redhat.com> In-Reply-To: <20240305153449.263666-1-ktraynor@redhat.com> References: <20240305153449.263666-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/11/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d27dfc1a757f032cc07eea5c6cc76d8e98765b88 Thanks. Kevin --- >From d27dfc1a757f032cc07eea5c6cc76d8e98765b88 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 10 Jan 2024 15:01:03 +0000 Subject: [PATCH] build: fix linker warnings about undefined symbols [ upstream commit 51c9428dca9fad10bd60ca668ffdf78e4a801e2f ] The default behaviour of "ld.lld" has changed, so it now prints out warnings about entries in the version.map file which don't exist in the current build. Since we use our version.map file simply to filter out the functions we don't want made public, we include in it all functions across all OS's and builds that we want public if present. This causes these ld warnings to be emitted, e.g. on BSD, which is missing functionality found on Linux. For example: * hpet functions in EAL * regexdev enqueue and dequeue burst * eventdev event_timer functions Easiest solution, without major rework of how we use our version.map files, and without dynamically generating them per-build, is to pass the --undefined-version flag to the linker, to restore the old behaviour. Signed-off-by: Bruce Richardson --- config/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/meson.build b/config/meson.build index a79a3ed39c..63a4eb9f7e 100644 --- a/config/meson.build +++ b/config/meson.build @@ -145,4 +145,7 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4) if not is_windows add_project_link_arguments('-Wl,--no-as-needed', language: 'c') + if cc.has_link_argument('-Wl,--undefined-version') + add_project_link_arguments('-Wl,--undefined-version', language: 'c') + endif endif -- 2.43.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 14:08:55.318343313 +0000 +++ 0026-build-fix-linker-warnings-about-undefined-symbols.patch 2024-03-05 14:08:54.640520739 +0000 @@ -1 +1 @@ -From 51c9428dca9fad10bd60ca668ffdf78e4a801e2f Mon Sep 17 00:00:00 2001 +From d27dfc1a757f032cc07eea5c6cc76d8e98765b88 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 51c9428dca9fad10bd60ca668ffdf78e4a801e2f ] + @@ -23,2 +24,0 @@ -Cc: stable@dpdk.org - @@ -31 +31 @@ -index a9ccd56deb..65662c5de3 100644 +index a79a3ed39c..63a4eb9f7e 100644 @@ -34 +34 @@ -@@ -189,4 +189,7 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4) +@@ -145,4 +145,7 @@ dpdk_conf.set('RTE_ARCH_32', cc.sizeof('void *') == 4)